Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-16437

Extract MailAddressResolvers to dedicated plugins

    XMLWordPrintable

Details

    Description

      Extract resolvers into separate plugins to allow administrator to decide which resolvers to use.

      Attachments

        Issue Links

          depends on

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-15440 Emailing users at the end of a failed build very slow for big Jenkins instance using subversion

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-16389 Emailing users at the end of a failed build very slow for big Jenkins instance using CVS

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved
          is blocking

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-16342 asynchPeople very slow when using Gravatar & Subversion plugins

          • Critical - Crashes, loss of data, severe memory leak.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-14755 Mail address resolution can take a significant amount of time

          • Major - Major loss of function.
          • Resolved
          is related to

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-11990 After updating Active Directory plugin the Jenkins People database is experiencing massive performance issues synching because it is trying to authenticate users that are no longer in company Active Directory but are part of the Jenkins Database

          • Critical - Crashes, loss of data, severe memory leak.
          • Open

          Activity

            Ascending order - Click to sort in descending order
            View 5 older comments
            jglick Jesse Glick added a comment -

            I have to agree with @kutzi that having published plugins known to cause abysmal performance problems is not a good idea. Lots of people will just blindly install stuff and not read the warnings. Better to unconditionally delete bad code.

            If there is a real use case for mail address resolvers that infer information from build records, then they should be written carefully to have reasonable performance. For example:

            • require the user to specify a sample job or jobs, rather than searching every job in the Jenkins installation
            • inspect only up to some maximum number of build records per job (with lazy loading this is especially critical)
            • cache information obtained from such searches, e.g. using the Database plugin, so you have only a one-time hit
            jglick Jesse Glick added a comment - I have to agree with @kutzi that having published plugins known to cause abysmal performance problems is not a good idea. Lots of people will just blindly install stuff and not read the warnings. Better to unconditionally delete bad code. If there is a real use case for mail address resolvers that infer information from build records, then they should be written carefully to have reasonable performance. For example: require the user to specify a sample job or jobs, rather than searching every job in the Jenkins installation inspect only up to some maximum number of build records per job (with lazy loading this is especially critical) cache information obtained from such searches, e.g. using the Database plugin, so you have only a one-time hit
            olivergondza Oliver Gondža added a comment -

            Well, lets try to delete it.

            https://github.com/jenkinsci/mailer-plugin/pull/6

            olivergondza Oliver Gondža added a comment - Well, lets try to delete it. https://github.com/jenkinsci/mailer-plugin/pull/6
            jglick Jesse Glick added a comment -

            For the record, my proposal was to delete the known plugins implementing MailAddressResolver poorly, not to delete the extension point itself which is not inherently harmful.

            jglick Jesse Glick added a comment - For the record, my proposal was to delete the known plugins implementing MailAddressResolver poorly, not to delete the extension point itself which is not inherently harmful.
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Christoph Kutzinski
            Path:
            src/main/java/hudson/tasks/MailAddressResolver.java
            http://jenkins-ci.org/commit/mailer-plugin/d97647e6bc5fffaafffe9621c8ffbd5d13877b2b
            Log:
            Merge pull request #5 from jenkinsci/wiki_link

            JENKINS-16437 Link to mail address resolution wiki page

            Compare: https://github.com/jenkinsci/mailer-plugin/compare/78a9e893e0b0...d97647e6bc5f

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Christoph Kutzinski Path: src/main/java/hudson/tasks/MailAddressResolver.java http://jenkins-ci.org/commit/mailer-plugin/d97647e6bc5fffaafffe9621c8ffbd5d13877b2b Log: Merge pull request #5 from jenkinsci/wiki_link JENKINS-16437 Link to mail address resolution wiki page Compare: https://github.com/jenkinsci/mailer-plugin/compare/78a9e893e0b0...d97647e6bc5f
            kutzi kutzi added a comment -

            Setting to fixed since this has been done for the CVS and the SVN plugin

            kutzi kutzi added a comment - Setting to fixed since this has been done for the CVS and the SVN plugin

            People

              Unassigned Unassigned
              olivergondza Oliver Gondža
              Votes:
              1 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: