Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-1679

is trailing slash in action url really fixed?

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Component/s: plugin-proposals
    • Labels:
      None
    • Environment:
      Platform: All, OS: All
    • Similar Issues:

      Description

      This is a comment regarding issue 1335. Apologies in advance for the
      duplication but I didn't see how/where to reopen the existing issue.

      I still see the/a problem as of v1.213. I took a look at
      lib/hudson/actions.jelly and a trailing slash is appended to my custom action:
      <l:task icon="${h.getIconFilePath(action)}" title="${action.displayName}"
      href="${h.getActionUrl(it.url,action)}/" />

        Attachments

          Activity

          Hide
          frizbog frizbog added a comment -

          Confirmed. Checked in correction to actions.jelly. Related items checked in
          during the original fix are fine.

          Show
          frizbog frizbog added a comment - Confirmed. Checked in correction to actions.jelly. Related items checked in during the original fix are fine.
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in hudson
          User: : kohsuke
          Path:
          trunk/www/changelog.html
          http://fisheye4.cenqua.com/changelog/hudson/?cs=9665
          Log:
          recording JENKINS-1679. Targeted for 1.220.

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in hudson User: : kohsuke Path: trunk/www/changelog.html http://fisheye4.cenqua.com/changelog/hudson/?cs=9665 Log: recording JENKINS-1679 . Targeted for 1.220.
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in hudson
          User: : mindless
          Path:
          trunk/hudson/main/core/src/main/java/hudson/Functions.java
          http://fisheye4.cenqua.com/changelog/hudson/?cs=23393
          Log:
          [FIXED JENKINS-4720] Don't always append / to non-absolute action URLs,
          as this may break some links (.../*.html for example).
          See related JENKINS-1335, JENKINS-1679, r347 and r11319.
          Updated hyperlinkMatchesCurrentPage to ignore trailing / in matching
          to avoid regression in bold context links.
          Also fixed tiny bug introduced in r13815 where "/" was changed to "."
          in moving code from jelly to Functions, causing a couple links in
          LogRecorder area (with href=".") to not show as bold.

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in hudson User: : mindless Path: trunk/hudson/main/core/src/main/java/hudson/Functions.java http://fisheye4.cenqua.com/changelog/hudson/?cs=23393 Log: [FIXED JENKINS-4720] Don't always append / to non-absolute action URLs, as this may break some links (.../*.html for example). See related JENKINS-1335 , JENKINS-1679 , r347 and r11319. Updated hyperlinkMatchesCurrentPage to ignore trailing / in matching to avoid regression in bold context links. Also fixed tiny bug introduced in r13815 where "/" was changed to "." in moving code from jelly to Functions, causing a couple links in LogRecorder area (with href=".") to not show as bold.
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in hudson
          User: : ashlux
          Path:
          trunk/hudson/plugins/statusmonitor/pom.xml
          trunk/hudson/plugins/statusmonitor/src/main/java/hudson/plugins/statusmonitor/MonitorAction.java
          trunk/hudson/plugins/statusmonitor/src/test/java/hudson/plugins/statusmonitor/MonitorActionTest.java
          http://fisheye4.cenqua.com/changelog/hudson/?cs=25248
          Log:
          [FIXED JENKINS-1679] Add support for Maven and matrix projects.

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in hudson User: : ashlux Path: trunk/hudson/plugins/statusmonitor/pom.xml trunk/hudson/plugins/statusmonitor/src/main/java/hudson/plugins/statusmonitor/MonitorAction.java trunk/hudson/plugins/statusmonitor/src/test/java/hudson/plugins/statusmonitor/MonitorActionTest.java http://fisheye4.cenqua.com/changelog/hudson/?cs=25248 Log: [FIXED JENKINS-1679] Add support for Maven and matrix projects.

            People

            Assignee:
            Unassigned Unassigned
            Reporter:
            jonathan_w_brown jonathan_w_brown
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: