Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-16859

Plugin forgets "Ignore Exit Code" setting

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Major Major
    • valgrind-plugin
    • None
    • RHEL6

      We have some unit tests that fail when running under valgrind (which causes a bad exit status). This causes the build to fail, so we use the "ignore exit code" setting in the valgrind plugin. However, it appears that sometimes (perhaps when changing some other setting?) the "ignore exit code" config parameter is forgotten, and we get failed builds because the exit code is no longer ignored.

      Can you please teach it to remember that code when changing other settings in the job configuration?

          [JENKINS-16859] Plugin forgets "Ignore Exit Code" setting

          André Schramm added a comment -

          I can confirm and reproduce this (Jenkins 1.538, Valgrind-PI 0.20):

          • enable Runner in job config, leave "Ignore exit code" unchecked and hit "Save"
          • $ grep -i ignoreexit config.xml
            <ignoreExitCode>false</ignoreExitCode>
          • go back to job config, enable "Ignore exit code" and hit "Save"
          • $ grep -i ignoreexit config.xml
            <ignoreExitCode>true</ignoreExitCode>
          • go back to job config, "Ignore exit code" is not check though XML says otherwise and job build will fail

          André Schramm added a comment - I can confirm and reproduce this (Jenkins 1.538, Valgrind-PI 0.20): enable Runner in job config, leave "Ignore exit code" unchecked and hit "Save" $ grep -i ignoreexit config.xml <ignoreExitCode>false</ignoreExitCode> go back to job config, enable "Ignore exit code" and hit "Save" $ grep -i ignoreexit config.xml <ignoreExitCode>true</ignoreExitCode> go back to job config, "Ignore exit code" is not check though XML says otherwise and job build will fail

          Johannes Ohlemacher added a comment -

          Ok, i will look into it.

          Johannes Ohlemacher added a comment - Ok, i will look into it.

          cy prunier added a comment -

          I think it's just a missing getter.
          I tried to patch this here https://github.com/zaitchev/valgrind-plugin
          The pull request is on

          cy prunier added a comment - I think it's just a missing getter. I tried to patch this here https://github.com/zaitchev/valgrind-plugin The pull request is on

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Prunier Charles-Yves
          Path:
          src/main/java/org/jenkinsci/plugins/valgrind/ValgrindBuilder.java
          http://jenkins-ci.org/commit/valgrind-plugin/6dddb30132cba3235e810882175c5fa137e3f87d
          Log:
          FIXED JENKINS-16859 Plugin forgets 'Ignore Exit Code' setting

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Prunier Charles-Yves Path: src/main/java/org/jenkinsci/plugins/valgrind/ValgrindBuilder.java http://jenkins-ci.org/commit/valgrind-plugin/6dddb30132cba3235e810882175c5fa137e3f87d Log: FIXED JENKINS-16859 Plugin forgets 'Ignore Exit Code' setting

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Johannes Ohlemacher
          Path:
          src/main/java/org/jenkinsci/plugins/valgrind/ValgrindBuilder.java
          http://jenkins-ci.org/commit/valgrind-plugin/6ec7614d14edbd96d2f4612f1b68231c00172ec8
          Log:
          Merge pull request #4 from zaitchev/master

          FIXED JENKINS-16859 Plugin forgets 'Ignore Exit Code' setting

          Compare: https://github.com/jenkinsci/valgrind-plugin/compare/26d1b61ab930...6ec7614d14ed

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Johannes Ohlemacher Path: src/main/java/org/jenkinsci/plugins/valgrind/ValgrindBuilder.java http://jenkins-ci.org/commit/valgrind-plugin/6ec7614d14edbd96d2f4612f1b68231c00172ec8 Log: Merge pull request #4 from zaitchev/master FIXED JENKINS-16859 Plugin forgets 'Ignore Exit Code' setting Compare: https://github.com/jenkinsci/valgrind-plugin/compare/26d1b61ab930...6ec7614d14ed

          Johannes Ohlemacher added a comment - - edited

          fixed with version 0.21

          Johannes Ohlemacher added a comment - - edited fixed with version 0.21

            existence Johannes Ohlemacher
            schazamp Andrew Schamp
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

              Created:
              Updated:
              Resolved: