• Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • core

      When a GET request is sent to a resource which (generally for security reasons) requires POST, an appropriate response code should be sent, so that clients such as python-jenkins may properly report the error.

      • Most such web methods use @RequirePOST, for which currently a 500 is sent because org.kohsuke.stapler.interceptor.RequirePOST$Processor simply throws IllegalAccessException.
      • Build-like requests use BuildAuthorizationToken which forwards to requirePOST.jelly with a 200, which is no good. (If a token is supplied but is incorrect, it more reasonably sends a 403, via AccessDeniedException.)

      Both cases should probably send a 405 ("Method Not Allowed") with Allow: POST, though a 403 would not be inappropriate for the latter case since under some circumstances GET is still allowed for compatibility.

          [JENKINS-16918] @RequirePOST and similar should send a 405

          Jesse Glick created issue -
          Jesse Glick made changes -
          Link New: This issue is blocking SECURITY-13 [ SECURITY-13 ]
          Jesse Glick made changes -
          Link New: This issue is blocking SECURITY-16 [ SECURITY-16 ]
          Jesse Glick made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]
          SCM/JIRA link daemon made changes -
          Resolution New: Fixed [ 1 ]
          Status Original: In Progress [ 3 ] New: Resolved [ 5 ]
          Philippe Jandot made changes -
          Link New: This issue is related to JENKINS-19281 [ JENKINS-19281 ]
          Jesse Glick made changes -
          Labels New: 1.509.4-fixed
          R. Tyler Croy made changes -
          Workflow Original: JNJira [ 147748 ] New: JNJira + In-Review [ 192565 ]

            jglick Jesse Glick
            jglick Jesse Glick
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: