Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-16971

TAP Plug-in not showing TAP contents if it resides in a subdirectory

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      If the TAP file is created under any subdirectory, the contents are now shown to the user.

        Attachments

          Activity

          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Bruno P. Kinoshita
          Path:
          src/main/java/org/tap4j/plugin/TapParser.java
          src/main/java/org/tap4j/plugin/TapResult.java
          src/main/java/org/tap4j/plugin/util/Util.java
          src/test/java/org/tap4j/plugin/util/TestUtil.java
          http://jenkins-ci.org/commit/tap-plugin/e8dcf5cae68f940143d6b46119829b0e1ab3582c
          Log:
          [FIXED JENKINS-16971] Fixed blank content for TAP files residing in subdirectories


          You received this message because you are subscribed to the Google Groups "Jenkins Commits" group.
          To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscribe@googlegroups.com.
          For more options, visit https://groups.google.com/groups/opt_out.

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Bruno P. Kinoshita Path: src/main/java/org/tap4j/plugin/TapParser.java src/main/java/org/tap4j/plugin/TapResult.java src/main/java/org/tap4j/plugin/util/Util.java src/test/java/org/tap4j/plugin/util/TestUtil.java http://jenkins-ci.org/commit/tap-plugin/e8dcf5cae68f940143d6b46119829b0e1ab3582c Log: [FIXED JENKINS-16971] Fixed blank content for TAP files residing in subdirectories – You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out .
          Hide
          goodell Dave Goodell added a comment -

          This change (https://github.com/jenkinsci/tap-plugin/commit/e8dcf5c) breaks my Jenkins TAP plugin installation. Specifically, the detail links on the http://jenkins.example.org/job/JOBNAME/BUILDNUM/tapTestReport/ page are incorrect. They should read something like http://jenkins.example.org/job/JOBNAME/BUILDNUM/tapTestReport/summary.tap-1/. Instead they read something like http://jenkins.example.org/var/lib/jenkins/jobs/JOBNAME/builds/2013-04-04_12-43-45/tap-master-files/test/mpi/summary.tap-1/. Obviously this URL is invalid and yields an HTTP 404 from the web server.

          I suspect the problem is caused by the replacement of `getName()` with `getAbsolutePath()`. Reverting commit e8dcf5c fixes the error in my otherwise clean build of 80a01b1. I made no attempt to test or understand the issue actually reported in and/or addressed by this ticket (JENKINS-16971).

          Show
          goodell Dave Goodell added a comment - This change ( https://github.com/jenkinsci/tap-plugin/commit/e8dcf5c ) breaks my Jenkins TAP plugin installation. Specifically, the detail links on the http://jenkins.example.org/job/JOBNAME/BUILDNUM/tapTestReport/ page are incorrect. They should read something like http://jenkins.example.org/job/JOBNAME/BUILDNUM/tapTestReport/summary.tap-1/ . Instead they read something like http://jenkins.example.org/var/lib/jenkins/jobs/JOBNAME/builds/2013-04-04_12-43-45/tap-master-files/test/mpi/summary.tap-1/ . Obviously this URL is invalid and yields an HTTP 404 from the web server. I suspect the problem is caused by the replacement of `getName()` with `getAbsolutePath()`. Reverting commit e8dcf5c fixes the error in my otherwise clean build of 80a01b1. I made no attempt to test or understand the issue actually reported in and/or addressed by this ticket ( JENKINS-16971 ).
          Hide
          kinow Bruno P. Kinoshita added a comment -

          Fixed in 1.10

          Show
          kinow Bruno P. Kinoshita added a comment - Fixed in 1.10
          Hide
          goodell Dave Goodell added a comment -

          By "Fixed in 1.10", you mean that the original bug (something with subdirectories) was fixed, right? The bug which I recently reported does not appear to be resolved by any commits newer than 80a01b1 listed on the GitHub page. Do you need me to file a separate bug report for my issue?

          Show
          goodell Dave Goodell added a comment - By "Fixed in 1.10", you mean that the original bug (something with subdirectories) was fixed, right? The bug which I recently reported does not appear to be resolved by any commits newer than 80a01b1 listed on the GitHub page. Do you need me to file a separate bug report for my issue?
          Hide
          kinow Bruno P. Kinoshita added a comment -

          Hi Dave.

          What's your bug ID? Usually I try to merge/code the necessary changes and prepare a new release. Then I execute a Maven release and close issues with Fixed mentioning the version number. It takes few hours to the Update Site sync the release and make it available to end users.

          Show
          kinow Bruno P. Kinoshita added a comment - Hi Dave. What's your bug ID? Usually I try to merge/code the necessary changes and prepare a new release. Then I execute a Maven release and close issues with Fixed mentioning the version number. It takes few hours to the Update Site sync the release and make it available to end users.
          Hide
          goodell Dave Goodell added a comment -

          By "The bug which I recently reported..." I meant my previous comment on this issue (16971): https://issues.jenkins-ci.org/browse/JENKINS-16971?focusedCommentId=176675&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-176675

          That is, I was reporting a bug that appears to have been introduced by the fix (commit hash e8dcf5c) to this issue (JENKINS-16971). I can file a separate issue/ticket for it if you want, but it seems unnecessary.

          Show
          goodell Dave Goodell added a comment - By "The bug which I recently reported..." I meant my previous comment on this issue (16971): https://issues.jenkins-ci.org/browse/JENKINS-16971?focusedCommentId=176675&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-176675 That is, I was reporting a bug that appears to have been introduced by the fix (commit hash e8dcf5c) to this issue ( JENKINS-16971 ). I can file a separate issue/ticket for it if you want, but it seems unnecessary.
          Hide
          kinow Bruno P. Kinoshita added a comment -

          My bad, I think I clicked in the e-mail link, and it opened a Window with only your last comment (or I simply missed the thread). Sorry.

          Yup, if you could file another issue, please. I'm working on testlink-plugin, but I'll use the momentum to fix your issue and the remaining ones in tap-plugin. Should cut a new release by next week (hopefully :=)

          Cheers, Bruno

          Show
          kinow Bruno P. Kinoshita added a comment - My bad, I think I clicked in the e-mail link, and it opened a Window with only your last comment (or I simply missed the thread). Sorry. Yup, if you could file another issue, please. I'm working on testlink-plugin, but I'll use the momentum to fix your issue and the remaining ones in tap-plugin. Should cut a new release by next week (hopefully :=) Cheers, Bruno
          Show
          goodell Dave Goodell added a comment - New issue is JENKINS-17504 : https://issues.jenkins-ci.org/browse/JENKINS-17504

            People

            Assignee:
            kinow Bruno P. Kinoshita
            Reporter:
            kinow Bruno P. Kinoshita
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: