Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-16976

[publish-over-ftp-1.8] upload creates unneeded folders

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      There are actually 2 flavors to the same bug (it should be maybe 2 bugs):
      1. in non-flaten mode, if the uploaded file path is - for example - dir1/dir2/dir3/file.zip then it creates those folders in the FTP server: dir2, dir3, dir1/dir2/dir3 (where it puts the file). The creation of dir2 and dir3 is wrong!
      2. in flaten and non-flaten modes, if the target folder has - for example - the format dir1/dir2/dir3, the created folders in the FTP server are: dir1, dir2 and dir3 while it should create only a structure of dir1/dir2/dir3 and puts it there

        Attachments

          Activity

          Hide
          yorammi Yoram Michaeli added a comment -

          the created structure - as a result of the above run - is:
          path #1: /Release/SDK/3.3/3.3.41/tabtale-sdk-osx-3.3.41.zip
          path #2: /Release/SDK/3.3.41 (empty folder)
          while path #1 is what I need, path #2 is wrong and mess up the FTP-folder with many empty and unneeded folder.

          Show
          yorammi Yoram Michaeli added a comment - the created structure - as a result of the above run - is: path #1: /Release/SDK/3.3/3.3.41/tabtale-sdk-osx-3.3.41.zip path #2: /Release/SDK/3.3.41 (empty folder) while path #1 is what I need, path #2 is wrong and mess up the FTP-folder with many empty and unneeded folder.
          Hide
          bap bap added a comment -

          So, as I suspected your FTP server is not doing what it says it is ...

          MKD 3.3/3.3.41
          257 "/Release/SDK/3.3.41" created.

          ... but it says it is ok.

          I think the only sensible way to deal with this is to add an option to the FTP server configuration in Manage Jenkins to disable any attempts to create multiple directories in one mkdir command.

          I'll take a look at the weekend. Should get a release next week.

          Show
          bap bap added a comment - So, as I suspected your FTP server is not doing what it says it is ... MKD 3.3/3.3.41 257 "/Release/SDK/3.3.41" created. ... but it says it is ok. I think the only sensible way to deal with this is to add an option to the FTP server configuration in Manage Jenkins to disable any attempts to create multiple directories in one mkdir command. I'll take a look at the weekend. Should get a release next week.
          Hide
          bap bap added a comment -

          I misunderstood you explanation of point 1 above.
          You are correct - it is a result of the same problem with the FTP server you are talking to.

          The fix is a new Advanced option for FTP Servers called "Don't make nested dirs".
          Checking it should fix both of your issues.

          Show
          bap bap added a comment - I misunderstood you explanation of point 1 above. You are correct - it is a result of the same problem with the FTP server you are talking to. The fix is a new Advanced option for FTP Servers called "Don't make nested dirs". Checking it should fix both of your issues.
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: bap2000
          Path:
          src/main/java/jenkins/plugins/publish_over_ftp/BapFtpClient.java
          src/main/java/jenkins/plugins/publish_over_ftp/BapFtpHostConfiguration.java
          src/main/resources/jenkins/plugins/publish_over_ftp/BapFtpHostConfiguration/config.jelly
          src/main/resources/jenkins/plugins/publish_over_ftp/BapFtpHostConfiguration/config.properties
          src/main/resources/jenkins/plugins/publish_over_ftp/BapFtpHostConfiguration/config_no_BV.properties
          src/main/resources/jenkins/plugins/publish_over_ftp/BapFtpHostConfiguration/help-disableMakeNestedDirs.html
          src/test/java/jenkins/plugins/publish_over_ftp/BapFtpClientTest.java
          src/test/java/jenkins/plugins/publish_over_ftp/BapHostConfigurationTest.java
          src/test/java/jenkins/plugins/publish_over_ftp/jenkins/CurrentConfigurationTest.java
          src/test/java/jenkins/plugins/publish_over_ftp/jenkins/IntegrationTest.java
          src/test/java/jenkins/plugins/publish_over_ftp/jenkins/LegacyConfigurationTest.java
          http://jenkins-ci.org/commit/publish-over-ftp-plugin/d34aa3f1d6469609c0d2426b5d72e8aedc09427e
          Log:
          [FIXED JENKINS-16976] Option to disable nested directory creation for broken FTP servers.


          You received this message because you are subscribed to the Google Groups "Jenkins Commits" group.
          To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscribe@googlegroups.com.
          For more options, visit https://groups.google.com/groups/opt_out.

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: bap2000 Path: src/main/java/jenkins/plugins/publish_over_ftp/BapFtpClient.java src/main/java/jenkins/plugins/publish_over_ftp/BapFtpHostConfiguration.java src/main/resources/jenkins/plugins/publish_over_ftp/BapFtpHostConfiguration/config.jelly src/main/resources/jenkins/plugins/publish_over_ftp/BapFtpHostConfiguration/config.properties src/main/resources/jenkins/plugins/publish_over_ftp/BapFtpHostConfiguration/config_no_BV.properties src/main/resources/jenkins/plugins/publish_over_ftp/BapFtpHostConfiguration/help-disableMakeNestedDirs.html src/test/java/jenkins/plugins/publish_over_ftp/BapFtpClientTest.java src/test/java/jenkins/plugins/publish_over_ftp/BapHostConfigurationTest.java src/test/java/jenkins/plugins/publish_over_ftp/jenkins/CurrentConfigurationTest.java src/test/java/jenkins/plugins/publish_over_ftp/jenkins/IntegrationTest.java src/test/java/jenkins/plugins/publish_over_ftp/jenkins/LegacyConfigurationTest.java http://jenkins-ci.org/commit/publish-over-ftp-plugin/d34aa3f1d6469609c0d2426b5d72e8aedc09427e Log: [FIXED JENKINS-16976] Option to disable nested directory creation for broken FTP servers. – You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out .
          Hide
          yorammi Yoram Michaeli added a comment -

          Tested OK with version 1.9.
          Thanks!

          Show
          yorammi Yoram Michaeli added a comment - Tested OK with version 1.9. Thanks!

            People

            Assignee:
            bap bap
            Reporter:
            yorammi Yoram Michaeli
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: