• Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Trivial Trivial
    • analysis-core-plugin
    • Core 1.504
      Warnings 4.23
      Analysis-Core 1.49

      Red Hat Enterprise Linux 6.2 64 bit
      Sun Java 1.6.0_20

      Make dependency from warnings to (bundled) ant plugin optional.

      We don't use Ant or Java in our Jenkins. All other bundled plugins were removed from jenkins.war (purpose: keep '/pluginManager/installed' UI list manageable, save a little disk space)

      (similar to JENKINS-14727 for maven dependency, that is now optional)

          [JENKINS-17047] Make dependency to bundled ant plugin optional

          Ulli Hafner added a comment - - edited

          Original code in HealthAwareRecorder:

              protected boolean isAntBuild(final AbstractBuild<?, ?> build) {
                  if (build.getProject() instanceof Project) {
                      Project<?, ?> project = (Project<?, ?>)build.getProject();
                      for (Builder builder : project.getBuilders()) {
                          if (builder instanceof Ant) {
                              return true;
                          }
                      }
                  }
                  return false;
              }
          
          1. Needs to be wrapped with:
            if (Jenkins.getInstance().getPlugin("ant") != null) {
                        
            }
            
          2. Wrapped code must be moved to a new class with static method isAntBuild
          3. static method isAntBuild should return false if ClassNotFoundException is thrown
          4. ant dependency in pom.xml should be made optional

          Ulli Hafner added a comment - - edited Original code in HealthAwareRecorder: protected boolean isAntBuild( final AbstractBuild<?, ?> build) { if (build.getProject() instanceof Project) { Project<?, ?> project = (Project<?, ?>)build.getProject(); for (Builder builder : project.getBuilders()) { if (builder instanceof Ant) { return true ; } } } return false ; } Needs to be wrapped with: if (Jenkins.getInstance().getPlugin( "ant" ) != null ) { } Wrapped code must be moved to a new class with static method isAntBuild static method isAntBuild should return false if ClassNotFoundException is thrown ant dependency in pom.xml should be made optional

          Code changed in jenkins
          User: Ulli Hafner
          Path:
          pom.xml
          src/main/java/hudson/plugins/analysis/core/AntBuilderCheck.java
          src/main/java/hudson/plugins/analysis/core/HealthAwareRecorder.java
          http://jenkins-ci.org/commit/analysis-core-plugin/f0f8dd454360d3c0bc320d2eb64abf48ee85471a
          Log:
          [FIXED JENKINS-17047] Make dependency to ant plug-in optional.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Ulli Hafner Path: pom.xml src/main/java/hudson/plugins/analysis/core/AntBuilderCheck.java src/main/java/hudson/plugins/analysis/core/HealthAwareRecorder.java http://jenkins-ci.org/commit/analysis-core-plugin/f0f8dd454360d3c0bc320d2eb64abf48ee85471a Log: [FIXED JENKINS-17047] Make dependency to ant plug-in optional.

          Code changed in jenkins
          User: Ulli Hafner
          Path:
          pom.xml
          http://jenkins-ci.org/commit/tasks-plugin/e27c6f4cda69f00abdb5a0720c7f050cf1967122
          Log:
          JENKINS-17047 Removed ant plug-in dependency.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Ulli Hafner Path: pom.xml http://jenkins-ci.org/commit/tasks-plugin/e27c6f4cda69f00abdb5a0720c7f050cf1967122 Log: JENKINS-17047 Removed ant plug-in dependency.

          Code changed in jenkins
          User: Ulli Hafner
          Path:
          pom.xml
          http://jenkins-ci.org/commit/pmd-plugin/af89097bc622017f8b768bc24f5fb4fa19f00299
          Log:
          JENKINS-17047 Removed ant plug-in dependency.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Ulli Hafner Path: pom.xml http://jenkins-ci.org/commit/pmd-plugin/af89097bc622017f8b768bc24f5fb4fa19f00299 Log: JENKINS-17047 Removed ant plug-in dependency.

          Code changed in jenkins
          User: Ulli Hafner
          Path:
          plugin/pom.xml
          http://jenkins-ci.org/commit/findbugs-plugin/58f1c2b838dab9f030a7951118b93c324eafddeb
          Log:
          JENKINS-17047 Removed ant plug-in dependency.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Ulli Hafner Path: plugin/pom.xml http://jenkins-ci.org/commit/findbugs-plugin/58f1c2b838dab9f030a7951118b93c324eafddeb Log: JENKINS-17047 Removed ant plug-in dependency.

          Code changed in jenkins
          User: Ulli Hafner
          Path:
          pom.xml
          http://jenkins-ci.org/commit/dry-plugin/d88fba666108d6e5bd1ee338ba454d630df79e49
          Log:
          JENKINS-17047 Removed ant plug-in dependency.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Ulli Hafner Path: pom.xml http://jenkins-ci.org/commit/dry-plugin/d88fba666108d6e5bd1ee338ba454d630df79e49 Log: JENKINS-17047 Removed ant plug-in dependency.

          Code changed in jenkins
          User: Ulli Hafner
          Path:
          pom.xml
          http://jenkins-ci.org/commit/checkstyle-plugin/d3c7d53eeda2dbee58aeeaebe9336b802e0bf1b3
          Log:
          JENKINS-17047 Removed ant plug-in dependency.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Ulli Hafner Path: pom.xml http://jenkins-ci.org/commit/checkstyle-plugin/d3c7d53eeda2dbee58aeeaebe9336b802e0bf1b3 Log: JENKINS-17047 Removed ant plug-in dependency.

          Code changed in jenkins
          User: Ulli Hafner
          Path:
          pom.xml
          http://jenkins-ci.org/commit/analysis-test-plugin/8556b236caa4fcd2c40cbf0f965f6214c88dcf18
          Log:
          JENKINS-17047 Removed ant plug-in dependency.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Ulli Hafner Path: pom.xml http://jenkins-ci.org/commit/analysis-test-plugin/8556b236caa4fcd2c40cbf0f965f6214c88dcf18 Log: JENKINS-17047 Removed ant plug-in dependency.

          Code changed in jenkins
          User: Ulli Hafner
          Path:
          pom.xml
          http://jenkins-ci.org/commit/analysis-collector-plugin/17be5126d0f0f6235bfebacff19a4013b17ca427
          Log:
          JENKINS-17047 Removed ant plug-in dependency.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Ulli Hafner Path: pom.xml http://jenkins-ci.org/commit/analysis-collector-plugin/17be5126d0f0f6235bfebacff19a4013b17ca427 Log: JENKINS-17047 Removed ant plug-in dependency.

          Ulli Hafner added a comment -

          Integrated in Jenkins Analysis Plug-ins (Compile) #609
          [FIXED JENKINS-17047] Make dependency to ant plug-in optional. (Revision f0f8dd454360d3c0bc320d2eb64abf48ee85471a)

          Result = SUCCESS

          Ulli Hafner added a comment - Integrated in Jenkins Analysis Plug-ins (Compile) #609 [FIXED JENKINS-17047] Make dependency to ant plug-in optional. (Revision f0f8dd454360d3c0bc320d2eb64abf48ee85471a) Result = SUCCESS

            drulli Ulli Hafner
            bgolding Ben Golding
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: