Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-17073

Support specifying logger for phing

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Resolved (View Workflow)
    • Priority: Minor
    • Resolution: Fixed
    • Component/s: phing-plugin
    • Labels:
      None
    • Similar Issues:

      Description

      Right now in Phing plugin for Jenkins DefaultLogger is hardcoded. This logger doesn't support Ansi Colors.

      I'm proposing one of 2 things (which one can be implemented):

      1. allow to specify phing logger parameter in project configuration
      2. automatically set logger to AnsiLogger in case, when "AnsiColor Plugin" is installed and ANSI colors option is enabled in a project

        Attachments

          Activity

          Ascending order - Click to sort in descending order
          Hide
          Permalink
          sogabe sogabe added a comment -

          See attached files.
          If you use "AnsiColorLogger" or "HtmlColorLogger" instead of DefaultLogger, log is not colorized.
          So it makes no sense to specify logger.

          Show
          sogabe sogabe added a comment - See attached files. If you use "AnsiColorLogger" or "HtmlColorLogger" instead of DefaultLogger, log is not colorized. So it makes no sense to specify logger.
          Hide
          Permalink
          aik099 Alexander Obuhovich added a comment -

          If you install and enable "AnsiColor Plugin" (for Jenkins) it should work, because it will grab all bash escape sequences, that makes colors and convert them to HTML markup.

          Show
          aik099 Alexander Obuhovich added a comment - If you install and enable "AnsiColor Plugin" (for Jenkins) it should work, because it will grab all bash escape sequences, that makes colors and convert them to HTML markup.
          Hide
          Permalink
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Seiji Sogabe
          Path:
          src/main/java/hudson/plugins/phing/PhingBuilder.java
          src/main/resources/hudson/plugins/phing/PhingBuilder/config.jelly
          src/main/resources/hudson/plugins/phing/PhingBuilder/config_ja.properties
          src/test/java/hudson/plugins/phing/PhingBuilderConfigSubmitTest.java
          http://jenkins-ci.org/commit/phing-plugin/0c5382aedae969c9bca903d15b4becd0a7ccfcdf
          Log:
          [FIXED JENKINS-17073] added Options field to specify logger

          Compare: https://github.com/jenkinsci/phing-plugin/compare/ffdc5f67a923...0c5382aedae9

          –
          You received this message because you are subscribed to the Google Groups "Jenkins Commits" group.
          To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscribe@googlegroups.com.
          For more options, visit https://groups.google.com/groups/opt_out.

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Seiji Sogabe Path: src/main/java/hudson/plugins/phing/PhingBuilder.java src/main/resources/hudson/plugins/phing/PhingBuilder/config.jelly src/main/resources/hudson/plugins/phing/PhingBuilder/config_ja.properties src/test/java/hudson/plugins/phing/PhingBuilderConfigSubmitTest.java http://jenkins-ci.org/commit/phing-plugin/0c5382aedae969c9bca903d15b4becd0a7ccfcdf Log: [FIXED JENKINS-17073] added Options field to specify logger Compare: https://github.com/jenkinsci/phing-plugin/compare/ffdc5f67a923...0c5382aedae9 – You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out .
          Hide
          Permalink
          aik099 Alexander Obuhovich added a comment -

          What is the approximate date of 0.12 version release (I think this fix will go into that version)?

          Show
          aik099 Alexander Obuhovich added a comment - What is the approximate date of 0.12 version release (I think this fix will go into that version)?
          Hide
          Permalink
          sogabe sogabe added a comment -

          I've just released Phing Plugin 0.12.

          Show
          sogabe sogabe added a comment - I've just released Phing Plugin 0.12.
          Hide
          Permalink
          aik099 Alexander Obuhovich added a comment -

          This version doesn't show up on "/pluginManager/?" page (Updates tab). I have "Jenkins ver. 1.504" installed.

          Show
          aik099 Alexander Obuhovich added a comment - This version doesn't show up on "/pluginManager/?" page (Updates tab). I have "Jenkins ver. 1.504" installed.
          Hide
          Permalink
          aik099 Alexander Obuhovich added a comment -

          It seemed, that Jenkins haven't picked up that version. I've clicked "Update Now" link "Advanced" tab to force it looking for new plugin versions.

          Show
          aik099 Alexander Obuhovich added a comment - It seemed, that Jenkins haven't picked up that version. I've clicked "Update Now" link "Advanced" tab to force it looking for new plugin versions.

            People

            Assignee:
            sogabe sogabe
            Reporter:
            aik099 Alexander Obuhovich
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: