Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-17084

ChangeLog should produce output even if some annotator fails

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Component/s: core
    • Labels:
      None
    • Similar Issues:

      Description

      If some ChangeLogAnnotator fails (usually by throwing exception or error), there's no changelog message at all (see attached screenshot). If possible, Jenkins core should be resistant to third party failures (plugin or underlaying servlet container) and produce some reasonable output even in such cases.

        Attachments

          Activity

          Show
          vjuranek vjuranek added a comment - partially fixed in https://github.com/jenkinsci/jenkins/commit/d85dc98e8051066a967f2c77aaa6e06c4be9262d
          Hide
          vjuranek vjuranek added a comment -
          Show
          vjuranek vjuranek added a comment - proposed fix: https://github.com/jenkinsci/jenkins/pull/729
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Vojtech Juranek
          Path:
          core/src/main/java/hudson/scm/ChangeLogSet.java
          test/src/test/java/hudson/scm/ChangeLogSetTest.java
          http://jenkins-ci.org/commit/jenkins/0c46701287ebfa1719c66dcdbcbba57f36c2ac59
          Log:
          [FIXED JENKINS-17084] Changelog should produce output even if some changelog annotator fails

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Vojtech Juranek Path: core/src/main/java/hudson/scm/ChangeLogSet.java test/src/test/java/hudson/scm/ChangeLogSetTest.java http://jenkins-ci.org/commit/jenkins/0c46701287ebfa1719c66dcdbcbba57f36c2ac59 Log: [FIXED JENKINS-17084] Changelog should produce output even if some changelog annotator fails
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: vjuranek
          Path:
          core/src/main/java/hudson/scm/ChangeLogSet.java
          test/src/test/java/hudson/scm/ChangeLogSetTest.java
          http://jenkins-ci.org/commit/jenkins/4a39c5ab0425e504783e955a79ba676b92798c80
          Log:
          Merge pull request #729 from vjuranek/fix_pull646

          [FIXED JENKINS-17084] Changelog should produce output even if some chang...

          Compare: https://github.com/jenkinsci/jenkins/compare/8ef261ef8d23...4a39c5ab0425


          You received this message because you are subscribed to the Google Groups "Jenkins Commits" group.
          To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscribe@googlegroups.com.
          For more options, visit https://groups.google.com/groups/opt_out.

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: vjuranek Path: core/src/main/java/hudson/scm/ChangeLogSet.java test/src/test/java/hudson/scm/ChangeLogSetTest.java http://jenkins-ci.org/commit/jenkins/4a39c5ab0425e504783e955a79ba676b92798c80 Log: Merge pull request #729 from vjuranek/fix_pull646 [FIXED JENKINS-17084] Changelog should produce output even if some chang... Compare: https://github.com/jenkinsci/jenkins/compare/8ef261ef8d23...4a39c5ab0425 – You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out .
          Hide
          dogfood dogfood added a comment -

          Integrated in jenkins_main_trunk #2397
          [FIXED JENKINS-17084] Changelog should produce output even if some changelog annotator fails (Revision 0c46701287ebfa1719c66dcdbcbba57f36c2ac59)

          Result = SUCCESS
          Vojtech Juranek : 0c46701287ebfa1719c66dcdbcbba57f36c2ac59
          Files :

          • test/src/test/java/hudson/scm/ChangeLogSetTest.java
          • core/src/main/java/hudson/scm/ChangeLogSet.java
          Show
          dogfood dogfood added a comment - Integrated in jenkins_main_trunk #2397 [FIXED JENKINS-17084] Changelog should produce output even if some changelog annotator fails (Revision 0c46701287ebfa1719c66dcdbcbba57f36c2ac59) Result = SUCCESS Vojtech Juranek : 0c46701287ebfa1719c66dcdbcbba57f36c2ac59 Files : test/src/test/java/hudson/scm/ChangeLogSetTest.java core/src/main/java/hudson/scm/ChangeLogSet.java

            People

            Assignee:
            vjuranek vjuranek
            Reporter:
            vjuranek vjuranek
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: