Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-17260

Mercurial Push Notifications: URLs should be compared in canonical form

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: Minor Minor
    • mercurial-plugin
    • None
    • Linux, Jenkis 1.506, Mercurial extension v. 1.44, mercurial 2.2

      The comparison of a job's repository URL and the URL passed to notifyCommit will fail when the 2 URLs differ slightly, even though they point to the same place.

      Example that triggers the problem:

      Repository URL (in job configuration screen): http://mymercurialrepo.com.br/hg/main/myproj/
      hook configuration:
      [hooks]
      commit.jenkins = wget -q -O /dev/null http://myjenkins.com.br/jenkins/mercurial/notifyCommit?url=http://mymercurialrepo.com.br/hg/main/myproj
      incoming.jenkins = wget -q -O /dev/null http://myjenkins.com.br/jenkins/mercurial/notifyCommit?url=http://mymercurialrepo.com.br/hg/main/myproj

      The URL comparison should first transform both URLs to their canonical form (by appending a slash at the end if one is missing, for instance).

      I guess it will also fail if one of the URLs includes an HTTP redirect.

          [JENKINS-17260] Mercurial Push Notifications: URLs should be compared in canonical form

          Dan Jasek added a comment - - edited

          This is a bigger problem. Moved it it's own issue.

          Dan Jasek added a comment - - edited This is a bigger problem. Moved it it's own issue.

          Jesse Glick added a comment -

          Already accepts some minor variations; does not yet accept slash vs. no slash. Would be an easy pull request incl. test. In the meantime please use the same URL in both places.

          Jesse Glick added a comment - Already accepts some minor variations; does not yet accept slash vs. no slash. Would be an easy pull request incl. test. In the meantime please use the same URL in both places.

            jglick Jesse Glick
            elifarley Elifarley
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated: