Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-17309

XML escaping (or lack thereof)

XMLWordPrintable

      For example, the GCC warning:
      dereferencing pointer ‘<anonymous>’ does break strict-aliasing rules

      Is displayed by the plugin as:
      dereferencing pointer ‘’ does break strict-aliasing rules

      I imagine a s/</</g is in order.

          [JENKINS-17309] XML escaping (or lack thereof)

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Ulli Hafner
          Path:
          src/main/java/hudson/plugins/analysis/util/model/AbstractAnnotation.java
          src/test/java/hudson/plugins/analysis/util/model/AbstractAnnotationTest.java
          http://jenkins-ci.org/commit/analysis-core-plugin/32bd28cbee59542e5117bf7c26ac03bd24cab5c7
          Log:
          [FIXED JENKINS-17309] Escape message texts that contain XML symbols.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Ulli Hafner Path: src/main/java/hudson/plugins/analysis/util/model/AbstractAnnotation.java src/test/java/hudson/plugins/analysis/util/model/AbstractAnnotationTest.java http://jenkins-ci.org/commit/analysis-core-plugin/32bd28cbee59542e5117bf7c26ac03bd24cab5c7 Log: [FIXED JENKINS-17309] Escape message texts that contain XML symbols.

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Ulli Hafner
          Path:
          .settings/org.eclipse.core.resources.prefs
          pom.xml
          src/test/java/hudson/plugins/warnings/parser/ParserTester.java
          http://jenkins-ci.org/commit/warnings-plugin/af19cb7029c6d06d4b16c7f824c4052318aebb87
          Log:
          JENKINS-17309 Escape message texts that contain XML symbols.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Ulli Hafner Path: .settings/org.eclipse.core.resources.prefs pom.xml src/test/java/hudson/plugins/warnings/parser/ParserTester.java http://jenkins-ci.org/commit/warnings-plugin/af19cb7029c6d06d4b16c7f824c4052318aebb87 Log: JENKINS-17309 Escape message texts that contain XML symbols.

          Ulli Hafner added a comment -

          Integrated in Jenkins Analysis Plug-ins (Compile) #609
          [FIXED JENKINS-17309] Escape message texts that contain XML symbols. (Revision 32bd28cbee59542e5117bf7c26ac03bd24cab5c7)

          Result = SUCCESS

          Ulli Hafner added a comment - Integrated in Jenkins Analysis Plug-ins (Compile) #609 [FIXED JENKINS-17309] Escape message texts that contain XML symbols. (Revision 32bd28cbee59542e5117bf7c26ac03bd24cab5c7) Result = SUCCESS

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Ulli Hafner
          Path:
          .idea/libraries/Maven__org_jvnet_hudson_plugins_analysis_core_1_66.xml
          analysis-collector
          checkstyle
          compile.sh
          warnings
          http://jenkins-ci.org/commit/analysis-suite-plugin/479368313b7a76b448f13dcf4cc9dce8fcd51a9d
          Log:
          [FIXED JENKINS-25511] JENKINS-17309 Reverted XML escaping of message.

          Revert of fix for JENKINS-17309. Previous solution was too aggressive, it makes sense to escape only messages from parsers that parse non-XML files. XML parsers should not escape entities at all.
          AbstractAnnotation never escapes entities now, only GCC parser escapes and invokes constructor with escaped message.

          Compare: https://github.com/jenkinsci/analysis-suite-plugin/compare/db92e5d8fbfa...479368313b7a

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Ulli Hafner Path: .idea/libraries/Maven__org_jvnet_hudson_plugins_analysis_core_1_66.xml analysis-collector checkstyle compile.sh warnings http://jenkins-ci.org/commit/analysis-suite-plugin/479368313b7a76b448f13dcf4cc9dce8fcd51a9d Log: [FIXED JENKINS-25511] JENKINS-17309 Reverted XML escaping of message. Revert of fix for JENKINS-17309 . Previous solution was too aggressive, it makes sense to escape only messages from parsers that parse non-XML files. XML parsers should not escape entities at all. AbstractAnnotation never escapes entities now, only GCC parser escapes and invokes constructor with escaped message. Compare: https://github.com/jenkinsci/analysis-suite-plugin/compare/db92e5d8fbfa...479368313b7a

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Ulli Hafner
          Path:
          checkstyle.iml
          pom.xml
          src/test/java/hudson/plugins/checkstyle/parser/CheckStyleParserTest.java
          http://jenkins-ci.org/commit/checkstyle-plugin/067654f75120c548ba24ddf20b574e00e1c5056b
          Log:
          [FIXED JENKINS-25511] JENKINS-17309 Reverted XML escaping of message.

          Revert of fix for JENKINS-17309. Previous solution was too aggressive, it makes sense to escape only messages from parsers that parse non-XML files. XML parsers should not escape entities at all.
          AbstractAnnotation never escapes entities now, only GCC parser escapes and invokes constructor with escaped message.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Ulli Hafner Path: checkstyle.iml pom.xml src/test/java/hudson/plugins/checkstyle/parser/CheckStyleParserTest.java http://jenkins-ci.org/commit/checkstyle-plugin/067654f75120c548ba24ddf20b574e00e1c5056b Log: [FIXED JENKINS-25511] JENKINS-17309 Reverted XML escaping of message. Revert of fix for JENKINS-17309 . Previous solution was too aggressive, it makes sense to escape only messages from parsers that parse non-XML files. XML parsers should not escape entities at all. AbstractAnnotation never escapes entities now, only GCC parser escapes and invokes constructor with escaped message.

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Ulli Hafner
          Path:
          src/main/java/hudson/plugins/analysis/util/AbstractPackageDetector.java
          src/main/java/hudson/plugins/analysis/util/EncodingValidator.java
          src/main/java/hudson/plugins/analysis/util/JavaPackageDetector.java
          src/main/java/hudson/plugins/analysis/util/model/AbstractAnnotation.java
          src/test/java/hudson/plugins/analysis/util/model/AbstractAnnotationTest.java
          http://jenkins-ci.org/commit/analysis-core-plugin/e001040655c1b7018019a3179ed346b9f855c438
          Log:
          [FIXED JENKINS-25511] JENKINS-17309 Reverted XML escaping of message.

          Revert of fix for JENKINS-17309. Previous solution was too aggressive, it makes sense to escape only messages from parsers that parse non-XML files. XML parsers should not escape entities at all.
          AbstractAnnotation never escapes entities now, only GCC parser escapes and invokes constructor with escaped message.

          Compare: https://github.com/jenkinsci/analysis-core-plugin/compare/4b695e192cc2...e001040655c1

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Ulli Hafner Path: src/main/java/hudson/plugins/analysis/util/AbstractPackageDetector.java src/main/java/hudson/plugins/analysis/util/EncodingValidator.java src/main/java/hudson/plugins/analysis/util/JavaPackageDetector.java src/main/java/hudson/plugins/analysis/util/model/AbstractAnnotation.java src/test/java/hudson/plugins/analysis/util/model/AbstractAnnotationTest.java http://jenkins-ci.org/commit/analysis-core-plugin/e001040655c1b7018019a3179ed346b9f855c438 Log: [FIXED JENKINS-25511] JENKINS-17309 Reverted XML escaping of message. Revert of fix for JENKINS-17309 . Previous solution was too aggressive, it makes sense to escape only messages from parsers that parse non-XML files. XML parsers should not escape entities at all. AbstractAnnotation never escapes entities now, only GCC parser escapes and invokes constructor with escaped message. Compare: https://github.com/jenkinsci/analysis-core-plugin/compare/4b695e192cc2...e001040655c1

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Ulli Hafner
          Path:
          pom.xml
          src/main/java/hudson/plugins/warnings/parser/AbstractWarningsParser.java
          src/main/java/hudson/plugins/warnings/parser/GccParser.java
          src/test/java/hudson/plugins/warnings/parser/GccParserTest.java
          src/test/java/hudson/plugins/warnings/parser/ParserTester.java
          src/test/resources/hudson/plugins/warnings/parser/issue17309.txt
          warnings.iml
          http://jenkins-ci.org/commit/warnings-plugin/7af227eb669868a09d1fe09e19c8a025118983dc
          Log:
          [FIXED JENKINS-25511] JENKINS-17309 Reverted XML escaping of message.

          Revert of fix for JENKINS-17309. Previous solution was too aggressive, it makes sense to escape only messages from parsers that parse non-XML files. XML parsers should not escape entities at all.
          AbstractAnnotation never escapes entities now, only GCC parser escapes and invokes constructor with escaped message.

          Compare: https://github.com/jenkinsci/warnings-plugin/compare/a811a92cfee0...7af227eb6698

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Ulli Hafner Path: pom.xml src/main/java/hudson/plugins/warnings/parser/AbstractWarningsParser.java src/main/java/hudson/plugins/warnings/parser/GccParser.java src/test/java/hudson/plugins/warnings/parser/GccParserTest.java src/test/java/hudson/plugins/warnings/parser/ParserTester.java src/test/resources/hudson/plugins/warnings/parser/issue17309.txt warnings.iml http://jenkins-ci.org/commit/warnings-plugin/7af227eb669868a09d1fe09e19c8a025118983dc Log: [FIXED JENKINS-25511] JENKINS-17309 Reverted XML escaping of message. Revert of fix for JENKINS-17309 . Previous solution was too aggressive, it makes sense to escape only messages from parsers that parse non-XML files. XML parsers should not escape entities at all. AbstractAnnotation never escapes entities now, only GCC parser escapes and invokes constructor with escaped message. Compare: https://github.com/jenkinsci/warnings-plugin/compare/a811a92cfee0...7af227eb6698

            drulli Ulli Hafner
            jameshowe James Howe
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: