Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-17327

Subprojects of the Parameterized trigger plugin are not shown in jsplumb view

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: Critical Critical
    • depgraph-view-plugin
    • None

      The dependency typ subproject introduced by the parameterized trigger plugin are not shown in the jsplumb view. A job triggered by the parameterized trigger plugin does not have any edge to its trigger job.

      sorry I mark this one a critical, but as we use this plugin without the graphviz integration this a very essential missing piece.

          [JENKINS-17327] Subprojects of the Parameterized trigger plugin are not shown in jsplumb view

          hi wolfs,
          do you see any chance to get this added soon?
          thanks imod

          Dominik Bartholdi added a comment - hi wolfs, do you see any chance to get this added soon? thanks imod

          Stefan Wolf added a comment -

          Right now I have no time to fix it. I could try to do this during the Hackathon in June. How should they show up in the dependency graph?

          Stefan Wolf added a comment - Right now I have no time to fix it. I could try to do this during the Hackathon in June. How should they show up in the dependency graph?

          I would say they should be added as normal nodes, but maybe with a different color and/or the color of the connection should be different (like for copy artifact dependency).

          Dominik Bartholdi added a comment - I would say they should be added as normal nodes, but maybe with a different color and/or the color of the connection should be different (like for copy artifact dependency).

          I would realy love to help out on this, but the current usage 'ParameterizedTriggerSubProjectProvider' of the is not really obvious to me.
          I understand that it provides the correct projects, but how these should be added/passed to the 'JungSugiyama' is not clear to me...

          In addition:
          I see that 'SubProjectProvider' is a 'ExtensionPoint', is the current implementation able to handle 'SubProjectProvider's provided by other plugins? e.g. The MultiJob plugin is a candidate for this.

          Dominik Bartholdi added a comment - I would realy love to help out on this, but the current usage 'ParameterizedTriggerSubProjectProvider' of the is not really obvious to me. I understand that it provides the correct projects, but how these should be added/passed to the 'JungSugiyama' is not clear to me... In addition: I see that 'SubProjectProvider' is a 'ExtensionPoint', is the current implementation able to handle 'SubProjectProvider's provided by other plugins? e.g. The MultiJob plugin is a candidate for this.

          Stefan Wolf added a comment -

          Just change the JS Code, I do not think that any changes to the Layout JungSugiyama is necessary.
          To your addition: Yes, this is exactly the point. I do not know yet since the current interface will work as is, but I am happy to change it to accomodate other plugin usages.

          Stefan Wolf added a comment - Just change the JS Code, I do not think that any changes to the Layout JungSugiyama is necessary. To your addition: Yes, this is exactly the point. I do not know yet since the current interface will work as is, but I am happy to change it to accomodate other plugin usages.

          As I see it, these 'subprojects' are not connected to any other node yet in the json, so there is no edge from/to these.
          I don't quite understand why these subprojects should be handled different then any other job. From my point of view these are "normal" dependencies to jobs, the only difference is, that these are triggered by a different trigger then the default. Other then that its the same.
          I think this is better expressed by a different color of the connector, then actually a different view representation. I think the extension point should allow to define a list of nodes and edges with a certain color or connector definition.
          This would also allow to send all these jobs and edges at once into the Layout (JungSugiyama). Right now it feels like every new kind of dependency would require a change of the JungSugiyama.

          Dominik Bartholdi added a comment - As I see it, these 'subprojects' are not connected to any other node yet in the json, so there is no edge from/to these. I don't quite understand why these subprojects should be handled different then any other job. From my point of view these are "normal" dependencies to jobs, the only difference is, that these are triggered by a different trigger then the default. Other then that its the same. I think this is better expressed by a different color of the connector, then actually a different view representation. I think the extension point should allow to define a list of nodes and edges with a certain color or connector definition. This would also allow to send all these jobs and edges at once into the Layout (JungSugiyama). Right now it feels like every new kind of dependency would require a change of the JungSugiyama.

          Dieter Schüle added a comment - - edited

          Same issue here. Not only in jsplumbview but also in graphviz view. Would be great if subproject could be treated like other related projects (dependedencies --> arrows). We use a lot of subprojects, the plugin does not make sense without visualization of dependencies to them.

          Dieter Schüle added a comment - - edited Same issue here. Not only in jsplumbview but also in graphviz view. Would be great if subproject could be treated like other related projects (dependedencies --> arrows). We use a lot of subprojects, the plugin does not make sense without visualization of dependencies to them.

            wolfs Stefan Wolf
            domi Dominik Bartholdi
            Votes:
            2 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated: