Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-17713

Maven Module links are now broken - missing Job Name

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Critical Critical
    • maven-plugin
    • None

      Links to Maven modules are now generating an incorrect url

      Navigating to the following url: http://server_url/jenkins/job/JOB_NAME/modules

      I am presented with a list of Maven Modules.

      The link for each module is now:
      http://server_url/jenkins/job/maven.group.id$maven.artifact.id/

      it should be:

      http://server_url/jenkins/job/JOB_NAME/maven.group.id$maven.artifact.id/

      Also Note,

      This page used to display Maven Modules named as the Name value in its pom.xml

      It now displays them as
      JOB_NAME » maven.group.id:maven.artifact.id

          [JENKINS-17713] Maven Module links are now broken - missing Job Name

          dogfood added a comment -

          Integrated in jenkins_main_trunk #2559
          JENKINS-17713 Preparing unit and functional test coverage. (Revision a5ac54eac82ce1cbfd7fbeca46ac080bc0847627)

          Result = SUCCESS
          Jesse Glick : a5ac54eac82ce1cbfd7fbeca46ac080bc0847627
          Files :

          • test/src/test/java/hudson/maven/MavenMultiModuleTest.java
          • core/src/test/java/hudson/FunctionsTest.java

          dogfood added a comment - Integrated in jenkins_main_trunk #2559 JENKINS-17713 Preparing unit and functional test coverage. (Revision a5ac54eac82ce1cbfd7fbeca46ac080bc0847627) Result = SUCCESS Jesse Glick : a5ac54eac82ce1cbfd7fbeca46ac080bc0847627 Files : test/src/test/java/hudson/maven/MavenMultiModuleTest.java core/src/test/java/hudson/FunctionsTest.java

          Code changed in jenkins
          User: Kohsuke Kawaguchi
          Path:
          changelog.html
          core/pom.xml
          http://jenkins-ci.org/commit/jenkins/bda95c67a6780ff0e6350f80d6f69cf0f61e737c
          Log:
          [FIXED JENKINS-17713 JENKINS-14362]

          Integrated the new version of Stapler that fixes them.

          Compare: https://github.com/jenkinsci/jenkins/compare/59d4c6a4c25a...bda95c67a678

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Kohsuke Kawaguchi Path: changelog.html core/pom.xml http://jenkins-ci.org/commit/jenkins/bda95c67a6780ff0e6350f80d6f69cf0f61e737c Log: [FIXED JENKINS-17713 JENKINS-14362] Integrated the new version of Stapler that fixes them. Compare: https://github.com/jenkinsci/jenkins/compare/59d4c6a4c25a...bda95c67a678

          Code changed in jenkins
          User: Jesse Glick
          Path:
          test/src/test/java/hudson/maven/MavenMultiModuleTest.java
          http://jenkins-ci.org/commit/jenkins/f8ec4c15c2924bc2fa4141522f6076e3f0c1d376
          Log:
          JENKINS-17713 Not yet fixed.
          Links are now correct, thanks to Ancestor.getRelativePath as called from getRelativeLinkTo being correct.
          But getRelativeNameFrom is not working, so anchor texts are ‘project » module’ rather than simply ‘module’.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: test/src/test/java/hudson/maven/MavenMultiModuleTest.java http://jenkins-ci.org/commit/jenkins/f8ec4c15c2924bc2fa4141522f6076e3f0c1d376 Log: JENKINS-17713 Not yet fixed. Links are now correct, thanks to Ancestor.getRelativePath as called from getRelativeLinkTo being correct. But getRelativeNameFrom is not working, so anchor texts are ‘project » module’ rather than simply ‘module’.

          Jesse Glick added a comment -

          I filed https://github.com/jenkinsci/jenkins/pull/820 with my proposed fix for the display name issue; would appreciate some review, though I cannot get back to it until July so either merge it or leave it.

          Jesse Glick added a comment - I filed https://github.com/jenkinsci/jenkins/pull/820 with my proposed fix for the display name issue; would appreciate some review, though I cannot get back to it until July so either merge it or leave it.

          dogfood added a comment -

          Integrated in jenkins_main_trunk #2631
          JENKINS-17713 Not yet fixed. (Revision f8ec4c15c2924bc2fa4141522f6076e3f0c1d376)

          Result = SUCCESS
          Jesse Glick : f8ec4c15c2924bc2fa4141522f6076e3f0c1d376
          Files :

          • test/src/test/java/hudson/maven/MavenMultiModuleTest.java

          dogfood added a comment - Integrated in jenkins_main_trunk #2631 JENKINS-17713 Not yet fixed. (Revision f8ec4c15c2924bc2fa4141522f6076e3f0c1d376) Result = SUCCESS Jesse Glick : f8ec4c15c2924bc2fa4141522f6076e3f0c1d376 Files : test/src/test/java/hudson/maven/MavenMultiModuleTest.java

          Code changed in jenkins
          User: Jesse Glick
          Path:
          changelog.html
          http://jenkins-ci.org/commit/jenkins/fbba0cc01eeb1c9d7c412a6e7b76c588cd36c332
          Log:
          JENKINS-17713 [FIXED JENKINS-14362] These fixes were (mistakenly?) recorded for 1.518 rather than for trunk.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: changelog.html http://jenkins-ci.org/commit/jenkins/fbba0cc01eeb1c9d7c412a6e7b76c588cd36c332 Log: JENKINS-17713 [FIXED JENKINS-14362] These fixes were (mistakenly?) recorded for 1.518 rather than for trunk.

          dogfood added a comment -

          Integrated in jenkins_main_trunk #2633
          JENKINS-17713 [FIXED JENKINS-14362] These fixes were (mistakenly?) recorded for 1.518 rather than for trunk. (Revision fbba0cc01eeb1c9d7c412a6e7b76c588cd36c332)

          Result = SUCCESS
          Jesse Glick : fbba0cc01eeb1c9d7c412a6e7b76c588cd36c332
          Files :

          • changelog.html

          dogfood added a comment - Integrated in jenkins_main_trunk #2633 JENKINS-17713 [FIXED JENKINS-14362] These fixes were (mistakenly?) recorded for 1.518 rather than for trunk. (Revision fbba0cc01eeb1c9d7c412a6e7b76c588cd36c332) Result = SUCCESS Jesse Glick : fbba0cc01eeb1c9d7c412a6e7b76c588cd36c332 Files : changelog.html

          Code changed in jenkins
          User: Jesse Glick
          Path:
          core/src/main/resources/hudson/model/TreeView/ajaxRows.jelly
          core/src/main/resources/hudson/model/View/main.groovy
          core/src/main/resources/hudson/views/JobColumn/column.jelly
          core/src/main/resources/lib/hudson/projectView.jelly
          maven-plugin/src/main/resources/hudson/maven/MavenModuleSet/modules.jelly
          test/src/test/java/hudson/maven/MavenMultiModuleTest.java
          http://jenkins-ci.org/commit/jenkins/b0c222477b0eaf0bc2c7a4c7eba35be7d2e591a8
          Log:
          [FIXED JENKINS-17713] JobColumn/column.jelly needs to have an itemGroup for display name calculation.
          So passing it in explicitly from both the view main page and from the Maven module set modules page.
          A more automatic solution might be to make getRelativeDisplayNameFrom use Ancestor.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: core/src/main/resources/hudson/model/TreeView/ajaxRows.jelly core/src/main/resources/hudson/model/View/main.groovy core/src/main/resources/hudson/views/JobColumn/column.jelly core/src/main/resources/lib/hudson/projectView.jelly maven-plugin/src/main/resources/hudson/maven/MavenModuleSet/modules.jelly test/src/test/java/hudson/maven/MavenMultiModuleTest.java http://jenkins-ci.org/commit/jenkins/b0c222477b0eaf0bc2c7a4c7eba35be7d2e591a8 Log: [FIXED JENKINS-17713] JobColumn/column.jelly needs to have an itemGroup for display name calculation. So passing it in explicitly from both the view main page and from the Maven module set modules page. A more automatic solution might be to make getRelativeDisplayNameFrom use Ancestor.

          dogfood added a comment -

          Integrated in jenkins_main_trunk #2636
          [FIXED JENKINS-17713] JobColumn/column.jelly needs to have an itemGroup for display name calculation. (Revision b0c222477b0eaf0bc2c7a4c7eba35be7d2e591a8)

          Result = UNSTABLE
          kohsuke : b0c222477b0eaf0bc2c7a4c7eba35be7d2e591a8
          Files :

          • core/src/main/resources/hudson/model/TreeView/ajaxRows.jelly
          • core/src/main/resources/hudson/views/JobColumn/column.jelly
          • core/src/main/resources/hudson/model/View/main.groovy
          • test/src/test/java/hudson/maven/MavenMultiModuleTest.java
          • maven-plugin/src/main/resources/hudson/maven/MavenModuleSet/modules.jelly
          • core/src/main/resources/lib/hudson/projectView.jelly

          dogfood added a comment - Integrated in jenkins_main_trunk #2636 [FIXED JENKINS-17713] JobColumn/column.jelly needs to have an itemGroup for display name calculation. (Revision b0c222477b0eaf0bc2c7a4c7eba35be7d2e591a8) Result = UNSTABLE kohsuke : b0c222477b0eaf0bc2c7a4c7eba35be7d2e591a8 Files : core/src/main/resources/hudson/model/TreeView/ajaxRows.jelly core/src/main/resources/hudson/views/JobColumn/column.jelly core/src/main/resources/hudson/model/View/main.groovy test/src/test/java/hudson/maven/MavenMultiModuleTest.java maven-plugin/src/main/resources/hudson/maven/MavenModuleSet/modules.jelly core/src/main/resources/lib/hudson/projectView.jelly

          Code changed in jenkins
          User: Jesse Glick
          Path:
          src/main/resources/hudson/maven/MavenModuleSet/modules.jelly
          http://jenkins-ci.org/commit/maven-plugin/9709e00b5ec290ca083e5a91c8d34a46b28c0695
          Log:
          [FIXED JENKINS-17713] JobColumn/column.jelly needs to have an itemGroup for display name calculation.
          So passing it in explicitly from both the view main page and from the Maven module set modules page.
          A more automatic solution might be to make getRelativeDisplayNameFrom use Ancestor.
          Originally-Committed-As: b0c222477b0eaf0bc2c7a4c7eba35be7d2e591a8

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: src/main/resources/hudson/maven/MavenModuleSet/modules.jelly http://jenkins-ci.org/commit/maven-plugin/9709e00b5ec290ca083e5a91c8d34a46b28c0695 Log: [FIXED JENKINS-17713] JobColumn/column.jelly needs to have an itemGroup for display name calculation. So passing it in explicitly from both the view main page and from the Maven module set modules page. A more automatic solution might be to make getRelativeDisplayNameFrom use Ancestor. Originally-Committed-As: b0c222477b0eaf0bc2c7a4c7eba35be7d2e591a8

            vlatombe Vincent Latombe
            gcummings Geoff Cummings
            Votes:
            6 Vote for this issue
            Watchers:
            11 Start watching this issue

              Created:
              Updated:
              Resolved: