Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-1816

Problem with "changes" report if build done based on CVS label

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Major Major
    • cvs-plugin
    • None
    • Platform: All, OS: All

      We use CVS for version control.
      "Changes" report doesn't appear to show any changes if builds were performed
      from a label rather than as a "tip/HEAD/Latest" revision build.

      I have a project that is set up in Maven as a CI build for the development team.
      The change report works fine here. For the very same project, I do "official"
      QA builds off a label and the changelog report doesn't show any changes.

        1. 1816.patch
          2 kB
        2. CVSSCM.java.patch
          0.5 kB
        3. hudson-core.zip
          37 kB
        4. issue1816.patch
          1 kB

          [JENKINS-1816] Problem with "changes" report if build done based on CVS label

          liyatikal added a comment -

          still doesn't work with the latest 1.323 for the cvs branch (not tag)

          liyatikal added a comment - still doesn't work with the latest 1.323 for the cvs branch (not tag)

          mcgrey added a comment -

          Applied changes http://fisheye4.cenqua.com/changelog/hudson/?cs=20679 broke
          initial functionality: finding changes in CVS "branches".
          Line
          ===
          task.setBranch(branch);
          ===
          is needed to enforce ChangeLogParser find a "branch".

          mcgrey added a comment - Applied changes http://fisheye4.cenqua.com/changelog/hudson/?cs=20679 broke initial functionality: finding changes in CVS "branches". Line === task.setBranch(branch); === is needed to enforce ChangeLogParser find a "branch".

          mcgrey added a comment -

          Created an attachment (id=899)
          Here is the patch to bring initial functionality back. P.S. And excuse me my misspelled "brock" instead of "broke" =)

          mcgrey added a comment - Created an attachment (id=899) Here is the patch to bring initial functionality back. P.S. And excuse me my misspelled "brock" instead of "broke" =)

          mcgrey added a comment -
              • Issue 2726 has been marked as a duplicate of this issue. ***

          mcgrey added a comment - Issue 2726 has been marked as a duplicate of this issue. ***

          ybubnov added a comment -

          Created an attachment (id=914)
          Proposed patch fix problem with brunches and tags in them.

          ybubnov added a comment - Created an attachment (id=914) Proposed patch fix problem with brunches and tags in them.

          ybubnov added a comment -

          My previous patch broke change log calculation on CVS Branches. Mcgrey's patch
          fixed that but doesn't work with tags on branches.
          I proposed the patch that fix the problem.

          ybubnov added a comment - My previous patch broke change log calculation on CVS Branches. Mcgrey's patch fixed that but doesn't work with tags on branches. I proposed the patch that fix the problem.

          klaus__ added a comment -

          When will this finally go into the official Hudson build?
          I am still waiting for the resolution of #4324, which I opened. It's the same
          issue if I am not mistaken. And I opened it in August.
          I am surprised that not too many people seem to have issues...

          klaus__ added a comment - When will this finally go into the official Hudson build? I am still waiting for the resolution of #4324, which I opened. It's the same issue if I am not mistaken. And I opened it in August. I am surprised that not too many people seem to have issues...

          Code changed in hudson
          User: : kohsuke
          Path:
          trunk/hudson/main/core/src/main/java/hudson/model/UpdateCenter.java
          trunk/hudson/main/core/src/main/java/hudson/org/apache/tools/ant/taskdefs/cvslib/ChangeLogTask.java
          trunk/hudson/main/core/src/main/java/hudson/scm/CVSSCM.java
          trunk/www/changelog.html
          http://fisheye4.cenqua.com/changelog/hudson/?cs=23071
          Log:
          [FIXED JENKINS-1816] in 1.331. Applied a patch from ybubnov, and made him a committer.

          SCM/JIRA link daemon added a comment - Code changed in hudson User: : kohsuke Path: trunk/hudson/main/core/src/main/java/hudson/model/UpdateCenter.java trunk/hudson/main/core/src/main/java/hudson/org/apache/tools/ant/taskdefs/cvslib/ChangeLogTask.java trunk/hudson/main/core/src/main/java/hudson/scm/CVSSCM.java trunk/www/changelog.html http://fisheye4.cenqua.com/changelog/hudson/?cs=23071 Log: [FIXED JENKINS-1816] in 1.331. Applied a patch from ybubnov, and made him a committer.

              • Issue 4324 has been marked as a duplicate of this issue. ***

          Kohsuke Kawaguchi added a comment - Issue 4324 has been marked as a duplicate of this issue. ***

          klaus__ added a comment -

          Just upgraded to Hudson 1.331.. and it works!
          Thanks

          klaus__ added a comment - Just upgraded to Hudson 1.331.. and it works! Thanks

            Unassigned Unassigned
            jferr jferr
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Created:
              Updated:
              Resolved: