Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-18378

Regexp-driven validation of client workspace names

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Major Major
    • p4-plugin
    • None

      It would be great to add possibility of workspace name validation according to naming policy, which should be defined in the global configuration.

      Proposed features:

      • Show error notifications if user enters wrong client workspace name
      • Fail creation of the workspace if client name violates naming policy

          [JENKINS-18378] Regexp-driven validation of client workspace names

          Oleg Nenashev added a comment -

          Yes, #2 has not been implemented.
          BTW, It is quite strange that you don't see error notifications.

          I'll reopen issue and check it.

          Oleg Nenashev added a comment - Yes, #2 has not been implemented. BTW, It is quite strange that you don't see error notifications. I'll reopen issue and check it.

          Oleg Nenashev added a comment -

          Reopened issue according to Lata's comments

          Oleg Nenashev added a comment - Reopened issue according to Lata's comments

          lata kopalle added a comment -

          sorry, i edited my comment, i am able to see the error on a bad workspace name. i just wanted to know about the #2. thanks!

          lata kopalle added a comment - sorry, i edited my comment, i am able to see the error on a bad workspace name. i just wanted to know about the #2. thanks!

          lata kopalle added a comment -

          we can close this if #2 is planned for another time place. thanks again.

          lata kopalle added a comment - we can close this if #2 is planned for another time place. thanks again.

          Oleg Nenashev added a comment -

          I'll create additional issue for #2

          Oleg Nenashev added a comment - I'll create additional issue for #2

          Oleg Nenashev added a comment -

          #1 - Fixed
          #2 - https://issues.jenkins-ci.org/browse/JENKINS-19864

          Oleg Nenashev added a comment - #1 - Fixed #2 - https://issues.jenkins-ci.org/browse/JENKINS-19864

          Oleg Nenashev added a comment -

          Done in 1.3.25

          Oleg Nenashev added a comment - Done in 1.3.25

          lata kopalle added a comment -

          thanks a ton.

          lata kopalle added a comment - thanks a ton.

          S Stack added a comment - - edited

          Jenkins 1.534 / Perforce plugin 1.3.27

          • In Manage Jenkins / Configure System, I've specified P4 Client name pattern as ^cits-.*
          • In a new job, I'm able to configure Workspace as xyz-test-job. The GUI warns me Client name doesn't meet global pattern: ^cits-.* but the job is saved nonetheless.
          • I'm able to run the job which creates the client xyz-test-job which breaks my naming pattern.

          JENKINS-19864

          My apologies, there is already an opened task.

          S Stack added a comment - - edited Jenkins 1.534 / Perforce plugin 1.3.27 In Manage Jenkins / Configure System , I've specified P4 Client name pattern as ^cits-.* In a new job, I'm able to configure Workspace as xyz-test-job . The GUI warns me Client name doesn't meet global pattern: ^cits-.* but the job is saved nonetheless. I'm able to run the job which creates the client xyz-test-job which breaks my naming pattern. JENKINS-19864 My apologies, there is already an opened task.

          Oleg Nenashev added a comment -

          @S Stack
          This improvement is fixed. I created JENKINS-18378 for your case

          Oleg Nenashev added a comment - @S Stack This improvement is fixed. I created JENKINS-18378 for your case

            oleg_nenashev Oleg Nenashev
            oleg_nenashev Oleg Nenashev
            Votes:
            1 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: