Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-18386

more flexible job filter by parameter


      parameter filter can only filter by StringParameterValue, BooleanParameterValue and FileParameterValue. So we can't filter by custom parameters.

      I can't understand why can't we change ParameterFilter class getStringValue function to something like this:

      protected String getStringValue(ParameterValue value) {
      		if (value instanceof StringParameterValue) {
      			return ((StringParameterValue) value).value;
      		} else if (value instanceof BooleanParameterValue) {
      			boolean bval = ((BooleanParameterValue) value).value;
      			return String.valueOf(bval);
      		} else if (value instanceof FileParameterValue) {
      			// not the full path - just the name
      			// this is the only public value available to us
      			String file = ((FileParameterValue) value).getOriginalFileName();
      			return file;
      		} else {
      			return value.toString();

      mine difference is return value.toString(); not return null;

            jacob_robertson Jacob Robertson
            mzulis Maris Zulis
            0 Vote for this issue
            3 Start watching this issue