Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-18455

all modules of all maven projects are listed separately

      From 1.36 to 1.37 something changed so we now see all modules of all our maven projects as separately configurable in configuration slicing.
      Due to the number of projects and the huge number of modules within each of them, configuration slicing lost much of its usability.

      Maybe the noted change "add support for folders" brought this change.

      Would be nice to have a global config switch to set configuration slicing to default to the old behaviour no longer showing every single maven module in config slicing lists when not explicitely chosen to do so.

      Reverting to 1.36 from 1.37 brought back the old behaviour for us so we can see again our projects without every single maven module listed besides them.

          [JENKINS-18455] all modules of all maven projects are listed separately

          Daniel Beck added a comment -

          Why is this labeled lts-candidate? It's not a core issue.

          FWIW it's probably a bug and should be resolved without adding an option.

          Daniel Beck added a comment - Why is this labeled lts-candidate? It's not a core issue. FWIW it's probably a bug and should be resolved without adding an option.

          I've looked at this, and it looks pretty clear that the code changes made by Nicolas De Loof from CloudBees causes this. The plugin wasn't designed to handle "getAllItems", and that code change was made without enough testing. I have assigned the ticket to him.

          Jacob Robertson added a comment - I've looked at this, and it looks pretty clear that the code changes made by Nicolas De Loof from CloudBees causes this. The plugin wasn't designed to handle "getAllItems", and that code change was made without enough testing. I have assigned the ticket to him.

          Code changed in jenkins
          User: Nicolas De Loof
          Path:
          src/main/java/configurationslicing/maven/MavenVersionSlicer.java
          http://jenkins-ci.org/commit/configurationslicing-plugin/eefdd378edd33db54ec7e2abcddbc63ca7428fec
          Log:
          [FIXED JENKINS-18455] only expose topLevelItem
          use of getAllItems to support folders introduces as a side effect inclusion of nested maven modules / matrix axes as configurable items

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Nicolas De Loof Path: src/main/java/configurationslicing/maven/MavenVersionSlicer.java http://jenkins-ci.org/commit/configurationslicing-plugin/eefdd378edd33db54ec7e2abcddbc63ca7428fec Log: [FIXED JENKINS-18455] only expose topLevelItem use of getAllItems to support folders introduces as a side effect inclusion of nested maven modules / matrix axes as configurable items

          Tim-Christian Bloss added a comment - - edited

          Hi,

          the problem seems to persist when using slicing to set JDK per maven project.

          When reconfiguring projects for new JDK versions, I see al modules of all projects listed.

          Environment:
          Debian 7.6 amd64
          Oracle JRE7 1.7.0_60
          Tomcat 7.0.54
          Jenkins 1.554.3
          Locale/Charset: de_DE.UTF-8

          EDIT 20140829@1310 :
          Configuration Sclicing Plugin 1.38.3

          Tim-Christian Bloss added a comment - - edited Hi, the problem seems to persist when using slicing to set JDK per maven project. When reconfiguring projects for new JDK versions, I see al modules of all projects listed. Environment: Debian 7.6 amd64 Oracle JRE7 1.7.0_60 Tomcat 7.0.54 Jenkins 1.554.3 Locale/Charset: de_DE.UTF-8 EDIT 20140829@1310 : Configuration Sclicing Plugin 1.38.3

          Eric Düll added a comment - - edited

          My jenkins is running as follows: Jenkins 1.565.3, Configuration Slicing Plugin 1.38.3, Java jdk1.7.0_71, Starting the war with java -jar jenkins.war

          The plugin lists all modules for the following tasks

          • SCM Timer Trigger Slicer
          • JDK per project
          • Block Build when Downstream Building Slicer (bool)
          • Block Build when Upstream Building Slicer (bool)
          • Discard Old Builds Slicer - Days to keep artifacts
          • Discard Old Builds Slicer - Days to keep builds
          • Discard Old Builds Slicer - Max # of builds to keep
          • Discard Old Builds Slicer - Max # of builds to keep with artifacts
          • E-mail Notification
          • Editable Email Notification
          • Job Disabled Build Slicer (bool)
          • Job Disabled Build Slicer (String)
          • Tied Label Slicer
          • Timer Trigger Slicer

          It does not add modules for the following tasks

          • Ant version per project
          • Custom Workspace Slicer
          • Execute shell slicer
          • Execute Windows batch command slicer
          • Maven Goals and Options (Maven project)
          • Maven top-level targets
          • Maven Version
          • MAVEN_OPTS per Maven project
          • Parameters
          • Quiet Period Slicer

          Eric Düll added a comment - - edited My jenkins is running as follows: Jenkins 1.565.3, Configuration Slicing Plugin 1.38.3, Java jdk1.7.0_71, Starting the war with java -jar jenkins.war The plugin lists all modules for the following tasks SCM Timer Trigger Slicer JDK per project Block Build when Downstream Building Slicer (bool) Block Build when Upstream Building Slicer (bool) Discard Old Builds Slicer - Days to keep artifacts Discard Old Builds Slicer - Days to keep builds Discard Old Builds Slicer - Max # of builds to keep Discard Old Builds Slicer - Max # of builds to keep with artifacts E-mail Notification Editable Email Notification Job Disabled Build Slicer (bool) Job Disabled Build Slicer (String) Tied Label Slicer Timer Trigger Slicer It does not add modules for the following tasks Ant version per project Custom Workspace Slicer Execute shell slicer Execute Windows batch command slicer Maven Goals and Options (Maven project) Maven top-level targets Maven Version MAVEN_OPTS per Maven project Parameters Quiet Period Slicer

          Daniel Beck added a comment -

          Daniel Beck added a comment - Fairly obvious left overs from https://github.com/jenkinsci/configurationslicing-plugin/commit/cfcd3d0f6aec34035e773d656d1991aa45a8061c – The fix in https://github.com/jenkinsci/configurationslicing-plugin/commit/eefdd378edd33db54ec7e2abcddbc63ca7428fec only took care of Maven Version.

          Ninian added a comment -

          Ninian added a comment - I've added a pull request to fix this: https://github.com/jenkinsci/configurationslicing-plugin/pull/11

          Code changed in jenkins
          User: ninian
          Path:
          src/main/java/configurationslicing/TopLevelItemSelector.java
          src/main/java/configurationslicing/blockbuild/BlockBuildWhenDownstreamBuildingBoolSlicer.java
          src/main/java/configurationslicing/blockbuild/BlockBuildWhenUpstreamBuildingBoolSlicer.java
          src/main/java/configurationslicing/buildtimeout/BuildTimeoutSlicer.java
          src/main/java/configurationslicing/buildtimeout/BuildTimeoutSlicer2.java
          src/main/java/configurationslicing/claim/ClaimSlicer.java
          src/main/java/configurationslicing/email/AbstractEmailSliceSpec.java
          src/main/java/configurationslicing/jdk/JdkSlicer.java
          src/main/java/configurationslicing/jobdisabled/JobDisabledBoolSlicer.java
          src/main/java/configurationslicing/jobdisabled/JobDisabledStringSlicer.java
          src/main/java/configurationslicing/label/LabelSlicer.java
          src/main/java/configurationslicing/logfilesizechecker/LogfilesizecheckerSlicer.java
          src/main/java/configurationslicing/logrotator/LogRotationSlicer.java
          src/main/java/configurationslicing/prioritysorter/PrioritySorterSlicer.java
          src/main/java/configurationslicing/timer/AbstractTimerSliceSpec.java
          src/main/java/configurationslicing/timestamper/TimestamperSlicer.java
          src/main/java/configurationslicing/tools/AbstractToolSlicerSpec.java
          http://jenkins-ci.org/commit/configurationslicing-plugin/c9a8c001a20fcd57d9f86adcd121bbb3801cdbdc
          Log:
          JENKINS-18455: Exclude items other than top level projects from slicing

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: ninian Path: src/main/java/configurationslicing/TopLevelItemSelector.java src/main/java/configurationslicing/blockbuild/BlockBuildWhenDownstreamBuildingBoolSlicer.java src/main/java/configurationslicing/blockbuild/BlockBuildWhenUpstreamBuildingBoolSlicer.java src/main/java/configurationslicing/buildtimeout/BuildTimeoutSlicer.java src/main/java/configurationslicing/buildtimeout/BuildTimeoutSlicer2.java src/main/java/configurationslicing/claim/ClaimSlicer.java src/main/java/configurationslicing/email/AbstractEmailSliceSpec.java src/main/java/configurationslicing/jdk/JdkSlicer.java src/main/java/configurationslicing/jobdisabled/JobDisabledBoolSlicer.java src/main/java/configurationslicing/jobdisabled/JobDisabledStringSlicer.java src/main/java/configurationslicing/label/LabelSlicer.java src/main/java/configurationslicing/logfilesizechecker/LogfilesizecheckerSlicer.java src/main/java/configurationslicing/logrotator/LogRotationSlicer.java src/main/java/configurationslicing/prioritysorter/PrioritySorterSlicer.java src/main/java/configurationslicing/timer/AbstractTimerSliceSpec.java src/main/java/configurationslicing/timestamper/TimestamperSlicer.java src/main/java/configurationslicing/tools/AbstractToolSlicerSpec.java http://jenkins-ci.org/commit/configurationslicing-plugin/c9a8c001a20fcd57d9f86adcd121bbb3801cdbdc Log: JENKINS-18455 : Exclude items other than top level projects from slicing

          Code changed in jenkins
          User: ninian
          Path:
          src/main/java/configurationslicing/TopLevelItemSelector.java
          src/main/java/configurationslicing/blockbuild/BlockBuildWhenDownstreamBuildingBoolSlicer.java
          src/main/java/configurationslicing/blockbuild/BlockBuildWhenUpstreamBuildingBoolSlicer.java
          src/main/java/configurationslicing/buildtimeout/BuildTimeoutSlicer.java
          src/main/java/configurationslicing/buildtimeout/BuildTimeoutSlicer2.java
          src/main/java/configurationslicing/claim/ClaimSlicer.java
          src/main/java/configurationslicing/email/AbstractEmailSliceSpec.java
          src/main/java/configurationslicing/jdk/JdkSlicer.java
          src/main/java/configurationslicing/jobdisabled/JobDisabledBoolSlicer.java
          src/main/java/configurationslicing/jobdisabled/JobDisabledStringSlicer.java
          src/main/java/configurationslicing/label/LabelSlicer.java
          src/main/java/configurationslicing/logfilesizechecker/LogfilesizecheckerSlicer.java
          src/main/java/configurationslicing/logrotator/LogRotationSlicer.java
          src/main/java/configurationslicing/prioritysorter/PrioritySorterSlicer.java
          src/main/java/configurationslicing/timer/AbstractTimerSliceSpec.java
          src/main/java/configurationslicing/timestamper/TimestamperSlicer.java
          src/main/java/configurationslicing/tools/AbstractToolSlicerSpec.java
          http://jenkins-ci.org/commit/configurationslicing-plugin/f78127ed04eebe1af465af0fd71831269526b4a5
          Log:
          Merge pull request #11 from ninian/master

          FIXED JENKINS-18455 - remove extra maven modules from all slicing
          FIXED JENKINS-20082
          FIXED JENKINS-21556
          FIXED JENKINS-23766

          Compare: https://github.com/jenkinsci/configurationslicing-plugin/compare/9434d1dfe7e8...f78127ed04ee

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: ninian Path: src/main/java/configurationslicing/TopLevelItemSelector.java src/main/java/configurationslicing/blockbuild/BlockBuildWhenDownstreamBuildingBoolSlicer.java src/main/java/configurationslicing/blockbuild/BlockBuildWhenUpstreamBuildingBoolSlicer.java src/main/java/configurationslicing/buildtimeout/BuildTimeoutSlicer.java src/main/java/configurationslicing/buildtimeout/BuildTimeoutSlicer2.java src/main/java/configurationslicing/claim/ClaimSlicer.java src/main/java/configurationslicing/email/AbstractEmailSliceSpec.java src/main/java/configurationslicing/jdk/JdkSlicer.java src/main/java/configurationslicing/jobdisabled/JobDisabledBoolSlicer.java src/main/java/configurationslicing/jobdisabled/JobDisabledStringSlicer.java src/main/java/configurationslicing/label/LabelSlicer.java src/main/java/configurationslicing/logfilesizechecker/LogfilesizecheckerSlicer.java src/main/java/configurationslicing/logrotator/LogRotationSlicer.java src/main/java/configurationslicing/prioritysorter/PrioritySorterSlicer.java src/main/java/configurationslicing/timer/AbstractTimerSliceSpec.java src/main/java/configurationslicing/timestamper/TimestamperSlicer.java src/main/java/configurationslicing/tools/AbstractToolSlicerSpec.java http://jenkins-ci.org/commit/configurationslicing-plugin/f78127ed04eebe1af465af0fd71831269526b4a5 Log: Merge pull request #11 from ninian/master FIXED JENKINS-18455 - remove extra maven modules from all slicing FIXED JENKINS-20082 FIXED JENKINS-21556 FIXED JENKINS-23766 Compare: https://github.com/jenkinsci/configurationslicing-plugin/compare/9434d1dfe7e8...f78127ed04ee

          Ninian added a comment -

          Should be fixed in version 1.40 of the plugin.

          Ninian added a comment - Should be fixed in version 1.40 of the plugin.

            ninian Ninian
            tcb T.-C. B.
            Votes:
            2 Vote for this issue
            Watchers:
            7 Start watching this issue

              Created:
              Updated:
              Resolved: