Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-18534

Jobs from same project are combined when different branches selected for each job

      Different values selected for 'List Subversion Tags' parameters are not considered in determining parameter equality.

      ListSubversionTagsParameterValue needs to implement hashCode() and equals() properly.

          [JENKINS-18534] Jobs from same project are combined when different branches selected for each job

          Daniel Beck added a comment -

          Wow, this is stupid. ListSubversionTagsParameterValue does not override equals() and hashCode(), resulting in the default implementation being used that only compares the parameter name and type.

          Daniel Beck added a comment - Wow, this is stupid. ListSubversionTagsParameterValue does not override equals() and hashCode(), resulting in the default implementation being used that only compares the parameter name and type.

          Shannon Kerr added a comment -

          Random string parameter plugin did not fix the issue for me. I did try that previously.

          Thanks for taking my poor layman's explanation and isolating it more meaningfully.

          Shannon Kerr added a comment - Random string parameter plugin did not fix the issue for me. I did try that previously. Thanks for taking my poor layman's explanation and isolating it more meaningfully.

          Shannon Kerr added a comment -

          Any idea when this might be fixed Daniel?

          Shannon Kerr added a comment - Any idea when this might be fixed Daniel?

          Shannon Kerr added a comment -

          As I pointed out, random string parameter did not work either. Someone may want to look into that too.

          Shannon Kerr added a comment - As I pointed out, random string parameter did not work either. Someone may want to look into that too.

          Daniel Beck added a comment - - edited

          Any idea when this might be fixed Daniel?

          Whenever someone merges my PR (linked above) and cuts a release. It's been a year since one of the usual maintainers actually worked on the plugin (except releases and merging pull requests): Everything else was pull requests + the Cloudbees guys, so I don't expect it to happen anytime soon. If you know the basics of Git and Maven, my suggestion is to create a Subversion plugin build based on 2.3 (2.4 is too broken IMO) with this change.

          Daniel Beck added a comment - - edited Any idea when this might be fixed Daniel? Whenever someone merges my PR (linked above) and cuts a release. It's been a year since one of the usual maintainers actually worked on the plugin (except releases and merging pull requests): Everything else was pull requests + the Cloudbees guys, so I don't expect it to happen anytime soon. If you know the basics of Git and Maven, my suggestion is to create a Subversion plugin build based on 2.3 (2.4 is too broken IMO) with this change.

          Code changed in jenkins
          User: Daniel Beck
          Path:
          src/main/java/hudson/scm/listtagsparameter/ListSubversionTagsParameterValue.java
          http://jenkins-ci.org/commit/subversion-plugin/2dec2d0978ea2e309fe962be786a6c4ec92417b8
          Log:
          [FIXED JENKINS-18534] equals()/hashCode() for parameter value

          The default implementation considers parameters with the same name
          to be identical, resulting in queue items being collapsed.

          With this change, different values for a parameter will result in
          different builds.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Daniel Beck Path: src/main/java/hudson/scm/listtagsparameter/ListSubversionTagsParameterValue.java http://jenkins-ci.org/commit/subversion-plugin/2dec2d0978ea2e309fe962be786a6c4ec92417b8 Log: [FIXED JENKINS-18534] equals()/hashCode() for parameter value The default implementation considers parameters with the same name to be identical, resulting in queue items being collapsed. With this change, different values for a parameter will result in different builds.

          Code changed in jenkins
          User: Daniel Beck
          Path:
          src/test/java/hudson/scm/listtagsparameter/ListSubversionTagsParameterValueTest.java
          http://jenkins-ci.org/commit/subversion-plugin/8a96c32606fe8f49d10155a50883862edb931baa
          Log:
          JENKINS-18534 Added test contributed by @christ66

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Daniel Beck Path: src/test/java/hudson/scm/listtagsparameter/ListSubversionTagsParameterValueTest.java http://jenkins-ci.org/commit/subversion-plugin/8a96c32606fe8f49d10155a50883862edb931baa Log: JENKINS-18534 Added test contributed by @christ66

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          src/main/java/hudson/scm/listtagsparameter/ListSubversionTagsParameterValue.java
          src/test/java/hudson/scm/listtagsparameter/ListSubversionTagsParameterValueTest.java
          http://jenkins-ci.org/commit/subversion-plugin/7fecc427c206d866b13d02568bbc57eec9b95126
          Log:
          Merge pull request #87 from daniel-beck/JENKINS-18534

          [FIXED JENKINS-18534] equals()/hashCode() for parameter value

          Compare: https://github.com/jenkinsci/subversion-plugin/compare/2a16745d63a1...7fecc427c206

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: src/main/java/hudson/scm/listtagsparameter/ListSubversionTagsParameterValue.java src/test/java/hudson/scm/listtagsparameter/ListSubversionTagsParameterValueTest.java http://jenkins-ci.org/commit/subversion-plugin/7fecc427c206d866b13d02568bbc57eec9b95126 Log: Merge pull request #87 from daniel-beck/ JENKINS-18534 [FIXED JENKINS-18534] equals()/hashCode() for parameter value Compare: https://github.com/jenkinsci/subversion-plugin/compare/2a16745d63a1...7fecc427c206

          Code changed in jenkins
          User: Daniel Beck
          Path:
          src/main/java/hudson/scm/listtagsparameter/ListSubversionTagsParameterValue.java
          http://jenkins-ci.org/commit/subversion-plugin/82932212bcfd9a2051e91ac2cb2ae2531b5264d9
          Log:
          [FIXED JENKINS-18534] equals()/hashCode() for parameter value

          The default implementation considers parameters with the same name
          to be identical, resulting in queue items being collapsed.

          With this change, different values for a parameter will result in
          different builds.

          (cherry picked from commit 2dec2d0978ea2e309fe962be786a6c4ec92417b8)

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Daniel Beck Path: src/main/java/hudson/scm/listtagsparameter/ListSubversionTagsParameterValue.java http://jenkins-ci.org/commit/subversion-plugin/82932212bcfd9a2051e91ac2cb2ae2531b5264d9 Log: [FIXED JENKINS-18534] equals()/hashCode() for parameter value The default implementation considers parameters with the same name to be identical, resulting in queue items being collapsed. With this change, different values for a parameter will result in different builds. (cherry picked from commit 2dec2d0978ea2e309fe962be786a6c4ec92417b8)

          Code changed in jenkins
          User: Daniel Beck
          Path:
          src/test/java/hudson/scm/listtagsparameter/ListSubversionTagsParameterValueTest.java
          http://jenkins-ci.org/commit/subversion-plugin/0dc322ba5f8a87131588f6174719fe6cb5d73cdc
          Log:
          JENKINS-18534 Added test contributed by @christ66

          (cherry picked from commit 8a96c32606fe8f49d10155a50883862edb931baa)

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Daniel Beck Path: src/test/java/hudson/scm/listtagsparameter/ListSubversionTagsParameterValueTest.java http://jenkins-ci.org/commit/subversion-plugin/0dc322ba5f8a87131588f6174719fe6cb5d73cdc Log: JENKINS-18534 Added test contributed by @christ66 (cherry picked from commit 8a96c32606fe8f49d10155a50883862edb931baa)

            danielbeck Daniel Beck
            kerrhome Shannon Kerr
            Votes:
            3 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:
              Resolved: