Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-18652

Handling of Configuration and Platform parameters

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Component/s: msbuild-plugin
    • Labels:
      None
    • Environment:
      Windows 7 64bit slave, Visual Studio 2012, Jenkins 1.509.2
    • Similar Issues:

      Description

      When using the plugin with out any explicit command options but using the "Pass build variables as properties" option I'm finding the generated command line has broken properties generated.

      I get the following
      Path To MSBuild.exe: C:\Windows\Microsoft.NET\Framework\v4.0.30319\MSBuild.exe
      Executing the command cmd.exe /C C:\Windows\Microsoft.NET\Framework\v4.0.30319\MSBuild.exe /nologo /p:label=VS2012WDK;Configuration=Win8+Debug;Platform=x64 && exit %%ERRORLEVEL%% from C:\jenkins\workspace\VCHIq_Interface_Driver_(staging)\Configuration\Win8 Debug\Platform\x64\label\VS2012WDK

      As you can see the /p option has no quotes and has change the space in the Configuration name into a plus.

      version 1.16 work as expected.

        Attachments

          Issue Links

          is related to

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-21585 Pass build variables as properties incorrectly format commandline

          • Blocker - Blocks development and/or testing work, production could not run.
          • Resolved

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            mdkf Michael Fowler added a comment -

            I'm seeing this as well. Spaces are becoming plus signs.

            Show
            mdkf Michael Fowler added a comment - I'm seeing this as well. Spaces are becoming plus signs.
            Hide
            Permalink
            gbois Gregory Boissinot added a comment -

            Does this issue persists with the latest version?

            Show
            gbois Gregory Boissinot added a comment - Does this issue persists with the latest version?
            Hide
            Permalink
            danielbeck Daniel Beck added a comment -

            Gregory Boissinot:

            https://github.com/jenkinsci/msbuild-plugin/blob/master/src/main/java/hudson/plugins/msbuild/MsBuildBuilder.java#L141
            http://docs.oracle.com/javase/6/docs/api/java/net/URLEncoder.html

            The space character " " is converted into a plus sign "+".

            Show
            danielbeck Daniel Beck added a comment - Gregory Boissinot : https://github.com/jenkinsci/msbuild-plugin/blob/master/src/main/java/hudson/plugins/msbuild/MsBuildBuilder.java#L141 http://docs.oracle.com/javase/6/docs/api/java/net/URLEncoder.html The space character " " is converted into a plus sign "+".
            Hide
            Permalink
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Gregory Boissinot
            Path:
            src/main/java/hudson/plugins/msbuild/MsBuildBuilder.java
            http://jenkins-ci.org/commit/msbuild-plugin/2d0e7f3e3ddd6eef5ae2886067ba1258eb811efb
            Log:
            Fix JENKINS-21585 and JENKINS-18652

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Gregory Boissinot Path: src/main/java/hudson/plugins/msbuild/MsBuildBuilder.java http://jenkins-ci.org/commit/msbuild-plugin/2d0e7f3e3ddd6eef5ae2886067ba1258eb811efb Log: Fix JENKINS-21585 and JENKINS-18652

              People

              Assignee:
              kdsweeney kdsweeney
              Reporter:
              drewr Drew Reed
              Votes:
              1 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: