Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-19494

Flexible Publish does not work with Publishers using Descriptor#newInstance

    XMLWordPrintable

Details

    Description

      Following publishers does not work correctly when contained in Flexible Publish plugin.

      • Publishers that do not use DataBoundConstructor annotation for their constructors.
        • E-mail Notification ( hudson.tasks.Mailer at least in Jenkins 1.425)
          • Fails to save the project configuration.
        • These publishers are automatically filtered by current implementation.
      • Publishers that have their own Descriptor#newInstance.
        • Publish JUnit test result report hudson.tasks.junit.JUnitResultArchiver.
          • Fails to store configurations extended with TestDataPublisher. It is stored in Descriptor#newInstance, but not in the constructor.
          • For example, JUnit Attachments Plugin
        • Cobertura Plugin
          • Fails to store "Coverage Metric Targets", which is stored in Descriptor#newInstance.
        • RunDeck Plugin
          • Fails to store "Job ID", which is stored in Descriptor#newInstance(Also stored in the constructor, but the field name is mismatched).

      I try to handle Descriptor#newInstance.

      Attachments

        Issue Links

          is blocking

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-14454 Cobertura Publisher does not keep settings when used in flexible-publish

          • Major - Major loss of function.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-14597 Rundeck JobID doesn't persist when used as build publisher

          • Major - Major loss of function.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-19257 JUnit attachments plugin cannot be used inside a 'Flexible publish' step

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Activity

            Ascending order - Click to sort in descending order
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: ikedam
            Path:
            src/main/java/org/jenkins_ci/plugins/flexible_publish/ConditionalPublisher.java
            src/main/java/org/jenkins_ci/plugins/flexible_publish/DefaultPublisherDescriptorLister.java
            src/main/java/org/jenkins_ci/plugins/flexible_publish/FlexiblePublisher.java
            http://jenkins-ci.org/commit/flexible-publish-plugin/afa9d8c7927ad8733a7d0a4da265eda5a7eeaec7
            Log:
            JENKINS-19494 Call Descriptor#newInstance to instantiate enclosing Publishers.

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: ikedam Path: src/main/java/org/jenkins_ci/plugins/flexible_publish/ConditionalPublisher.java src/main/java/org/jenkins_ci/plugins/flexible_publish/DefaultPublisherDescriptorLister.java src/main/java/org/jenkins_ci/plugins/flexible_publish/FlexiblePublisher.java http://jenkins-ci.org/commit/flexible-publish-plugin/afa9d8c7927ad8733a7d0a4da265eda5a7eeaec7 Log: JENKINS-19494 Call Descriptor#newInstance to instantiate enclosing Publishers.
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: ikedam
            Path:
            src/test/java/org/jenkins_ci/plugins/flexible_publish/ConfigurationTest.java
            http://jenkins-ci.org/commit/flexible-publish-plugin/7b78b8824aadc53ee310e8e9cbbcb625f8947124
            Log:
            JENKINS-19494 Added tests for handling newInstance.

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: ikedam Path: src/test/java/org/jenkins_ci/plugins/flexible_publish/ConfigurationTest.java http://jenkins-ci.org/commit/flexible-publish-plugin/7b78b8824aadc53ee310e8e9cbbcb625f8947124 Log: JENKINS-19494 Added tests for handling newInstance.
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: ikedam
            Path:
            src/main/java/org/jenkins_ci/plugins/flexible_publish/ConditionalPublisher.java
            src/main/java/org/jenkins_ci/plugins/flexible_publish/DefaultPublisherDescriptorLister.java
            src/main/java/org/jenkins_ci/plugins/flexible_publish/FlexiblePublisher.java
            src/test/java/org/jenkins_ci/plugins/flexible_publish/ConfigurationTest.java
            http://jenkins-ci.org/commit/flexible-publish-plugin/f60940f04492274b20812fb455055bc56c2d8851
            Log:
            Merge pull request #3 from ikedam/feature/JENKINS-19494_handle_newInstance

            JENKINS-19494 Make flexible publisher to work with publishers with customized Descriptor#newInstance.

            Compare: https://github.com/jenkinsci/flexible-publish-plugin/compare/d9212674b7c6...f60940f04492

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: ikedam Path: src/main/java/org/jenkins_ci/plugins/flexible_publish/ConditionalPublisher.java src/main/java/org/jenkins_ci/plugins/flexible_publish/DefaultPublisherDescriptorLister.java src/main/java/org/jenkins_ci/plugins/flexible_publish/FlexiblePublisher.java src/test/java/org/jenkins_ci/plugins/flexible_publish/ConfigurationTest.java http://jenkins-ci.org/commit/flexible-publish-plugin/f60940f04492274b20812fb455055bc56c2d8851 Log: Merge pull request #3 from ikedam/feature/ JENKINS-19494 _handle_newInstance JENKINS-19494 Make flexible publisher to work with publishers with customized Descriptor#newInstance. Compare: https://github.com/jenkinsci/flexible-publish-plugin/compare/d9212674b7c6...f60940f04492
            ikedam ikedam added a comment -

            Fixed in flexible-publish-0.12

            ikedam ikedam added a comment - Fixed in flexible-publish-0.12

            People

              ikedam ikedam
              ikedam ikedam
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: