Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-19947

Missing base directory in ZIP from .../artifact/dir/subdir/*zip*/subdir.zip

    XMLWordPrintable

Details

    Description

      1.509.x would create a subdir.zip with a root entry subdir/. Development builds omit this top directory.

      Attachments

        Issue Links

          Activity

            eyeamvic Victor Baca added a comment -

            This issue may have caused JENKINS-19752 to become an issue again. I am unable to validate that this issue is resolved due to the now corrupt ZIP file.

            eyeamvic Victor Baca added a comment - This issue may have caused JENKINS-19752 to become an issue again. I am unable to validate that this issue is resolved due to the now corrupt ZIP file.

            Code changed in jenkins
            User: Jesse Glick
            Path:
            core/src/main/java/hudson/FilePath.java
            core/src/main/java/hudson/model/DirectoryBrowserSupport.java
            core/src/main/java/hudson/util/DirScanner.java
            test/src/test/java/hudson/model/DirectoryBrowserSupportTest.java
            http://jenkins-ci.org/commit/jenkins/3695e614ed51c344bcc7deafaee44b11f7d1151d
            Log:
            [FIXED JENKINS-19947] Restore historical undocumented behavior of a top-level entry in a ZIP.
            Noting that various DirScanner implementations handle this inconsistently.

            (cherry picked from commit 793b6826e567e20a256a6d4166031e75a185ef7a)

            Conflicts:
            changelog.html

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: core/src/main/java/hudson/FilePath.java core/src/main/java/hudson/model/DirectoryBrowserSupport.java core/src/main/java/hudson/util/DirScanner.java test/src/test/java/hudson/model/DirectoryBrowserSupportTest.java http://jenkins-ci.org/commit/jenkins/3695e614ed51c344bcc7deafaee44b11f7d1151d Log: [FIXED JENKINS-19947] Restore historical undocumented behavior of a top-level entry in a ZIP. Noting that various DirScanner implementations handle this inconsistently. (cherry picked from commit 793b6826e567e20a256a6d4166031e75a185ef7a) Conflicts: changelog.html
            danielbeck Daniel Beck added a comment -

            Next LTS will be based on 1.554, which contains the original fix, so no backporting required.

            danielbeck Daniel Beck added a comment - Next LTS will be based on 1.554, which contains the original fix, so no backporting required.
            jameshowe James Howe added a comment -

            I don't suppose there's any option if I want the directory to be omitted?

            jameshowe James Howe added a comment - I don't suppose there's any option if I want the directory to be omitted?
            jglick Jesse Glick added a comment -

            jameshowe use ** as an include pattern rather than omitting this parameter or leaving it blank.

            jglick Jesse Glick added a comment - jameshowe use ** as an include pattern rather than omitting this parameter or leaving it blank.

            People

              jglick Jesse Glick
              jglick Jesse Glick
              Votes:
              1 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: