[JENKINS-20123] Save ANY job configuration causes Git Plugin to throw NPE

Type: Bug
Resolution: Fixed
Priority: Critical
Component/s: core, git-plugin
Labels:
None
Environment:
Jenkins 1.537-SNAPSHOT
Git Plugin 1.5.0

Similar Issues:
Powered by SuggestiMate

Show

After ~~JENKINS-18629~~ fixed, Jenkins is getting to throw NPE when project config is submitted.

javax.servlet.ServletException: java.lang.RuntimeException: Failed to instantiate class hudson.plugins.git.GitSCM from {"value":"2","userRemoteConfigs":{"url":"https://github.com/takezoe/gitbucket.git","name":"","refspec":""},"branches":{"name":"master"},"includedRegions":"","excludedRegions":"","excludedUsers":"","localBranch":"","relativeTargetDir":"","reference":"","scmName":"","gitConfigName":"","gitConfigEmail":"","pruneBranches":false,"skipTag":false,"clean":false,"remotePoll":false,"disableSubmodules":false,"recursiveSubmodules":false,"authorOrCommitter":false,"wipeOutWorkspace":false,"ignoreNotifyCommit":false,"useShallowClone":false,"":["hudson.plugins.git.util.DefaultBuildChooser","7"],"buildChooser":{"stapler-class<span class="code-quote">":"hudson.plugins.git.util.DefaultBuildChooser"},"gitTool":"Default","browser":{"stapler-class<span class="code-quote">":"hudson.plugins.git.browser.GithubWeb","url":"https://github.com/takezoe/gitbucket/"}}
	at org.kohsuke.stapler.Stapler.tryInvoke(Stapler.java:777)
	at org.kohsuke.stapler.Stapler.invoke(Stapler.java:841)
	at org.kohsuke.stapler.MetaClass$6.doDispatch(MetaClass.java:248)
	at org.kohsuke.stapler.NameBasedDispatcher.dispatch(NameBasedDispatcher.java:53)
	at org.kohsuke.stapler.Stapler.tryInvoke(Stapler.java:727)
	at org.kohsuke.stapler.Stapler.invoke(Stapler.java:841)
	at org.kohsuke.stapler.MetaClass$6.doDispatch(MetaClass.java:248)
	at org.kohsuke.stapler.NameBasedDispatcher.dispatch(NameBasedDispatcher.java:53)
	at org.kohsuke.stapler.Stapler.tryInvoke(Stapler.java:727)
	at org.kohsuke.stapler.Stapler.invoke(Stapler.java:841)
	at org.kohsuke.stapler.Stapler.invoke(Stapler.java:630)
	at org.kohsuke.stapler.Stapler.service(Stapler.java:224)
	at javax.servlet.http.HttpServlet.service(Unknown Source)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(Unknown Source)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(Unknown Source)
	at hudson.util.PluginServletFilter$1.doFilter(PluginServletFilter.java:96)
	at net.bull.javamelody.MonitoringFilter.doFilter(MonitoringFilter.java:208)
	at net.bull.javamelody.MonitoringFilter.doFilter(MonitoringFilter.java:181)
	at net.bull.javamelody.PluginMonitoringFilter.doFilter(PluginMonitoringFilter.java:86)
	at org.jvnet.hudson.plugins.monitoring.HudsonMonitoringFilter.doFilter(HudsonMonitoringFilter.java:84)
	at hudson.util.PluginServletFilter$1.doFilter(PluginServletFilter.java:99)
	at hudson.util.PluginServletFilter.doFilter(PluginServletFilter.java:88)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(Unknown Source)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(Unknown Source)
	at hudson.security.csrf.CrumbFilter.doFilter(CrumbFilter.java:48)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(Unknown Source)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(Unknown Source)
	at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:84)
	at hudson.security.UnwrapSecurityExceptionFilter.doFilter(UnwrapSecurityExceptionFilter.java:51)
	at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87)
	at jenkins.security.ExceptionTranslationFilter.doFilter(ExceptionTranslationFilter.java:117)
	at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87)
	at org.acegisecurity.providers.anonymous.AnonymousProcessingFilter.doFilter(AnonymousProcessingFilter.java:125)
	at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87)
	at org.acegisecurity.ui.rememberme.RememberMeProcessingFilter.doFilter(RememberMeProcessingFilter.java:142)
	at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87)
	at org.acegisecurity.ui.AbstractProcessingFilter.doFilter(AbstractProcessingFilter.java:271)
	at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87)
	at org.acegisecurity.ui.basicauth.BasicProcessingFilter.doFilter(BasicProcessingFilter.java:174)
	at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87)
	at jenkins.security.ApiTokenFilter.doFilter(ApiTokenFilter.java:64)
	at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87)
	at org.acegisecurity.context.HttpSessionContextIntegrationFilter.doFilter(HttpSessionContextIntegrationFilter.java:249)
	at hudson.security.HttpSessionContextIntegrationFilter2.doFilter(HttpSessionContextIntegrationFilter2.java:67)
	at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87)
	at hudson.security.ChainedServletFilter.doFilter(ChainedServletFilter.java:76)
	at hudson.security.HudsonFilter.doFilter(HudsonFilter.java:164)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(Unknown Source)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(Unknown Source)
	at org.kohsuke.stapler.compression.CompressionFilter.doFilter(CompressionFilter.java:46)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(Unknown Source)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(Unknown Source)
	at hudson.util.CharacterEncodingFilter.doFilter(CharacterEncodingFilter.java:81)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(Unknown Source)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(Unknown Source)
	at org.apache.catalina.core.StandardWrapperValve.invoke(Unknown Source)
	at org.apache.catalina.core.StandardContextValve.invoke(Unknown Source)
	at org.apache.catalina.authenticator.AuthenticatorBase.invoke(Unknown Source)
	at org.apache.catalina.core.StandardHostValve.invoke(Unknown Source)
	at org.apache.catalina.valves.ErrorReportValve.invoke(Unknown Source)
	at org.apache.catalina.core.StandardEngineValve.invoke(Unknown Source)
	at org.apache.catalina.connector.CoyoteAdapter.service(Unknown Source)
	at org.apache.coyote.ajp.AjpAprProcessor.process(Unknown Source)
	at org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(Unknown Source)
	at org.apache.tomcat.util.net.AprEndpoint$SocketProcessor.run(Unknown Source)
	at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:895)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:918)
	at java.lang.Thread.run(Thread.java:662)
Caused by: java.lang.RuntimeException: Failed to instantiate class hudson.plugins.git.GitSCM from {"value":"2","userRemoteConfigs":{"url":"https://github.com/takezoe/gitbucket.git","name":"","refspec":""},"branches":{"name":"master"},"includedRegions":"","excludedRegions":"","excludedUsers":"","localBranch":"","relativeTargetDir":"","reference":"","scmName":"","gitConfigName":"","gitConfigEmail":"","pruneBranches":false,"skipTag":false,"clean":false,"remotePoll":false,"disableSubmodules":false,"recursiveSubmodules":false,"authorOrCommitter":false,"wipeOutWorkspace":false,"ignoreNotifyCommit":false,"useShallowClone":false,"":["hudson.plugins.git.util.DefaultBuildChooser","7"],"buildChooser":{"stapler-class<span class="code-quote">":"hudson.plugins.git.util.DefaultBuildChooser"},"gitTool":"Default","browser":{"stapler-class<span class="code-quote">":"hudson.plugins.git.browser.GithubWeb","url":"https://github.com/takezoe/gitbucket/"}}
	at hudson.model.Descriptor.newInstance(Descriptor.java:578)
	at hudson.plugins.git.GitSCM$DescriptorImpl.newInstance(GitSCM.java:1498)
	at hudson.plugins.git.GitSCM$DescriptorImpl.newInstance(GitSCM.java:1419)
	at hudson.scm.SCMS.parseSCM(SCMS.java:63)
	at hudson.model.AbstractProject.submit(AbstractProject.java:2002)
	at hudson.model.Project.submit(Project.java:202)
	at hudson.model.Job.doConfigSubmit(Job.java:1136)
	at hudson.model.AbstractProject.doConfigSubmit(AbstractProject.java:787)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
	at java.lang.reflect.Method.invoke(Method.java:597)
	at org.kohsuke.stapler.Function$InstanceFunction.invoke(Function.java:297)
	at org.kohsuke.stapler.Function.bindAndInvoke(Function.java:160)
	at org.kohsuke.stapler.Function.bindAndInvokeAndServeResponse(Function.java:95)
	at org.kohsuke.stapler.MetaClass$1.doDispatch(MetaClass.java:120)
	at org.kohsuke.stapler.NameBasedDispatcher.dispatch(NameBasedDispatcher.java:53)
	at org.kohsuke.stapler.Stapler.tryInvoke(Stapler.java:727)
	... 67 more
Caused by: java.lang.RuntimeException: Failed to instantiate class hudson.plugins.git.GitSCM from {"value":"2","userRemoteConfigs":{"url":"https://github.com/takezoe/gitbucket.git","name":"","refspec":""},"branches":{"name":"master"},"includedRegions":"","excludedRegions":"","excludedUsers":"","localBranch":"","relativeTargetDir":"","reference":"","scmName":"","gitConfigName":"","gitConfigEmail":"","pruneBranches":false,"skipTag":false,"clean":false,"remotePoll":false,"disableSubmodules":false,"recursiveSubmodules":false,"authorOrCommitter":false,"wipeOutWorkspace":false,"ignoreNotifyCommit":false,"useShallowClone":false,"":["hudson.plugins.git.util.DefaultBuildChooser","7"],"buildChooser":{"stapler-class<span class="code-quote">":"hudson.plugins.git.util.DefaultBuildChooser"},"gitTool":"Default","browser":{"stapler-class<span class="code-quote">":"hudson.plugins.git.browser.GithubWeb","url":"https://github.com/takezoe/gitbucket/"}}
	at hudson.model.Descriptor.newInstance(Descriptor.java:578)
	at hudson.plugins.git.GitSCM$DescriptorImpl.newInstance(GitSCM.java:1498)
	at hudson.plugins.git.GitSCM$DescriptorImpl.newInstance(GitSCM.java:1419)
	at hudson.model.Descriptor$1.instantiate(Descriptor.java:1046)
	at org.kohsuke.stapler.RequestImpl.instantiate(RequestImpl.java:665)
	at org.kohsuke.stapler.RequestImpl.access$100(RequestImpl.java:81)
	at org.kohsuke.stapler.RequestImpl$TypePair.convertJSON(RequestImpl.java:587)
	at org.kohsuke.stapler.RequestImpl.bindJSON(RequestImpl.java:400)
	at org.kohsuke.stapler.RequestImpl.bindJSON(RequestImpl.java:396)
	at hudson.model.Descriptor.newInstance(Descriptor.java:569)
	... 84 more
Caused by: java.lang.IllegalArgumentException: Failed to instantiate class hudson.plugins.git.GitSCM from {"value":"2","userRemoteConfigs":{"url":"https://github.com/takezoe/gitbucket.git","name":"","refspec":""},"branches":{"name":"master"},"includedRegions":"","excludedRegions":"","excludedUsers":"","localBranch":"","relativeTargetDir":"","reference":"","scmName":"","gitConfigName":"","gitConfigEmail":"","pruneBranches":false,"skipTag":false,"clean":false,"remotePoll":false,"disableSubmodules":false,"recursiveSubmodules":false,"authorOrCommitter":false,"wipeOutWorkspace":false,"ignoreNotifyCommit":false,"useShallowClone":false,"":["hudson.plugins.git.util.DefaultBuildChooser","7"],"buildChooser":{"stapler-class<span class="code-quote">":"hudson.plugins.git.util.DefaultBuildChooser"},"gitTool":"Default","browser":{"stapler-class<span class="code-quote">":"hudson.plugins.git.browser.GithubWeb","url":"https://github.com/takezoe/gitbucket/"}}
	at org.kohsuke.stapler.RequestImpl$TypePair.convertJSON(RequestImpl.java:589)
	at org.kohsuke.stapler.RequestImpl.bindJSON(RequestImpl.java:400)
	at org.kohsuke.stapler.RequestImpl.bindJSON(RequestImpl.java:396)
	at hudson.model.Descriptor.newInstance(Descriptor.java:569)
	... 93 more
Caused by: java.lang.IllegalArgumentException: Failed to convert the browser parameter of the constructor public hudson.plugins.git.GitSCM(java.lang.String,java.util.List,java.util.List,hudson.plugins.git.UserMergeOptions,java.lang.Boolean,java.util.Collection,boolean,boolean,hudson.plugins.git.util.BuildChooser,hudson.plugins.git.browser.GitRepositoryBrowser,java.lang.String,boolean,java.lang.String,java.lang.String,java.lang.String,java.lang.String,java.lang.String,boolean,boolean,boolean,boolean,java.lang.String,java.lang.String,boolean,java.lang.String,boolean,boolean)
	at org.kohsuke.stapler.RequestImpl.instantiate(RequestImpl.java:686)
	at org.kohsuke.stapler.RequestImpl.access$100(RequestImpl.java:81)
	at org.kohsuke.stapler.RequestImpl$TypePair.convertJSON(RequestImpl.java:587)
	... 96 more
Caused by: java.lang.IllegalArgumentException: Failed to instantiate class hudson.plugins.git.browser.GitRepositoryBrowser from {"stapler-class":"hudson.plugins.git.browser.GithubWeb","url":"https://github.com/takezoe/gitbucket/"}
	at org.kohsuke.stapler.RequestImpl$TypePair.convertJSON(RequestImpl.java:589)
	at org.kohsuke.stapler.RequestImpl.bindJSON(RequestImpl.java:400)
	at org.kohsuke.stapler.RequestImpl.instantiate(RequestImpl.java:684)
	... 98 more
Caused by: java.lang.IllegalArgumentException: java.net.MalformedURLException
	at org.kohsuke.stapler.RequestImpl.invokeConstructor(RequestImpl.java:462)
	at org.kohsuke.stapler.RequestImpl.bindParameters(RequestImpl.java:392)
	at org.kohsuke.stapler.RequestImpl.bindParameters(RequestImpl.java:363)
	at hudson.plugins.git.browser.GithubWeb$GithubWebDescriptor.newInstance(GithubWeb.java:104)
	at hudson.plugins.git.browser.GithubWeb$GithubWebDescriptor.newInstance(GithubWeb.java:96)
	at hudson.model.Descriptor$1.instantiate(Descriptor.java:1046)
	at org.kohsuke.stapler.RequestImpl.instantiate(RequestImpl.java:665)
	at org.kohsuke.stapler.RequestImpl.access$100(RequestImpl.java:81)
	at org.kohsuke.stapler.RequestImpl$TypePair.convertJSON(RequestImpl.java:587)
	... 100 more
Caused by: java.net.MalformedURLException
	at java.net.URL.<init>(URL.java:601)
	at java.net.URL.<init>(URL.java:464)
	at java.net.URL.<init>(URL.java:413)
	at hudson.plugins.git.browser.GithubWeb.<init>(GithubWeb.java:29)
	at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
	at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:39)
	at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:27)
	at java.lang.reflect.Constructor.newInstance(Constructor.java:513)
	at org.kohsuke.stapler.RequestImpl.invokeConstructor(RequestImpl.java:447)
	... 108 more

depends on

JENKINS-20262 Fix for JENKINS-18629 caused a regression in several plugins

Open

is duplicated by

JENKINS-20159 Cannot save configuration

Closed

JENKINS-20149 Malformed URL in GitWEB Browser after update to current versions

Closed

is related to

JENKINS-20186 MalformedURLException in mercurial.browser.KilnHG for HTTPS URL

Resolved

JENKINS-20149 Malformed URL in GitWEB Browser after update to current versions

Closed

sogabe created issue - 2013-10-18 09:45

sogabe made changes - 2013-10-18 09:46

Link

New: This issue is related to ~~JENKINS-18629~~ [ ~~JENKINS-18629~~ ]

sogabe added a comment - 2013-10-18 09:53

After ~~JENKINS-18629~~ fixed, GithubWebDescriptor#newInstance is getting to be invoked, instead of Descriptor#newInstance.
The result is that newInstance throws NPE.

GithubWebDescriptor#newInstance

        public GithubWeb newInstance(StaplerRequest req, JSONObject jsonObject) throws FormException {
            Return req. bindParameters (GithubWeb. class, "githubweb."); // "githubweb." ? 
        }

should be

        public GithubWeb newInstance(StaplerRequest req, JSONObject jsonObject) throws FormException {
            return req.bindJSON(GithubWeb.class, jsonObject);
        }

or remove it.

I think this is true for BitbucketWeb, CGit, GitLab and so on.

sogabe added a comment - 2013-10-18 09:53 After JENKINS-18629 fixed, GithubWebDescriptor#newInstance is getting to be invoked, instead of Descriptor#newInstance. The result is that newInstance throws NPE. GithubWebDescriptor#newInstance public GithubWeb newInstance(StaplerRequest req, JSONObject jsonObject) throws FormException { Return req. bindParameters (GithubWeb. class, "githubweb." ); // "githubweb." ? } should be public GithubWeb newInstance(StaplerRequest req, JSONObject jsonObject) throws FormException { return req.bindJSON(GithubWeb.class, jsonObject); } or remove it. I think this is true for BitbucketWeb, CGit, GitLab and so on.

sogabe made changes - 2013-10-18 10:01

Environment

Original: Jenkins 1.537-SNAPSHOT

New: Jenkins 1.537-SNAPSHOT
Git Plugin 1.5.0

Jesse Glick added a comment - 2013-10-18 13:15

Is this thrown for everyone? If so, it is a serious bug.

Jesse Glick added a comment - 2013-10-18 13:15 Is this thrown for everyone? If so, it is a serious bug.

Jesse Glick made changes - 2013-10-18 13:15

Priority

Original: Major [ 3 ]

New: Critical [ 2 ]

sogabe added a comment - 2013-10-18 13:31

If you configure repository browser of Git, it always throw NPE.

sogabe added a comment - 2013-10-18 13:31 If you configure repository browser of Git, it always throw NPE.

sogabe made changes - 2013-10-21 19:33

Link

New: This issue is related to ~~JENKINS-20149~~ [ ~~JENKINS-20149~~ ]

Kevin Fitzpatrick added a comment - 2013-10-22 00:59

Hi everyone.
This issue is a big deal for me, so I'm willing to pay USD 20.00 for it.
This offer is registered on FreedomSponsors (http://www.freedomsponsors.org/core/issue/368/submitting-project-configuration-causes-git-plugin-to-throw-npe).
If you solve it (according to the acceptance criteria described there), please register on FreedomSponsors and mark it as resolved there
I'll then check it out and gladly pay up!

Oh, and if anyone else also wants throw in a few bucks on this, you should check out FreedomSponsors!

Kevin Fitzpatrick added a comment - 2013-10-22 00:59 Hi everyone. This issue is a big deal for me, so I'm willing to pay USD 20.00 for it. This offer is registered on FreedomSponsors ( http://www.freedomsponsors.org/core/issue/368/submitting-project-configuration-causes-git-plugin-to-throw-npe ). If you solve it (according to the acceptance criteria described there), please register on FreedomSponsors and mark it as resolved there I'll then check it out and gladly pay up! Oh, and if anyone else also wants throw in a few bucks on this, you should check out FreedomSponsors!

sogabe made changes - 2013-10-22 03:51

Link

New: This issue is duplicated by ~~JENKINS-20159~~ [ ~~JENKINS-20159~~ ]

Assignee:: Nicolas De Loof

Reporter:: sogabe

Votes:: 5 Vote for this issue

Watchers:: 18 Start watching this issue

Created:: 2013-10-18 09:45

Updated:: 2015-11-06 21:48

Resolved:: 2013-10-22 14:42

Jenkins

Details

Description

Attachments

Issue Links

Activity

Collapse comment: sogabe added a comment - 2013-10-18 09:53

Expand comment: sogabe added a comment - 2013-10-18 09:53

Collapse comment: Jesse Glick added a comment - 2013-10-18 13:15

Expand comment: Jesse Glick added a comment - 2013-10-18 13:15

Collapse comment: sogabe added a comment - 2013-10-18 13:31

Expand comment: sogabe added a comment - 2013-10-18 13:31

Collapse comment: Kevin Fitzpatrick added a comment - 2013-10-22 00:59

Expand comment: Kevin Fitzpatrick added a comment - 2013-10-22 00:59

People

Dates