Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-20143

ViewJobFilter.filter expect "All jobs that are possible." but don't get recursive ones

    XMLWordPrintable

Details

    Description

      introduced for recursive views didn't applied to ViewJobFilter.filter "all" parameter, that is supposed to provide all possible jobs, but miss the recursively accessible ones.

      Attachments

        Issue Links

          depends on

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-20415 ListView.expand throws ClassCastException: … cannot be cast to hudson.model.TopLevelItem

          • Major - Major loss of function.
          • Resolved
          is blocking

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-20052 ListView.getItems makes too many passes through jobs list

          • Major - Major loss of function.
          • Resolved

          Activity

            Ascending order - Click to sort in descending order
            ndeloof Nicolas De Loof created issue -
            ndeloof Nicolas De Loof added a comment -

            Probably simpler to implement in plugins (seems to be only few of them) than depending on a newer core version
            see https://github.com/jenkinsci/view-job-filters-plugin/pull/3

            ndeloof Nicolas De Loof added a comment - Probably simpler to implement in plugins (seems to be only few of them) than depending on a newer core version see https://github.com/jenkinsci/view-job-filters-plugin/pull/3
            jglick Jesse Glick made changes -
            Field Original Value New Value
            Link This issue duplicates JENKINS-20052 [ JENKINS-20052 ]
            jglick Jesse Glick made changes -
            Resolution Duplicate [ 3 ]
            Status Open [ 1 ] Resolved [ 5 ]
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Nicolas De Loof
            Path:
            changelog.html
            core/src/main/java/hudson/model/ListView.java
            http://jenkins-ci.org/commit/jenkins/711558913410b82d4b2a95d1ff5bb2037f212f0c
            Log:
            [FIXED JENKINS-20143] Pass full list of all possible jobs to ViewJobFilter when recurse option is set

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Nicolas De Loof Path: changelog.html core/src/main/java/hudson/model/ListView.java http://jenkins-ci.org/commit/jenkins/711558913410b82d4b2a95d1ff5bb2037f212f0c Log: [FIXED JENKINS-20143] Pass full list of all possible jobs to ViewJobFilter when recurse option is set
            dogfood dogfood added a comment -

            Integrated in jenkins_main_trunk #2965
            [FIXED JENKINS-20143] Pass full list of all possible jobs to ViewJobFilter when recurse option is set (Revision 711558913410b82d4b2a95d1ff5bb2037f212f0c)

            Result = SUCCESS
            Nicolas De Loof : 711558913410b82d4b2a95d1ff5bb2037f212f0c
            Files :

            • changelog.html
            • core/src/main/java/hudson/model/ListView.java
            dogfood dogfood added a comment - Integrated in jenkins_main_trunk #2965 [FIXED JENKINS-20143] Pass full list of all possible jobs to ViewJobFilter when recurse option is set (Revision 711558913410b82d4b2a95d1ff5bb2037f212f0c) Result = SUCCESS Nicolas De Loof : 711558913410b82d4b2a95d1ff5bb2037f212f0c Files : changelog.html core/src/main/java/hudson/model/ListView.java
            jglick Jesse Glick made changes -
            Link This issue is blocking JENKINS-20052 [ JENKINS-20052 ]
            jglick Jesse Glick made changes -
            Link This issue duplicates JENKINS-20052 [ JENKINS-20052 ]
            jglick Jesse Glick added a comment -

            Being tracked confusingly.

            jglick Jesse Glick added a comment - Being tracked confusingly.
            jglick Jesse Glick made changes -
            Resolution Duplicate [ 3 ]
            Status Resolved [ 5 ] Reopened [ 4 ]
            jglick Jesse Glick made changes -
            Resolution Fixed [ 1 ]
            Status Reopened [ 4 ] Resolved [ 5 ]
            jglick Jesse Glick made changes -
            Assignee Nicolas De Loof [ ndeloof ]
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            changelog.html
            http://jenkins-ci.org/commit/jenkins/82b6e8e02b7e1d535bd3704255363fe7d0d1e6da
            Log:
            Fixed JENKINS-20143, not JENKINS-20123.

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: changelog.html http://jenkins-ci.org/commit/jenkins/82b6e8e02b7e1d535bd3704255363fe7d0d1e6da Log: Fixed JENKINS-20143 , not JENKINS-20123 .
            dogfood dogfood added a comment -

            Integrated in jenkins_main_trunk #2967
            Fixed JENKINS-20143, not JENKINS-20123. (Revision 82b6e8e02b7e1d535bd3704255363fe7d0d1e6da)

            Result = SUCCESS
            Jesse Glick : 82b6e8e02b7e1d535bd3704255363fe7d0d1e6da
            Files :

            • changelog.html
            dogfood dogfood added a comment - Integrated in jenkins_main_trunk #2967 Fixed JENKINS-20143 , not JENKINS-20123 . (Revision 82b6e8e02b7e1d535bd3704255363fe7d0d1e6da) Result = SUCCESS Jesse Glick : 82b6e8e02b7e1d535bd3704255363fe7d0d1e6da Files : changelog.html
            danielbeck Daniel Beck added a comment -

            What is the impact of this? View Filters don't see descendants from the 'recurse into folders' option?

            So e.g. if I have a top-level view 'Failing', it'll not actually show failing jobs that are located in folders?

            danielbeck Daniel Beck added a comment - What is the impact of this? View Filters don't see descendants from the 'recurse into folders' option? So e.g. if I have a top-level view 'Failing', it'll not actually show failing jobs that are located in folders?
            jglick Jesse Glick added a comment -

            Yes, I think that is it.

            jglick Jesse Glick added a comment - Yes, I think that is it.
            danielbeck Daniel Beck made changes -
            Labels lts-candidate
            danielbeck Daniel Beck added a comment - - edited

            Labeled lts-candidate for consideration once soaked enough. Views like ci.jenkins-ci.org's default view would be useless when using Folders.

            danielbeck Daniel Beck added a comment - - edited Labeled lts-candidate for consideration once soaked enough. Views like ci.jenkins-ci.org's default view would be useless when using Folders.
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Nicolas De Loof
            Path:
            core/src/main/java/hudson/model/ListView.java
            http://jenkins-ci.org/commit/jenkins/c8e447bd2e7d0f1e67cce7ed396323f84eed75d4
            Log:
            [FIXED JENKINS-20143] Pass full list of all possible jobs to ViewJobFilter when recurse option is set
            (cherry picked from commit 711558913410b82d4b2a95d1ff5bb2037f212f0c)

            Conflicts:
            changelog.html

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Nicolas De Loof Path: core/src/main/java/hudson/model/ListView.java http://jenkins-ci.org/commit/jenkins/c8e447bd2e7d0f1e67cce7ed396323f84eed75d4 Log: [FIXED JENKINS-20143] Pass full list of all possible jobs to ViewJobFilter when recurse option is set (cherry picked from commit 711558913410b82d4b2a95d1ff5bb2037f212f0c) Conflicts: changelog.html
            olivergondza Oliver Gondža made changes -
            Labels lts-candidate 1.532.1-fixed
            jglick Jesse Glick made changes -
            Link This issue depends on JENKINS-20415 [ JENKINS-20415 ]
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            changelog.html
            core/src/main/java/hudson/model/ListView.java
            test/src/test/java/hudson/model/ListViewTest.java
            http://jenkins-ci.org/commit/jenkins/bdbac284723940e5b2dfd37dd194524305de29c2
            Log:
            [FIXED JENKINS-20415] Lack of type safety in JENKINS-20143 fix sometimes caused CCEs.

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: changelog.html core/src/main/java/hudson/model/ListView.java test/src/test/java/hudson/model/ListViewTest.java http://jenkins-ci.org/commit/jenkins/bdbac284723940e5b2dfd37dd194524305de29c2 Log: [FIXED JENKINS-20415] Lack of type safety in JENKINS-20143 fix sometimes caused CCEs.
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            core/src/main/java/hudson/model/ListView.java
            test/src/test/java/hudson/model/ListViewTest.java
            http://jenkins-ci.org/commit/jenkins/4f3a9d6eadbc9adc25a0cc8025730429f3a0e583
            Log:
            [FIXED JENKINS-20415] Lack of type safety in JENKINS-20143 fix sometimes caused CCEs.
            (cherry picked from commit bdbac284723940e5b2dfd37dd194524305de29c2)

            Conflicts:
            changelog.html

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: core/src/main/java/hudson/model/ListView.java test/src/test/java/hudson/model/ListViewTest.java http://jenkins-ci.org/commit/jenkins/4f3a9d6eadbc9adc25a0cc8025730429f3a0e583 Log: [FIXED JENKINS-20415] Lack of type safety in JENKINS-20143 fix sometimes caused CCEs. (cherry picked from commit bdbac284723940e5b2dfd37dd194524305de29c2) Conflicts: changelog.html
            rtyler R. Tyler Croy made changes -
            Workflow JNJira [ 151665 ] JNJira + In-Review [ 194036 ]

            People

              ndeloof Nicolas De Loof
              ndeloof Nicolas De Loof
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: