Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-20052

ListView.getItems makes too many passes through jobs list

    XMLWordPrintable

Details

    • Jenkins 2.239

    Description

      Since pull 757 in 1.512, ListView can include items in subfolders. Unfortunately it seems that getItems calls ViewJobFilter with anomalous arguments: items may be a superset, rather than a subset, of allItems.

      Should be better tested, and simplified by inlining the includeItems method, which could also improve performance by removing the double traversal of the job hierarchy (which checks ACLs each time through).

      Attachments

        Issue Links

          Activity

            People

              raihaan Raihaan Shouhell
              jglick Jesse Glick
              Votes:
              3 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: