Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-20052

ListView.getItems makes too many passes through jobs list

    XMLWordPrintable

Details

    • Jenkins 2.239

    Description

      Since pull 757 in 1.512, ListView can include items in subfolders. Unfortunately it seems that getItems calls ViewJobFilter with anomalous arguments: items may be a superset, rather than a subset, of allItems.

      Should be better tested, and simplified by inlining the includeItems method, which could also improve performance by removing the double traversal of the job hierarchy (which checks ACLs each time through).

      Attachments

        Issue Links

          causes

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-62661 Views with status filters lost upgrading from 2.238 to 2.240

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-63678 Jenkins upgrade to 2.249.1 removes Build monitor tab with statusFilter view

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed
          depends on

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-18721 ListView asks for all jobs too often

          • Major - Major loss of function.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-20143 ViewJobFilter.filter expect "All jobs that are possible." but don't get recursive ones

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved
          is related to

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-18364 Optimize creation of relative links to jobs

          • Major - Major loss of function.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-22720 Non-recursive ListViews unnecessarily call owner.getAllItems in getItems

          • Major - Major loss of function.
          • Resolved
          links to

          Web Link Core PR-4466

          Activity

            People

              raihaan Raihaan Shouhell
              jglick Jesse Glick
              Votes:
              3 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: