Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-20217

Too many PingThread's

    XMLWordPrintable

Details

    Description

      Looking at a thread dump from a user with a lot of executors I see lots of:

      Ping thread for channel hudson.remoting.Channel@...:... id=... (0x...) state=TIMED_WAITING
          at java.lang.Thread.sleep(Native Method)
          at hudson.remoting.PingThread.run(PingThread.java:86)
      

      Surely these could all be replaced with a single Timer or ScheduledExecutorService?

      Attachments

        Activity

          marcomiller Marco Miller added a comment -

          Could such many pingers negatively impact channel /socket functionality in prod, Jesse?

          marcomiller Marco Miller added a comment - Could such many pingers negatively impact channel /socket functionality in prod, Jesse?
          jglick Jesse Glick added a comment -

          Not sure, but having a lot of extra threads is potentially bad for scalability.

          jglick Jesse Glick added a comment - Not sure, but having a lot of extra threads is potentially bad for scalability.
          jglick Jesse Glick added a comment -

          -Dhudson.slaves.ChannelPinger.pingInterval=0 seems to be the workaround.

          jglick Jesse Glick added a comment - -Dhudson.slaves.ChannelPinger.pingInterval=0 seems to be the workaround.

          People

            Unassigned Unassigned
            jglick Jesse Glick
            Votes:
            1 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated: