• Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Major Major
    • core
    • None
    • jenkins 1.537 (current master)

      Jenkins should support following variable expansions:

      JENKINS-19488 (3eea39648943583a530f47f69f93737266537d9d) and JENKINS-19926 (b95f2694529d22523701e8fe20f4f20b2f4d9fc4) did that in a too ad hoc way, and I'll re-implement it in more general way.

          [JENKINS-20280] Support nested variable expansion

          ikedam added a comment -

          ikedam added a comment - Sent a pull request: https://github.com/jenkinsci/jenkins/pull/986

          Code changed in jenkins
          User: ikedam
          Path:
          core/src/main/java/hudson/EnvVars.java
          core/src/main/java/hudson/Launcher.java
          core/src/test/java/hudson/EnvVarsTest.java
          http://jenkins-ci.org/commit/jenkins/4204d22496a77c2ccc0bb9f959592a01e27fb54d
          Log:
          [FIX JENKINS-20280] Calculates the order to override variables. This is an improved fix for JENKINS-19488 and JENKINS-19926.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: ikedam Path: core/src/main/java/hudson/EnvVars.java core/src/main/java/hudson/Launcher.java core/src/test/java/hudson/EnvVarsTest.java http://jenkins-ci.org/commit/jenkins/4204d22496a77c2ccc0bb9f959592a01e27fb54d Log: [FIX JENKINS-20280] Calculates the order to override variables. This is an improved fix for JENKINS-19488 and JENKINS-19926 .

          Code changed in jenkins
          User: Kohsuke Kawaguchi
          Path:
          changelog.html
          core/src/main/java/hudson/EnvVars.java
          core/src/main/java/hudson/Launcher.java
          core/src/test/java/hudson/EnvVarsTest.java
          http://jenkins-ci.org/commit/jenkins/e68ec055fda2c9fcba7d7cf4347852bcdf3e1fa6
          Log:
          [FIXED JENKINS-20280]

          Merged pull request #986.

          Compare: https://github.com/jenkinsci/jenkins/compare/d954f22b4735...e68ec055fda2

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Kohsuke Kawaguchi Path: changelog.html core/src/main/java/hudson/EnvVars.java core/src/main/java/hudson/Launcher.java core/src/test/java/hudson/EnvVarsTest.java http://jenkins-ci.org/commit/jenkins/e68ec055fda2c9fcba7d7cf4347852bcdf3e1fa6 Log: [FIXED JENKINS-20280] Merged pull request #986. Compare: https://github.com/jenkinsci/jenkins/compare/d954f22b4735...e68ec055fda2

          dogfood added a comment -

          Integrated in jenkins_main_trunk #2984
          [FIX JENKINS-20280] Calculates the order to override variables. This is an improved fix for JENKINS-19488 and JENKINS-19926. (Revision 4204d22496a77c2ccc0bb9f959592a01e27fb54d)

          Result = SUCCESS
          kohsuke : 4204d22496a77c2ccc0bb9f959592a01e27fb54d
          Files :

          • core/src/main/java/hudson/EnvVars.java
          • core/src/test/java/hudson/EnvVarsTest.java
          • core/src/main/java/hudson/Launcher.java

          dogfood added a comment - Integrated in jenkins_main_trunk #2984 [FIX JENKINS-20280] Calculates the order to override variables. This is an improved fix for JENKINS-19488 and JENKINS-19926 . (Revision 4204d22496a77c2ccc0bb9f959592a01e27fb54d) Result = SUCCESS kohsuke : 4204d22496a77c2ccc0bb9f959592a01e27fb54d Files : core/src/main/java/hudson/EnvVars.java core/src/test/java/hudson/EnvVarsTest.java core/src/main/java/hudson/Launcher.java

          Code changed in jenkins
          User: ikedam
          Path:
          core/src/main/java/hudson/EnvVars.java
          core/src/test/java/hudson/EnvVarsTest.java
          http://jenkins-ci.org/commit/jenkins/562c64bbdb271ca81ba89e83378175678c7132f6
          Log:
          JENKINS-20280 Make it easy to change the implementation. Especially Map.Entry is not so convenient to handle.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: ikedam Path: core/src/main/java/hudson/EnvVars.java core/src/test/java/hudson/EnvVarsTest.java http://jenkins-ci.org/commit/jenkins/562c64bbdb271ca81ba89e83378175678c7132f6 Log: JENKINS-20280 Make it easy to change the implementation. Especially Map.Entry is not so convenient to handle.

          Code changed in jenkins
          User: ikedam
          Path:
          core/src/main/java/hudson/EnvVars.java
          core/src/test/java/hudson/EnvVarsTest.java
          http://jenkins-ci.org/commit/jenkins/6d56de71cb66da077084ee6cc2f577d41e86acac
          Log:
          JENKINS-20280 Use topological sorting to decide the order to override variables.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: ikedam Path: core/src/main/java/hudson/EnvVars.java core/src/test/java/hudson/EnvVarsTest.java http://jenkins-ci.org/commit/jenkins/6d56de71cb66da077084ee6cc2f577d41e86acac Log: JENKINS-20280 Use topological sorting to decide the order to override variables.

          Code changed in jenkins
          User: Jesse Glick
          Path:
          core/src/main/java/hudson/EnvVars.java
          core/src/test/java/hudson/EnvVarsTest.java
          http://jenkins-ci.org/commit/jenkins/338ca9883f7632bedc1467b01a2ecbd8daf587db
          Log:
          Merge pull request #993 from ikedam/feature/JENKINS-20280_TopologicalSort

          JENKINS-20280 Decide variable overriding order with topological sorting

          Compare: https://github.com/jenkinsci/jenkins/compare/7e55b2f2656d...338ca9883f76

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: core/src/main/java/hudson/EnvVars.java core/src/test/java/hudson/EnvVarsTest.java http://jenkins-ci.org/commit/jenkins/338ca9883f7632bedc1467b01a2ecbd8daf587db Log: Merge pull request #993 from ikedam/feature/ JENKINS-20280 _TopologicalSort JENKINS-20280 Decide variable overriding order with topological sorting Compare: https://github.com/jenkinsci/jenkins/compare/7e55b2f2656d...338ca9883f76

          dogfood added a comment -

          Integrated in jenkins_main_trunk #3002
          JENKINS-20280 Make it easy to change the implementation. Especially Map.Entry is not so convenient to handle. (Revision 562c64bbdb271ca81ba89e83378175678c7132f6)
          JENKINS-20280 Use topological sorting to decide the order to override variables. (Revision 6d56de71cb66da077084ee6cc2f577d41e86acac)

          Result = SUCCESS
          devld : 562c64bbdb271ca81ba89e83378175678c7132f6
          Files :

          • core/src/main/java/hudson/EnvVars.java
          • core/src/test/java/hudson/EnvVarsTest.java

          devld : 6d56de71cb66da077084ee6cc2f577d41e86acac
          Files :

          • core/src/test/java/hudson/EnvVarsTest.java
          • core/src/main/java/hudson/EnvVars.java

          dogfood added a comment - Integrated in jenkins_main_trunk #3002 JENKINS-20280 Make it easy to change the implementation. Especially Map.Entry is not so convenient to handle. (Revision 562c64bbdb271ca81ba89e83378175678c7132f6) JENKINS-20280 Use topological sorting to decide the order to override variables. (Revision 6d56de71cb66da077084ee6cc2f577d41e86acac) Result = SUCCESS devld : 562c64bbdb271ca81ba89e83378175678c7132f6 Files : core/src/main/java/hudson/EnvVars.java core/src/test/java/hudson/EnvVarsTest.java devld : 6d56de71cb66da077084ee6cc2f577d41e86acac Files : core/src/test/java/hudson/EnvVarsTest.java core/src/main/java/hudson/EnvVars.java

            ikedam ikedam
            ikedam ikedam
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: