Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-20522

Should use DescriptorVisibilityFilter from JobTypeFilter

XMLWordPrintable

      JobTypeFilter.DescriptorImpl.getJobTypes should apply DescriptorVisibilityFilter (passing some context which should ideally be the View that we are working on—try @AncestorInPath) to Items.all() before returning them.

      (Would have filed a pull request if you were on GitHub.)

          [JENKINS-20522] Should use DescriptorVisibilityFilter from JobTypeFilter

          Jesse Glick added a comment -

          Filed a PR for this.

          Jesse Glick added a comment - Filed a PR for this.

          Jesse Glick added a comment -

          BTW please consider moving off of Subversion and using GitHub.

          And note that there are changes in the master branch of the Git repo which you might not have picked up.

          Jesse Glick added a comment - BTW please consider moving off of Subversion and using GitHub. And note that there are changes in the master branch of the Git repo which you might not have picked up.

          Jacob Robertson added a comment -

          It's in git?

          https://github.com/jenkinsci/view-job-filters-plugin

          Jacob Robertson added a comment - It's in git? https://github.com/jenkinsci/view-job-filters-plugin

          Jesse Glick added a comment -

          Yes, https://github.com/jenkinsci/view-job-filters-plugin/pull/6 as in the link I added to this issue.

          Jesse Glick added a comment - Yes, https://github.com/jenkinsci/view-job-filters-plugin/pull/6 as in the link I added to this issue.

          Jesse Glick added a comment -

          It is going on a year now with no movement. Do you intend to maintain this plugin? Should I consider it abandoned and cut a fresh release myself?

          Jesse Glick added a comment - It is going on a year now with no movement. Do you intend to maintain this plugin? Should I consider it abandoned and cut a fresh release myself?

          Jacob Robertson added a comment -

          Yes please take over from here.

          Jacob Robertson added a comment - Yes please take over from here.

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Jesse Glick
          Path:
          pom.xml
          src/main/java/hudson/views/JobTypeFilter.java
          src/main/java/hudson/views/MavenExtraStepsValuesHelper.java
          src/main/resources/hudson/views/JobTypeFilter/config.jelly
          http://jenkins-ci.org/commit/view-job-filters-plugin/fb754c204acebc22c08111e5c4aa38f53e7d858a
          Log:
          [FIXED JENKINS-20522] Proper usage of TopLevelItemDescriptor.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: pom.xml src/main/java/hudson/views/JobTypeFilter.java src/main/java/hudson/views/MavenExtraStepsValuesHelper.java src/main/resources/hudson/views/JobTypeFilter/config.jelly http://jenkins-ci.org/commit/view-job-filters-plugin/fb754c204acebc22c08111e5c4aa38f53e7d858a Log: [FIXED JENKINS-20522] Proper usage of TopLevelItemDescriptor.

            jacob_robertson Jacob Robertson
            jglick Jesse Glick
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: