• Type: Bug
• Resolution: Fixed
• Priority: Minor
• Component/s: sloccount-plugin
• Labels:

  None
• Environment:

  All platforms, bug in code logic.

1. 

   sloccount_missing_summary.png

   17 kB

   2013-11-19 02:57

[JENKINS-20646] Summary is missing for the first build

Collapse comment: Michal Turek added a comment - 2013-11-19 03:14

Michal Turek added a comment - 2013-11-19 03:14

Fixed in https://github.com/mixalturek/sloccount-plugin/commit/5493d931ac74f6330a13f9533671f46d6efd848c. Pull request sent on GitHub.

Expand comment: Michal Turek added a comment - 2013-11-19 03:14

Michal Turek added a comment - 2013-11-19 03:14 Fixed in https://github.com/mixalturek/sloccount-plugin/commit/5493d931ac74f6330a13f9533671f46d6efd848c . Pull request sent on GitHub.

Collapse comment: Michal Turek added a comment - 2013-11-19 03:17

Michal Turek added a comment - 2013-11-19 03:17

Please merge-in the patch.

Expand comment: Michal Turek added a comment - 2013-11-19 03:17

Michal Turek added a comment - 2013-11-19 03:17 Please merge-in the patch.

Collapse comment: SCM/JIRA link daemon added a comment - 2014-01-11 20:35

SCM/JIRA link daemon added a comment - 2014-01-11 20:35

Code changed in jenkins
User: Michal Turek
Path:
src/main/java/hudson/plugins/sloccount/ReportSummary.java
src/main/resources/hudson/plugins/sloccount/Messages.properties
http://jenkins-ci.org/commit/sloccount-plugin/5493d931ac74f6330a13f9533671f46d6efd848c
Log:
JENKINS-20646 Summary is missing for the first build

• The build summary was displayed only if both current and previous reports were not null. Only current report should be tested at top-level, test of previous report is relevant only while processing the differences.
• Hardcoded "in" string on summary page added to localication Messages (English only).

• Create a new project.
• Process a first build.
• Show its summary.
• Verify the summary contains valid text.
• Process a second build.
• Show its summary.
• Verify the summary contains valid text.
• All tests passed.

Expand comment: SCM/JIRA link daemon added a comment - 2014-01-11 20:35

SCM/JIRA link daemon added a comment - 2014-01-11 20:35 Code changed in jenkins User: Michal Turek Path: src/main/java/hudson/plugins/sloccount/ReportSummary.java src/main/resources/hudson/plugins/sloccount/Messages.properties http://jenkins-ci.org/commit/sloccount-plugin/5493d931ac74f6330a13f9533671f46d6efd848c Log: JENKINS-20646 Summary is missing for the first build The build summary was displayed only if both current and previous reports were not null. Only current report should be tested at top-level, test of previous report is relevant only while processing the differences. Hardcoded "in" string on summary page added to localication Messages (English only). Create a new project. Process a first build. Show its summary. Verify the summary contains valid text. Process a second build. Show its summary. Verify the summary contains valid text. All tests passed.