Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-20739

UI elements listing descriptor-based items need to apply DescriptorVisibilityFilter

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Major Major
    • core
    • None

      Currently, only /lib/hudson/newFromList/form.jelly applies Functions#filterDescriptors(Object,Iterable) before presenting options to users.

      Other UI elements that add items with descriptors (e.g. /lib/form/hetero-list.jelly) should do this as well.

          [JENKINS-20739] UI elements listing descriptor-based items need to apply DescriptorVisibilityFilter

          Oleg Nenashev added a comment -

          +1.
          I suppose it will be a very useful feature together with Extension Filter Plugin

          Oleg Nenashev added a comment - +1. I suppose it will be a very useful feature together with Extension Filter Plugin

          Daniel Beck added a comment -

          Daniel Beck added a comment - https://github.com/jenkinsci/jenkins/pull/1033

          Code changed in jenkins
          User: Daniel Beck
          Path:
          core/src/main/resources/lib/form/hetero-list.jelly
          http://jenkins-ci.org/commit/jenkins/06c8dcea6105a1505e6e609491dcc806763cd1f0
          Log:
          JENKINS-20739 Filter descriptors before adding them to hetero-list.

          This allows implementations of DescriptorVisibilityFilter to hide items
          with descriptors from users to prevent them from being added via the UI.

          This is already implemented in /lib/hudson/newFromList/form.jelly, but
          nowhere else.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Daniel Beck Path: core/src/main/resources/lib/form/hetero-list.jelly http://jenkins-ci.org/commit/jenkins/06c8dcea6105a1505e6e609491dcc806763cd1f0 Log: JENKINS-20739 Filter descriptors before adding them to hetero-list. This allows implementations of DescriptorVisibilityFilter to hide items with descriptors from users to prevent them from being added via the UI. This is already implemented in /lib/hudson/newFromList/form.jelly, but nowhere else.

          Code changed in jenkins
          User: Andrew Bayer
          Path:
          core/src/main/java/hudson/model/DescriptorVisibilityFilter.java
          core/src/main/resources/lib/form/hetero-list.jelly
          http://jenkins-ci.org/commit/jenkins/f484daf01eb82c2364a709dd1d01418ed4c22276
          Log:
          Merge pull request #1033 from daniel-beck/filter-descriptors

          JENKINS-20739 Filter descriptors before adding them to hetero-list

          Compare: https://github.com/jenkinsci/jenkins/compare/e96db8ed3590...f484daf01eb8

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Andrew Bayer Path: core/src/main/java/hudson/model/DescriptorVisibilityFilter.java core/src/main/resources/lib/form/hetero-list.jelly http://jenkins-ci.org/commit/jenkins/f484daf01eb82c2364a709dd1d01418ed4c22276 Log: Merge pull request #1033 from daniel-beck/filter-descriptors JENKINS-20739 Filter descriptors before adding them to hetero-list Compare: https://github.com/jenkinsci/jenkins/compare/e96db8ed3590...f484daf01eb8

          dogfood added a comment -

          Integrated in jenkins_main_trunk #3410
          JENKINS-20739 Filter descriptors before adding them to hetero-list. (Revision 06c8dcea6105a1505e6e609491dcc806763cd1f0)

          Result = SUCCESS
          daniel-beck : 06c8dcea6105a1505e6e609491dcc806763cd1f0
          Files :

          • core/src/main/resources/lib/form/hetero-list.jelly

          dogfood added a comment - Integrated in jenkins_main_trunk #3410 JENKINS-20739 Filter descriptors before adding them to hetero-list. (Revision 06c8dcea6105a1505e6e609491dcc806763cd1f0) Result = SUCCESS daniel-beck : 06c8dcea6105a1505e6e609491dcc806763cd1f0 Files : core/src/main/resources/lib/form/hetero-list.jelly

          Daniel Beck added a comment -

          Merged into master for 1.567+

          Daniel Beck added a comment - Merged into master for 1.567+

            danielbeck Daniel Beck
            danielbeck Daniel Beck
            Votes:
            1 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: