Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-20786

Replace radioBlocks by dropdownDescriptorSelector.

XMLWordPrintable

      hetero-radio selector overloads web UI in the case of big number of strategies. I suppose that dropdownDescriptoSelector would be preferable

          [JENKINS-20786] Replace radioBlocks by dropdownDescriptorSelector.

          ikedam added a comment -

          I doubt there would be so many subclasses of AuthorizeProjectStrategy.

          For I suppose 5-6 extensions (including current 3) at most,
          radio list is good for users to see what options are available.

          I'll consider this when the number of extensions grows.

          ikedam added a comment - I doubt there would be so many subclasses of AuthorizeProjectStrategy . For I suppose 5-6 extensions (including current 3) at most, radio list is good for users to see what options are available. I'll consider this when the number of extensions grows.

          ikedam added a comment -

          Using radio seems dangerous: JENKINS-20164
          I should proceed this ticket.

          ikedam added a comment - Using radio seems dangerous: JENKINS-20164 I should proceed this ticket.

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: ikedam
          Path:
          src/main/resources/org/jenkinsci/plugins/authorizeproject/AuthorizeProjectProperty/config.jelly
          src/main/resources/org/jenkinsci/plugins/authorizeproject/AuthorizeProjectProperty/help-strategy.groovy
          src/main/resources/org/jenkinsci/plugins/authorizeproject/AuthorizeProjectProperty/help-strategyRaw.html
          src/main/resources/org/jenkinsci/plugins/authorizeproject/AuthorizeProjectProperty/help-strategyRaw_ja.html
          src/main/resources/org/jenkinsci/plugins/authorizeproject/nestedHelp.js
          http://jenkins-ci.org/commit/authorize-project-plugin/cfbd4a0a2228c14e9c55d688c3908a18732fce30
          Log:
          [FIXED JENKINS-20786] Switched radio buttons to dropdown.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: ikedam Path: src/main/resources/org/jenkinsci/plugins/authorizeproject/AuthorizeProjectProperty/config.jelly src/main/resources/org/jenkinsci/plugins/authorizeproject/AuthorizeProjectProperty/help-strategy.groovy src/main/resources/org/jenkinsci/plugins/authorizeproject/AuthorizeProjectProperty/help-strategyRaw.html src/main/resources/org/jenkinsci/plugins/authorizeproject/AuthorizeProjectProperty/help-strategyRaw_ja.html src/main/resources/org/jenkinsci/plugins/authorizeproject/nestedHelp.js http://jenkins-ci.org/commit/authorize-project-plugin/cfbd4a0a2228c14e9c55d688c3908a18732fce30 Log: [FIXED JENKINS-20786] Switched radio buttons to dropdown.

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: ikedam
          Path:
          src/main/resources/org/jenkinsci/plugins/authorizeproject/strategy/AnonymousAuthorizationStrategy/config.jelly
          src/main/resources/org/jenkinsci/plugins/authorizeproject/strategy/TriggeringUsersAuthorizationStrategy/config.jelly
          http://jenkins-ci.org/commit/authorize-project-plugin/df37db62e4ded7e8c7b692e9cbc9b89fd140c4e1
          Log:
          JENKINS-20786 dropdownDescriptorSelector causes exception without config.jelly.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: ikedam Path: src/main/resources/org/jenkinsci/plugins/authorizeproject/strategy/AnonymousAuthorizationStrategy/config.jelly src/main/resources/org/jenkinsci/plugins/authorizeproject/strategy/TriggeringUsersAuthorizationStrategy/config.jelly http://jenkins-ci.org/commit/authorize-project-plugin/df37db62e4ded7e8c7b692e9cbc9b89fd140c4e1 Log: JENKINS-20786 dropdownDescriptorSelector causes exception without config.jelly.

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: ikedam
          Path:
          src/main/resources/org/jenkinsci/plugins/authorizeproject/AuthorizeProjectProperty/config.jelly
          src/main/resources/org/jenkinsci/plugins/authorizeproject/AuthorizeProjectProperty/help-strategy.groovy
          src/main/resources/org/jenkinsci/plugins/authorizeproject/AuthorizeProjectProperty/help-strategyRaw.html
          src/main/resources/org/jenkinsci/plugins/authorizeproject/AuthorizeProjectProperty/help-strategyRaw_ja.html
          src/main/resources/org/jenkinsci/plugins/authorizeproject/nestedHelp.js
          src/main/resources/org/jenkinsci/plugins/authorizeproject/strategy/AnonymousAuthorizationStrategy/config.jelly
          src/main/resources/org/jenkinsci/plugins/authorizeproject/strategy/SpecificUsersAuthorizationStrategy/checkPasswordRequested.js
          src/main/resources/org/jenkinsci/plugins/authorizeproject/strategy/TriggeringUsersAuthorizationStrategy/config.jelly
          http://jenkins-ci.org/commit/authorize-project-plugin/8672e86fa88c1f9573a58a22a547fbb3dae18dbe
          Log:
          Merge pull request #6 from ikedam/feature/JENKINS-20786_RadioToDropdown

          JENKINS-20786 switched hetero-radio to dropdownDescriptorSelector

          Compare: https://github.com/jenkinsci/authorize-project-plugin/compare/2374674a2a34...8672e86fa88c

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: ikedam Path: src/main/resources/org/jenkinsci/plugins/authorizeproject/AuthorizeProjectProperty/config.jelly src/main/resources/org/jenkinsci/plugins/authorizeproject/AuthorizeProjectProperty/help-strategy.groovy src/main/resources/org/jenkinsci/plugins/authorizeproject/AuthorizeProjectProperty/help-strategyRaw.html src/main/resources/org/jenkinsci/plugins/authorizeproject/AuthorizeProjectProperty/help-strategyRaw_ja.html src/main/resources/org/jenkinsci/plugins/authorizeproject/nestedHelp.js src/main/resources/org/jenkinsci/plugins/authorizeproject/strategy/AnonymousAuthorizationStrategy/config.jelly src/main/resources/org/jenkinsci/plugins/authorizeproject/strategy/SpecificUsersAuthorizationStrategy/checkPasswordRequested.js src/main/resources/org/jenkinsci/plugins/authorizeproject/strategy/TriggeringUsersAuthorizationStrategy/config.jelly http://jenkins-ci.org/commit/authorize-project-plugin/8672e86fa88c1f9573a58a22a547fbb3dae18dbe Log: Merge pull request #6 from ikedam/feature/ JENKINS-20786 _RadioToDropdown JENKINS-20786 switched hetero-radio to dropdownDescriptorSelector Compare: https://github.com/jenkinsci/authorize-project-plugin/compare/2374674a2a34...8672e86fa88c

          ikedam added a comment -

          Released in 1.0.3.

          ikedam added a comment - Released in 1.0.3.

            ikedam ikedam
            oleg_nenashev Oleg Nenashev
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: