• Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Major Major
    • m2release-plugin
    • None
    • n/a

      hudson.model.Cause.UserCause is deprecated and class ReleaseCause should extend hudson.model.Cause.UserIdCause instead.
      Also, it should not override methods like getUserName() as it will cause issues for other plugins like build-user-vars (see JENKINS-20787)!

          [JENKINS-20791] ReleaseCause should extend UserIdCause

          Anders Hammar added a comment -

          Anders Hammar added a comment - Fix in https://github.com/jenkinsci/m2release-plugin/pull/14

          Code changed in jenkins
          User: Anders Hammar
          Path:
          src/main/java/org/jvnet/hudson/plugins/m2release/ReleaseCause.java
          http://jenkins-ci.org/commit/m2release-plugin/b1998ac16fc334d3ac8553c4630f722def49e333
          Log:
          JENKINS-20791 ReleaseCause should extend UserIdCause

          Signed-off-by: Anders Hammar <anders@hammar.net>

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Anders Hammar Path: src/main/java/org/jvnet/hudson/plugins/m2release/ReleaseCause.java http://jenkins-ci.org/commit/m2release-plugin/b1998ac16fc334d3ac8553c4630f722def49e333 Log: JENKINS-20791 ReleaseCause should extend UserIdCause Signed-off-by: Anders Hammar <anders@hammar.net>

          Code changed in jenkins
          User: jtnord
          Path:
          src/main/java/org/jvnet/hudson/plugins/m2release/ReleaseCause.java
          http://jenkins-ci.org/commit/m2release-plugin/6ecc03b4d2b6beae10642ae809b9266183e389f2
          Log:
          Merge pull request #14 from andham/JENKINS-20791

          JENKINS-20791 ReleaseCause should extend UserIdCause

          Compare: https://github.com/jenkinsci/m2release-plugin/compare/531f00df3c13...6ecc03b4d2b6

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: jtnord Path: src/main/java/org/jvnet/hudson/plugins/m2release/ReleaseCause.java http://jenkins-ci.org/commit/m2release-plugin/6ecc03b4d2b6beae10642ae809b9266183e389f2 Log: Merge pull request #14 from andham/ JENKINS-20791 JENKINS-20791 ReleaseCause should extend UserIdCause Compare: https://github.com/jenkinsci/m2release-plugin/compare/531f00df3c13...6ecc03b4d2b6

            ahammar Anders Hammar
            ahammar Anders Hammar
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: