Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-20866

Seeing error page shouldn't require overall/read access

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      hudson.model.Failure class doesn't work if the caller doesn't have "overall/read" permission.

      This is observed with OpenID plugin authentication problem. The plugin throws the Failure object in an attempt to render the error page, but Jenkins doesn't allow requests to be routed to the error.jelly if the overall/read permission is not granted.

      The fix is pretty trivial in Jenkins.getTarget() but I need to write a test case as well and I don't have time right now, so I'm filing it instead.

        Attachments

          Activity

          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Kohsuke Kawaguchi
          Path:
          changelog.html
          core/src/main/java/jenkins/model/Jenkins.java
          test/src/test/java/jenkins/model/JenkinsTest.java
          http://jenkins-ci.org/commit/jenkins/b89baa56bf06b2a0f6b67a3e521236e476fe5a9d
          Log:
          [FIXED JENKINS-20866]

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Kohsuke Kawaguchi Path: changelog.html core/src/main/java/jenkins/model/Jenkins.java test/src/test/java/jenkins/model/JenkinsTest.java http://jenkins-ci.org/commit/jenkins/b89baa56bf06b2a0f6b67a3e521236e476fe5a9d Log: [FIXED JENKINS-20866]
          Hide
          dogfood dogfood added a comment -

          Integrated in jenkins_main_trunk #3090
          [FIXED JENKINS-20866] (Revision b89baa56bf06b2a0f6b67a3e521236e476fe5a9d)

          Result = SUCCESS
          kohsuke : b89baa56bf06b2a0f6b67a3e521236e476fe5a9d
          Files :

          • test/src/test/java/jenkins/model/JenkinsTest.java
          • core/src/main/java/jenkins/model/Jenkins.java
          • changelog.html
          Show
          dogfood dogfood added a comment - Integrated in jenkins_main_trunk #3090 [FIXED JENKINS-20866] (Revision b89baa56bf06b2a0f6b67a3e521236e476fe5a9d) Result = SUCCESS kohsuke : b89baa56bf06b2a0f6b67a3e521236e476fe5a9d Files : test/src/test/java/jenkins/model/JenkinsTest.java core/src/main/java/jenkins/model/Jenkins.java changelog.html

            People

            Assignee:
            kohsuke Kohsuke Kawaguchi
            Reporter:
            kohsuke Kohsuke Kawaguchi
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: