Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-20974

RunParameter with filtering enabled incorrectly includes builds which have not yet completed

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Major Major
    • core
    • None

      Builds have are still in progress can have a result of SUCCESS and so be included in a RunParamter which has filtering enabled. It should only include completed builds so we know the build result will not change.

          [JENKINS-20974] RunParameter with filtering enabled incorrectly includes builds which have not yet completed

          Code changed in jenkins
          User: gcummings
          Path:
          core/src/main/java/hudson/model/RunParameterDefinition.java
          core/src/main/java/hudson/util/RunList.java
          http://jenkins-ci.org/commit/jenkins/39d1a605bca6fd0a2e538471fe7bf28a3a8245f7
          Log:
          JENKINS-20974 RunParameter with filtering enabled should not include builds which have not completed

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: gcummings Path: core/src/main/java/hudson/model/RunParameterDefinition.java core/src/main/java/hudson/util/RunList.java http://jenkins-ci.org/commit/jenkins/39d1a605bca6fd0a2e538471fe7bf28a3a8245f7 Log: JENKINS-20974 RunParameter with filtering enabled should not include builds which have not completed

          Code changed in jenkins
          User: Kohsuke Kawaguchi
          Path:
          core/src/main/java/hudson/model/RunParameterDefinition.java
          core/src/main/java/hudson/util/RunList.java
          http://jenkins-ci.org/commit/jenkins/5b4440a2b89bc0ee782c6e6b0b9b3ea08f7eecae
          Log:
          JENKINS-20974 It's more composeable to just define a method that filters out inprogress builds.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Kohsuke Kawaguchi Path: core/src/main/java/hudson/model/RunParameterDefinition.java core/src/main/java/hudson/util/RunList.java http://jenkins-ci.org/commit/jenkins/5b4440a2b89bc0ee782c6e6b0b9b3ea08f7eecae Log: JENKINS-20974 It's more composeable to just define a method that filters out inprogress builds.

          Code changed in jenkins
          User: Kohsuke Kawaguchi
          Path:
          changelog.html
          core/src/main/java/hudson/model/RunParameterDefinition.java
          core/src/main/java/hudson/util/RunList.java
          http://jenkins-ci.org/commit/jenkins/c3837b6c483c086cb81d37b85dca89b848193810
          Log:
          [FIXED JENKINS-20974]

          Merged pull request #1062

          Compare: https://github.com/jenkinsci/jenkins/compare/908a2e1b083b...c3837b6c483c

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Kohsuke Kawaguchi Path: changelog.html core/src/main/java/hudson/model/RunParameterDefinition.java core/src/main/java/hudson/util/RunList.java http://jenkins-ci.org/commit/jenkins/c3837b6c483c086cb81d37b85dca89b848193810 Log: [FIXED JENKINS-20974] Merged pull request #1062 Compare: https://github.com/jenkinsci/jenkins/compare/908a2e1b083b...c3837b6c483c

          dogfood added a comment -

          Integrated in jenkins_main_trunk #3326
          JENKINS-20974 RunParameter with filtering enabled should not include builds which have not completed (Revision 39d1a605bca6fd0a2e538471fe7bf28a3a8245f7)
          JENKINS-20974 It's more composeable to just define a method that filters out inprogress builds. (Revision 5b4440a2b89bc0ee782c6e6b0b9b3ea08f7eecae)

          Result = SUCCESS
          kohsuke : 39d1a605bca6fd0a2e538471fe7bf28a3a8245f7
          Files :

          • core/src/main/java/hudson/util/RunList.java
          • core/src/main/java/hudson/model/RunParameterDefinition.java

          kohsuke : 5b4440a2b89bc0ee782c6e6b0b9b3ea08f7eecae
          Files :

          • core/src/main/java/hudson/util/RunList.java
          • core/src/main/java/hudson/model/RunParameterDefinition.java

          dogfood added a comment - Integrated in jenkins_main_trunk #3326 JENKINS-20974 RunParameter with filtering enabled should not include builds which have not completed (Revision 39d1a605bca6fd0a2e538471fe7bf28a3a8245f7) JENKINS-20974 It's more composeable to just define a method that filters out inprogress builds. (Revision 5b4440a2b89bc0ee782c6e6b0b9b3ea08f7eecae) Result = SUCCESS kohsuke : 39d1a605bca6fd0a2e538471fe7bf28a3a8245f7 Files : core/src/main/java/hudson/util/RunList.java core/src/main/java/hudson/model/RunParameterDefinition.java kohsuke : 5b4440a2b89bc0ee782c6e6b0b9b3ea08f7eecae Files : core/src/main/java/hudson/util/RunList.java core/src/main/java/hudson/model/RunParameterDefinition.java

            gcummings Geoff Cummings
            gcummings Geoff Cummings
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: