Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-21295

Project Description column configs for trim and width not correctly redisplaying

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • extra-columns-plugin
    • None
    • Jenkins 1.528

      Version 1.13 doesn't correctly redisplay the "project Description" column settings for "Trim description" and "Force column width". When these have been checked on redisplay they appear unchecked.

      Behavior appears correct nevertheless.

          [JENKINS-21295] Project Description column configs for trim and width not correctly redisplaying

          Fred G added a comment -

          I reproduced and fixed the bug for the "Force column width" setting in Project Description column and Build Description column.
          Can't reproduce it with the "Trim description" setting though.
          Are you sure this doesn't work?

          Fred G added a comment - I reproduced and fixed the bug for the "Force column width" setting in Project Description column and Build Description column. Can't reproduce it with the "Trim description" setting though. Are you sure this doesn't work?

          OK, it appears the "Trim description" checkbox setting is being retained correctly. I must have mis-observed that.

          However, the "Force column width" entered doesn't seem to work exactly. For example I set it to 300 and I get something ~325 pixels in width. If I select 350 it uses ~400 pixels.

          Daniel Kirkdorffer added a comment - OK, it appears the "Trim description" checkbox setting is being retained correctly. I must have mis-observed that. However, the "Force column width" entered doesn't seem to work exactly. For example I set it to 300 and I get something ~325 pixels in width. If I select 350 it uses ~400 pixels.

          Fred G added a comment -

          There is some additional padding, so it might not be pixel perfect.
          I can't reproduce such big difference though.

          Which browser are you using? Can you attach a screenshot?

          Fred G added a comment - There is some additional padding, so it might not be pixel perfect. I can't reproduce such big difference though. Which browser are you using? Can you attach a screenshot?

          Code changed in jenkins
          User: Fred G
          Path:
          src/main/java/jenkins/plugins/extracolumns/BuildDescriptionColumn.java
          src/main/java/jenkins/plugins/extracolumns/BuildDurationColumn.java
          src/main/java/jenkins/plugins/extracolumns/DescriptionColumn.java
          src/main/resources/jenkins/plugins/extracolumns/BuildDescriptionColumn/config.jelly
          src/main/resources/jenkins/plugins/extracolumns/DescriptionColumn/config.jelly
          http://jenkins-ci.org/commit/extra-columns-plugin/17388893c69bee63f1002f6ba7550d922dbec06e
          Log:
          JENKINS-21295 - Project Description column configs for trim and width
          not correctly redisplaying

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Fred G Path: src/main/java/jenkins/plugins/extracolumns/BuildDescriptionColumn.java src/main/java/jenkins/plugins/extracolumns/BuildDurationColumn.java src/main/java/jenkins/plugins/extracolumns/DescriptionColumn.java src/main/resources/jenkins/plugins/extracolumns/BuildDescriptionColumn/config.jelly src/main/resources/jenkins/plugins/extracolumns/DescriptionColumn/config.jelly http://jenkins-ci.org/commit/extra-columns-plugin/17388893c69bee63f1002f6ba7550d922dbec06e Log: JENKINS-21295 - Project Description column configs for trim and width not correctly redisplaying

          > Which browser are you using?

          Latest Firefox.

          Daniel Kirkdorffer added a comment - > Which browser are you using? Latest Firefox.

          Fred G added a comment -

          Is this issue still relevant? Or can it be closed?

          Fred G added a comment - Is this issue still relevant? Or can it be closed?

          I'm no longer in a position to verify the relevancy.

          Daniel Kirkdorffer added a comment - I'm no longer in a position to verify the relevancy.

          Fred G added a comment -

          Please re-open if necessary.

          Fred G added a comment - Please re-open if necessary.

            dankirkd Daniel Kirkdorffer
            dankirkd Daniel Kirkdorffer
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: