Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-21394

Avoid queuing request for workspace while node is offline

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Major Major
    • core
    • None

      SCM polling jobs that requires a workspace for polling are submitted to the job queue when a capable slave is offline. When the slave comes online, the queued job runs, but the result is usually useless because the version did not have a newer version to build, so the result of the build is "Nothing to do"

          [JENKINS-21394] Avoid queuing request for workspace while node is offline

          Jens Brejner added a comment -

          @Eric - which Git Plugin version do you have ?

          Jens Brejner added a comment - @Eric - which Git Plugin version do you have ?

          Eric Tucker added a comment -

          Git Client 1.8.0
          Git 2.2.1

          Eric Tucker added a comment - Git Client 1.8.0 Git 2.2.1

          Steffen Sledz added a comment -

          @Mads

          I'have to correct my previous statements.

          • Downgrade Jenkins itself to 1.559 or earlier leads to a different behaviour. The "We need to schedule ... (all_suitable_nodes_are_offline)" is gone. But instead the affected jobs are triggered cyclic in a loop (each time scm checks for updates).
          • Downgrade multiple SCM plugin to 0.2 has no influence.
          • Downgrade GIT plugin to 2.0 completely fixes the problem(s).

          So may be we have two different (but related ?) problems here.

          Sorry for the confusion.

          Steffen Sledz added a comment - @Mads I'have to correct my previous statements. Downgrade Jenkins itself to 1.559 or earlier leads to a different behaviour. The "We need to schedule ... (all_suitable_nodes_are_offline)" is gone. But instead the affected jobs are triggered cyclic in a loop (each time scm checks for updates). Downgrade multiple SCM plugin to 0.2 has no influence. Downgrade GIT plugin to 2.0 completely fixes the problem(s). So may be we have two different (but related ?) problems here. Sorry for the confusion.

          Jens Brejner added a comment -

          A fix is on it's way, testing is in progress.

          Jens Brejner added a comment - A fix is on it's way, testing is in progress.

          Is it possible to tell us how long we have to wait until this fix is part of a new version?

          Martin Mössner added a comment - Is it possible to tell us how long we have to wait until this fix is part of a new version?

          Mads Nielsen added a comment -

          As soon as someone decides to merge pull request https://github.com/jenkinsci/jenkins/pull/1215

          This need to be merge i ammended my pull request so that it does not have the bug present with https://github.com/jenkinsci/jenkins/pull/1218.

          Mads Nielsen added a comment - As soon as someone decides to merge pull request https://github.com/jenkinsci/jenkins/pull/1215 This need to be merge i ammended my pull request so that it does not have the bug present with https://github.com/jenkinsci/jenkins/pull/1218 .

          Code changed in jenkins
          User: Mads Nielsen
          Path:
          core/src/main/java/hudson/model/AbstractProject.java
          test/src/test/java/hudson/model/ProjectTest.java
          http://jenkins-ci.org/commit/jenkins/492a60a69c2bac35578b7d93d6cb7a9f593da2f8
          Log:
          Fixing JENKINS-22750, regression introduced in JENKINS-21394

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Mads Nielsen Path: core/src/main/java/hudson/model/AbstractProject.java test/src/test/java/hudson/model/ProjectTest.java http://jenkins-ci.org/commit/jenkins/492a60a69c2bac35578b7d93d6cb7a9f593da2f8 Log: Fixing JENKINS-22750 , regression introduced in JENKINS-21394

          Code changed in jenkins
          User: Oliver Gondža
          Path:
          core/src/main/java/hudson/model/AbstractProject.java
          test/src/test/java/hudson/model/ProjectTest.java
          http://jenkins-ci.org/commit/jenkins/f371bc99685bab5a8bd70a3d461b91024727a5ed
          Log:
          Merge pull request #1215 from MadsNielsen/JENKINS-21394-Regression

          Fixing JENKINS-22750, regression introduced in JENKINS-21394

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oliver Gondža Path: core/src/main/java/hudson/model/AbstractProject.java test/src/test/java/hudson/model/ProjectTest.java http://jenkins-ci.org/commit/jenkins/f371bc99685bab5a8bd70a3d461b91024727a5ed Log: Merge pull request #1215 from MadsNielsen/ JENKINS-21394 -Regression Fixing JENKINS-22750 , regression introduced in JENKINS-21394

          Code changed in jenkins
          User: Mads Nielsen
          Path:
          test/src/main/java/org/jvnet/hudson/test/JenkinsRule.java
          http://jenkins-ci.org/commit/jenkins-test-harness/df1d33f95fd77ccb787812922cbf21088c1964d1
          Log:
          Added test for JENKINS-21394

          Originally-Committed-As: b98e0abe56511febc776778648df532f830bb2d7

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Mads Nielsen Path: test/src/main/java/org/jvnet/hudson/test/JenkinsRule.java http://jenkins-ci.org/commit/jenkins-test-harness/df1d33f95fd77ccb787812922cbf21088c1964d1 Log: Added test for JENKINS-21394 Originally-Committed-As: b98e0abe56511febc776778648df532f830bb2d7

          Code changed in jenkins
          User: Oliver Gondža
          Path:
          test/src/main/java/org/jvnet/hudson/test/JenkinsRule.java
          http://jenkins-ci.org/commit/jenkins-test-harness/18aa6eb6d3a5410804534667f830cacfa5e38ce7
          Log:
          Merge pull request #1092 from jbrejner/master

          [FIXED JENKINS-21394] Avoid irrelevant job queing while node is offline

          Conflicts:
          test/src/test/java/hudson/model/ProjectTest.java

          Originally-Committed-As: 82472d7f2b1981c60c3a32cbd7e90d31d3eb748f

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oliver Gondža Path: test/src/main/java/org/jvnet/hudson/test/JenkinsRule.java http://jenkins-ci.org/commit/jenkins-test-harness/18aa6eb6d3a5410804534667f830cacfa5e38ce7 Log: Merge pull request #1092 from jbrejner/master [FIXED JENKINS-21394] Avoid irrelevant job queing while node is offline Conflicts: test/src/test/java/hudson/model/ProjectTest.java Originally-Committed-As: 82472d7f2b1981c60c3a32cbd7e90d31d3eb748f

            jbrejner Jens Brejner
            jbrejner Jens Brejner
            Votes:
            0 Vote for this issue
            Watchers:
            14 Start watching this issue

              Created:
              Updated:
              Resolved: