Details
-
Bug
-
Status: Resolved (View Workflow)
-
Major
-
Resolution: Fixed
-
None
-
Platform: PC, OS: Windows XP
Description
Entering
foo=bar,baz
in the Systremproperties field (in German Systemeigenschaften) of an Ant
build-step of a freestyle project.
Results in the consoleoutput of the build to:
...
BUILD FAILED
Target "baz" does not exist in the project "projectname".
...
The Help text says one can use standardformat of properties files and commas are
allowed there. (Using commas in a properties used by Ant)
A workaround is to use:
foo="bar,baz"
Attachments
Issue Links
- is related to
-
-
- Closed
-
Activity
michaelkebe
added a comment - I can reproduce it on Windows. On Unix (Solaris) it works fine.
The problem is the intepretation of "," of Windows' cmd.exe:
> D:\workspace\project>ant -Dfoo=bar,baz
> Buildfile: build.xml
>
> BUILD FAILED
> Target "baz" does not exist in the project
>
> Total time: 5 seconds
> D:\workspace\project>ant "-Dfoo=bar,baz"
WORKS
> D:\workspace\project>ant -Dfoo="bar,baz"
WORKS
But fixing this by just surrounding the "-D" arguments with " is not a real fix,
because if the property contains " you have to escape them. But only on
Windows... Quite complicated...
Ant.java:
...
for (Entry<Object,Object> entry : p.entrySet()) {
args.add("-D" + entry.getKey() + "='" + entry.getValue());
}
...
michaelkebe
added a comment - I can reproduce it on Windows. On Unix (Solaris) it works fine.
The problem is the intepretation of "," of Windows' cmd.exe:
> D:\workspace\project>ant -Dfoo=bar,baz
> Buildfile: build.xml
>
> BUILD FAILED
> Target "baz" does not exist in the project
>
> Total time: 5 seconds
> D:\workspace\project>ant "-Dfoo=bar,baz"
WORKS
> D:\workspace\project>ant -Dfoo="bar,baz"
WORKS
But fixing this by just surrounding the "-D" arguments with " is not a real fix,
because if the property contains " you have to escape them. But only on
Windows... Quite complicated...
Ant.java:
...
for (Entry<Object,Object> entry : p.entrySet()) {
args.add("-D" + entry.getKey() + "='" + entry.getValue());
}
... 
Kirill Evstigneev
added a comment - Hudson 1.370 has changed Ant args quoting. So the above workaround doesn't work anymore.
For
foo="bar,baz"
Ant command line is
cmd.exe /C '"ant.bat "-Dfoo=""bar,baz""" && exit %%ERRORLEVEL%%"'
and foo gets
"bar,baz"
value (including quotes).
For
foo=bar,baz
Ant command line is
cmd.exe /C '"ant.bat -Dfoo=bar,baz && exit %%ERRORLEVEL%%"'
and the command fails.
But for
foo=bar, baz
(with space) Ant command line is
cmd.exe /C '"ant.bat "-Dfoo=bar, baz" && exit %%ERRORLEVEL%%"'
and foo gets
bar, baz
value. Not a workaround too.
Kirill Evstigneev
added a comment - Hudson 1.370 has changed Ant args quoting. So the above workaround doesn't work anymore.
For
foo="bar,baz"
Ant command line is
cmd.exe /C '"ant.bat "-Dfoo=""bar,baz""" && exit %%ERRORLEVEL%%"'
and foo gets
"bar,baz"
value (including quotes).
For
foo=bar,baz
Ant command line is
cmd.exe /C '"ant.bat -Dfoo=bar,baz && exit %%ERRORLEVEL%%"'
and the command fails.
But for
foo=bar, baz
(with space) Ant command line is
cmd.exe /C '"ant.bat "-Dfoo=bar, baz" && exit %%ERRORLEVEL%%"'
and foo gets
bar, baz
value. Not a workaround too. what will windows come up with next.. when I did the escaping changes it didn't even occur to me that comma might be a character needing escaping.
Code changed in hudson
User: : mindless
Path:
trunk/hudson/main/core/src/main/java/hudson/util/ArgumentListBuilder.java
trunk/hudson/main/core/src/test/java/hudson/util/ArgumentListBuilderTest.java
trunk/www/changelog.html
http://jenkins-ci.org/commit/34229
Log:
[FIXED JENKINS-2149] add comma to list of characters that need escaping on windows
Integrated in 
hudson_main_trunk #235
[FIXED JENKINS-2149] add comma to list of characters that need escaping on windows
mindless :
Files :
- /trunk/hudson/main/core/src/test/java/hudson/util/ArgumentListBuilderTest.java
- /trunk/www/changelog.html
- /trunk/hudson/main/core/src/main/java/hudson/util/ArgumentListBuilder.java
ssplett
added a comment - Whew!
After updating to Hudson 1.375 I got problems with my Ant targets like:
– prepareSTX, prepareFKC
because Ant told me that there was no target "prepareSTX,"
I'd to change my configuration to:
– preapreSTX prepareFKC
(Just in the case someone'r getting the same problem)
ssplett
added a comment - Whew!
After updating to Hudson 1.375 I got problems with my Ant targets like:
– prepareSTX, prepareFKC
because Ant told me that there was no target "prepareSTX,"
I'd to change my configuration to:
– preapreSTX prepareFKC
(Just in the case someone'r getting the same problem) 
I couldn't reproduce the problem. Any chance you can write a test case for us?