Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-21511

Cppncss graph is not painted when Treshold values are empty

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Major Major
    • cppncss-plugin
    • None

      There is a java.lang.NullPointerException in GraphHelper.java if functionCcnViolationThreshold and functionNcssViolationThreshold are not defined in job configuration (When the 2 treshold fields associated with cppncss configuration are empty which is the default)
      The result is that the cppncss graph is not painted

          [JENKINS-21511] Cppncss graph is not painted when Treshold values are empty

          Arno Moonen added a comment -

          I'm also seeing this behavior.

          Arno Moonen added a comment - I'm also seeing this behavior.

          Arno Moonen added a comment -

          Added PR on GitHub to fix this issue: https://github.com/jenkinsci/cppncss-plugin/pull/1

          Arno Moonen added a comment - Added PR on GitHub to fix this issue: https://github.com/jenkinsci/cppncss-plugin/pull/1

          Arno Moonen added a comment -

          Looks like the plug-in needs some more work.

          Arno Moonen added a comment - Looks like the plug-in needs some more work.

          Oleg Nenashev added a comment -

          I hit it while working on JENKINS-49237. Maybe this is also JENKINS-11436

          Oleg Nenashev added a comment - I hit it while working on JENKINS-49237 . Maybe this is also JENKINS-11436

          Oleg Nenashev added a comment -

          Oleg Nenashev added a comment - I proposed a fix in https://github.com/jenkinsci/cppncss-plugin/pull/2

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          src/main/java/hudson/plugins/helpers/GraphHelper.java
          http://jenkins-ci.org/commit/cppncss-plugin/f47bd2e6bed2befa4b01b0e810728d4f3e0628e9
          Log:
          JENKINS-21511 - Prevent NPE in Graph visualization when thresholds are not set

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: src/main/java/hudson/plugins/helpers/GraphHelper.java http://jenkins-ci.org/commit/cppncss-plugin/f47bd2e6bed2befa4b01b0e810728d4f3e0628e9 Log: JENKINS-21511 - Prevent NPE in Graph visualization when thresholds are not set

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          Jenkinsfile
          pom.xml
          src/main/java/hudson/plugins/cppncss/AbstractBuildReport.java
          src/main/java/hudson/plugins/cppncss/AbstractProjectReport.java
          src/main/java/hudson/plugins/cppncss/CppNCSSGhostwriter.java
          src/main/java/hudson/plugins/cppncss/CppNCSSHealthMetrics.java
          src/main/java/hudson/plugins/cppncss/CppNCSSPublisher.java
          src/main/java/hudson/plugins/cppncss/PluginImpl.java
          src/main/java/hudson/plugins/cppncss/parser/FormattedStatisticSummary.java
          src/main/java/hudson/plugins/cppncss/parser/Statistic.java
          src/main/java/hudson/plugins/cppncss/parser/StatisticSummary.java
          src/main/java/hudson/plugins/cppncss/parser/StatisticsResult.java
          src/main/java/hudson/plugins/cppncss/parser/StatisticsTotalResult.java
          src/main/java/hudson/plugins/cppncss/parser/StringStatisticSummary.java
          src/main/java/hudson/plugins/helpers/AbstractBuildAction.java
          src/main/java/hudson/plugins/helpers/BuildProxy.java
          src/main/java/hudson/plugins/helpers/BuildProxyCallableHelper.java
          src/main/java/hudson/plugins/helpers/GraphHelper.java
          src/main/java/hudson/plugins/helpers/health/HealthTarget.java
          src/main/resources/META-INF/hudson.remoting.ClassFilter
          src/main/resources/hudson/plugins/cppncss/AbstractBuildReport/largeGraph.jelly
          src/main/resources/hudson/plugins/cppncss/AbstractBuildReport/normalGraph.jelly
          src/main/resources/hudson/plugins/cppncss/AbstractBuildReport/reportDetail.jelly
          src/main/resources/hudson/plugins/cppncss/AbstractProjectReport/largeGraph.jelly
          src/main/resources/hudson/plugins/cppncss/AbstractProjectReport/normalGraph.jelly
          src/main/resources/hudson/plugins/cppncss/AbstractProjectReport/reportDetail.jelly
          src/main/resources/hudson/plugins/cppncss/CppNCSSPublisher/config.jelly
          src/main/resources/hudson/plugins/cppncss/parser/FormattedStatisticSummary/summary.jelly
          src/main/resources/hudson/plugins/cppncss/parser/StringStatisticSummary/summary.jelly
          src/main/resources/hudson/plugins/helpers/AbstractBuildAction/enlargedGraph.jelly
          src/main/resources/hudson/plugins/helpers/AbstractBuildAction/floatingBox.jelly
          src/main/resources/hudson/plugins/helpers/AbstractBuildAction/index.jelly
          src/main/resources/hudson/plugins/helpers/AbstractBuildAction/largeGraph.jelly
          src/main/resources/hudson/plugins/helpers/AbstractBuildAction/normalGraph.jelly
          src/main/resources/hudson/plugins/helpers/AbstractBuildAction/reportDetail.jelly
          src/main/resources/hudson/plugins/helpers/AbstractBuildAction/summary.jelly
          src/main/resources/hudson/plugins/helpers/AbstractProjectAction/enlargedGraph.jelly
          src/main/resources/hudson/plugins/helpers/AbstractProjectAction/floatingBox.jelly
          src/main/resources/hudson/plugins/helpers/AbstractProjectAction/index.jelly
          src/main/resources/hudson/plugins/helpers/AbstractProjectAction/largeGraph.jelly
          src/main/resources/hudson/plugins/helpers/AbstractProjectAction/normalGraph.jelly
          src/main/resources/hudson/plugins/helpers/AbstractProjectAction/reportDetail.jelly
          src/main/resources/index.jelly
          src/main/resources/lib/health/row.jelly
          http://jenkins-ci.org/commit/cppncss-plugin/6f6123807b2a54c607d0c77fa4279d870d105703
          Log:
          Merge pull request #2 from oleg-nenashev/JENKINS-49237-jep-200

          [JENKINS-49237/JENKINS-21511] -Facelift the code and make it compatible with Jenkins 2.102+

          Compare: https://github.com/jenkinsci/cppncss-plugin/compare/de836b18e0bf...6f6123807b2a

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: Jenkinsfile pom.xml src/main/java/hudson/plugins/cppncss/AbstractBuildReport.java src/main/java/hudson/plugins/cppncss/AbstractProjectReport.java src/main/java/hudson/plugins/cppncss/CppNCSSGhostwriter.java src/main/java/hudson/plugins/cppncss/CppNCSSHealthMetrics.java src/main/java/hudson/plugins/cppncss/CppNCSSPublisher.java src/main/java/hudson/plugins/cppncss/PluginImpl.java src/main/java/hudson/plugins/cppncss/parser/FormattedStatisticSummary.java src/main/java/hudson/plugins/cppncss/parser/Statistic.java src/main/java/hudson/plugins/cppncss/parser/StatisticSummary.java src/main/java/hudson/plugins/cppncss/parser/StatisticsResult.java src/main/java/hudson/plugins/cppncss/parser/StatisticsTotalResult.java src/main/java/hudson/plugins/cppncss/parser/StringStatisticSummary.java src/main/java/hudson/plugins/helpers/AbstractBuildAction.java src/main/java/hudson/plugins/helpers/BuildProxy.java src/main/java/hudson/plugins/helpers/BuildProxyCallableHelper.java src/main/java/hudson/plugins/helpers/GraphHelper.java src/main/java/hudson/plugins/helpers/health/HealthTarget.java src/main/resources/META-INF/hudson.remoting.ClassFilter src/main/resources/hudson/plugins/cppncss/AbstractBuildReport/largeGraph.jelly src/main/resources/hudson/plugins/cppncss/AbstractBuildReport/normalGraph.jelly src/main/resources/hudson/plugins/cppncss/AbstractBuildReport/reportDetail.jelly src/main/resources/hudson/plugins/cppncss/AbstractProjectReport/largeGraph.jelly src/main/resources/hudson/plugins/cppncss/AbstractProjectReport/normalGraph.jelly src/main/resources/hudson/plugins/cppncss/AbstractProjectReport/reportDetail.jelly src/main/resources/hudson/plugins/cppncss/CppNCSSPublisher/config.jelly src/main/resources/hudson/plugins/cppncss/parser/FormattedStatisticSummary/summary.jelly src/main/resources/hudson/plugins/cppncss/parser/StringStatisticSummary/summary.jelly src/main/resources/hudson/plugins/helpers/AbstractBuildAction/enlargedGraph.jelly src/main/resources/hudson/plugins/helpers/AbstractBuildAction/floatingBox.jelly src/main/resources/hudson/plugins/helpers/AbstractBuildAction/index.jelly src/main/resources/hudson/plugins/helpers/AbstractBuildAction/largeGraph.jelly src/main/resources/hudson/plugins/helpers/AbstractBuildAction/normalGraph.jelly src/main/resources/hudson/plugins/helpers/AbstractBuildAction/reportDetail.jelly src/main/resources/hudson/plugins/helpers/AbstractBuildAction/summary.jelly src/main/resources/hudson/plugins/helpers/AbstractProjectAction/enlargedGraph.jelly src/main/resources/hudson/plugins/helpers/AbstractProjectAction/floatingBox.jelly src/main/resources/hudson/plugins/helpers/AbstractProjectAction/index.jelly src/main/resources/hudson/plugins/helpers/AbstractProjectAction/largeGraph.jelly src/main/resources/hudson/plugins/helpers/AbstractProjectAction/normalGraph.jelly src/main/resources/hudson/plugins/helpers/AbstractProjectAction/reportDetail.jelly src/main/resources/index.jelly src/main/resources/lib/health/row.jelly http://jenkins-ci.org/commit/cppncss-plugin/6f6123807b2a54c607d0c77fa4279d870d105703 Log: Merge pull request #2 from oleg-nenashev/ JENKINS-49237 -jep-200 [JENKINS-49237/JENKINS-21511] -Facelift the code and make it compatible with Jenkins 2.102+ Compare: https://github.com/jenkinsci/cppncss-plugin/compare/de836b18e0bf...6f6123807b2a

          Oleg Nenashev added a comment -

          The fix has been released in 1.2

          Oleg Nenashev added a comment - The fix has been released in 1.2

            oleg_nenashev Oleg Nenashev
            fbonin franck bonin
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: