Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-21723

Findbugs plugin uses absolute URL for link to report

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • findbugs-plugin
    • None

      Environment:

      The jenkins findbugs plugin draws a graph with red and yellow on it for high and low priority issues.

      Clicking on this report takes me to the findbugs report.

      This link seems to use an absolute, not a relative URI.

      Bug:

      If the jenkins server is multihomed, or accessed over a socks proxy, or by any other means other than simple network access, the link does not work because the "one and only" server name is not resolvable from that client.

      Editing the browser URL appropriately to point to the client-accessible name of the jenkins server provides access to the report. Navigating within the report also works just fine.

      Solution:

      Most other links in jenkins use relative links, and so work fine. Please can this one use a relative link too.

          [JENKINS-21723] Findbugs plugin uses absolute URL for link to report

          Ulli Hafner added a comment -

          Is this still relevant? I think I needed to add more absolute links in order to get everything working with folders. Can't you just fix the URL in Jenkins configuration screen?

          Ulli Hafner added a comment - Is this still relevant? I think I needed to add more absolute links in order to get everything working with folders. Can't you just fix the URL in Jenkins configuration screen?

          Shevek . added a comment -

          Yes, it is. Everything needs to be relative as findbugs has no idea which proxies I'm accessing it through or what its authoritative name is from the perspective of the client.

          Shevek . added a comment - Yes, it is. Everything needs to be relative as findbugs has no idea which proxies I'm accessing it through or what its authoritative name is from the perspective of the client.

          Mark Waite added a comment - - edited

          I've seen the problem as well. I use a putty provided ssh tunnel to reach from the public internet to my Jenkins server inside my firewall. When I access http://localhost:8085/, the ssh tunnel takes me to http://mark-pc1.markwaite.net:8080/ The tunneling works, but it confuses the navigation in the findbugs plugin.

          Mark Waite added a comment - - edited I've seen the problem as well. I use a putty provided ssh tunnel to reach from the public internet to my Jenkins server inside my firewall. When I access http://localhost:8085/ , the ssh tunnel takes me to http://mark-pc1.markwaite.net:8080/ The tunneling works, but it confuses the navigation in the findbugs plugin.

          Shevek . added a comment -

          Yes, ssh tunnelling via localhost is one of our primary access methods too.

          Shevek . added a comment - Yes, ssh tunnelling via localhost is one of our primary access methods too.

          Ulli Hafner added a comment -

          The interesting question is if the absolute URL still could be computed correctly with the information available in Jenkins.

          Do the columns navigate to the correct URL in your setup? See JENKINS-24436. I'm not sure if there is a way to fix both issues.

          Ulli Hafner added a comment - The interesting question is if the absolute URL still could be computed correctly with the information available in Jenkins. Do the columns navigate to the correct URL in your setup? See JENKINS-24436 . I'm not sure if there is a way to fix both issues.

          Ulli Hafner added a comment - - edited

          Does the column that links to the latest stable build work? It also uses an absolute URL: https://github.com/jenkinsci/jenkins/blob/master/core/src/main/resources/hudson/views/LastStableColumn/column.jelly

          Ulli Hafner added a comment - - edited Does the column that links to the latest stable build work? It also uses an absolute URL: https://github.com/jenkinsci/jenkins/blob/master/core/src/main/resources/hudson/views/LastStableColumn/column.jelly

          Mark Waite added a comment -

          In my ssh tunnel environment, when I add a column to my view for "Last Stable", it works fine through the ssh tunnel.

          Mark Waite added a comment - In my ssh tunnel environment, when I add a column to my view for "Last Stable", it works fine through the ssh tunnel.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Ulli Hafner Path: analysis-core http://jenkins-ci.org/commit/analysis-suite-plugin/4de7016230755de965d455bf30210ef348e1aeb9 Log: JENKINS-21723 Use relative links in trend graphs. Compare: https://github.com/jenkinsci/analysis-suite-plugin/compare/aae7bc3ef2a3...4de701623075

          Code changed in jenkins
          User: Ulli Hafner
          Path:
          src/main/java/hudson/plugins/analysis/graph/BuildResultGraph.java
          src/main/java/hudson/plugins/analysis/graph/GraphConfigurationView.java
          http://jenkins-ci.org/commit/analysis-core-plugin/cb09e772d7afdb8b7a6a6ac1de04174045713593
          Log:
          JENKINS-21723 Use relative links in trend graphs.

          Compare: https://github.com/jenkinsci/analysis-core-plugin/compare/54244a7452b4...cb09e772d7af

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Ulli Hafner Path: src/main/java/hudson/plugins/analysis/graph/BuildResultGraph.java src/main/java/hudson/plugins/analysis/graph/GraphConfigurationView.java http://jenkins-ci.org/commit/analysis-core-plugin/cb09e772d7afdb8b7a6a6ac1de04174045713593 Log: JENKINS-21723 Use relative links in trend graphs. Compare: https://github.com/jenkinsci/analysis-core-plugin/compare/54244a7452b4...cb09e772d7af

          Code changed in jenkins
          User: Ulli Hafner
          Path:
          src/test/java/plugins/AbstractAnalysisTest.java
          src/test/java/plugins/CheckStylePluginTest.java
          src/test/java/plugins/FindbugsPluginTest.java
          src/test/java/plugins/PmdPluginTest.java
          http://jenkins-ci.org/commit/acceptance-test-harness/85dfc48df9dcdb0164d4f2d47d188841b8a8e4a7
          Log:
          JENKINS-21723 Use relative links in trend graphs.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Ulli Hafner Path: src/test/java/plugins/AbstractAnalysisTest.java src/test/java/plugins/CheckStylePluginTest.java src/test/java/plugins/FindbugsPluginTest.java src/test/java/plugins/PmdPluginTest.java http://jenkins-ci.org/commit/acceptance-test-harness/85dfc48df9dcdb0164d4f2d47d188841b8a8e4a7 Log: JENKINS-21723 Use relative links in trend graphs.

            drulli Ulli Hafner
            shevek Shevek .
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: