• Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • core
    • None

      In IE8 any tables with class sortable are not sortable.

          [JENKINS-21729] Table sorting does not work in IE8

          Adam Nafke added a comment -

          Adam Nafke added a comment - Fixed here: https://github.com/jenkinsci/jenkins/pull/1098

          Code changed in jenkins
          User: anafke
          Path:
          changelog.html
          war/src/main/webapp/scripts/sortable.js
          http://jenkins-ci.org/commit/jenkins/6566a0c7f9418469281f68cf243ca15d0ec32e95
          Log:
          [FIXED JENKINS-21729] Fix IE8 NPE with respect to sortability

          IE8 (and I assume other browsers that use a doctype pre-html5) interpret the span outside of the link, as in HTML4.01 you needed the closing tag.
          http://www.w3.org/TR/REC-html40/struct/global.html#h-7.5.4

          The code was causing a NPE in IE8 and users could not sort the columns.

          >> cell.innerHTML = '<a href="#" class="sortheader">'this.getInnerText(cell)'<span class="sortarrow" /></a>';

          >> cell.innerHTML ;
          "<A class=sortheader href="#"> S<SPAN class=sortarrow></A></SPAN>"

          >> cell.innerHTML = '<a href="#" class="sortheader">'this.getInnerText(cell)'<span class="sortarrow"></span></a>'

          >> cell.innerHTML ;
          "<A class=sortheader href="#"> S<SPAN class=sortarrow></SPAN></A>"

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: anafke Path: changelog.html war/src/main/webapp/scripts/sortable.js http://jenkins-ci.org/commit/jenkins/6566a0c7f9418469281f68cf243ca15d0ec32e95 Log: [FIXED JENKINS-21729] Fix IE8 NPE with respect to sortability IE8 (and I assume other browsers that use a doctype pre-html5) interpret the span outside of the link, as in HTML4.01 you needed the closing tag. http://www.w3.org/TR/REC-html40/struct/global.html#h-7.5.4 The code was causing a NPE in IE8 and users could not sort the columns. >> cell.innerHTML = '<a href="#" class="sortheader">' this.getInnerText(cell) '<span class="sortarrow" /></a>'; >> cell.innerHTML ; "<A class=sortheader href="#"> S<SPAN class=sortarrow></A></SPAN>" >> cell.innerHTML = '<a href="#" class="sortheader">' this.getInnerText(cell) '<span class="sortarrow"></span></a>' >> cell.innerHTML ; "<A class=sortheader href="#"> S<SPAN class=sortarrow></SPAN></A>"

          dogfood added a comment -

          Integrated in jenkins_main_trunk #3324
          [FIXED JENKINS-21729] Fix IE8 NPE with respect to sortability (Revision 6566a0c7f9418469281f68cf243ca15d0ec32e95)

          Result = SUCCESS
          kohsuke : 6566a0c7f9418469281f68cf243ca15d0ec32e95
          Files :

          • war/src/main/webapp/scripts/sortable.js
          • changelog.html

          dogfood added a comment - Integrated in jenkins_main_trunk #3324 [FIXED JENKINS-21729] Fix IE8 NPE with respect to sortability (Revision 6566a0c7f9418469281f68cf243ca15d0ec32e95) Result = SUCCESS kohsuke : 6566a0c7f9418469281f68cf243ca15d0ec32e95 Files : war/src/main/webapp/scripts/sortable.js changelog.html

            anafke Adam Nafke
            anafke Adam Nafke
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: