Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-22001

Do not solve JENKINS-19446 by delivering events asynchronously

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      As I wrote there:

      The current fix is just no good. It delivers events asynchronously, which makes the system unpredictable, and ruins functional tests.
      Better IMHO would be to call just save() asynchronously.

        Attachments

          Issue Links

            Activity

            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            src/test/java/com/cloudbees/hudson/plugins/folder/FolderTest.java
            http://jenkins-ci.org/commit/cloudbees-folder-plugin/a8117f59702e8a2ccdf3a9720924718b508b9b83
            Log:
            Updating comment to note JENKINS-22001.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: src/test/java/com/cloudbees/hudson/plugins/folder/FolderTest.java http://jenkins-ci.org/commit/cloudbees-folder-plugin/a8117f59702e8a2ccdf3a9720924718b508b9b83 Log: Updating comment to note JENKINS-22001 .
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            core/src/main/java/hudson/model/AbstractItem.java
            core/src/main/java/hudson/model/Job.java
            test/src/test/java/hudson/model/ListViewTest.java
            http://jenkins-ci.org/commit/jenkins/00d27176f3a452e38bd0caafebe78c7bc2fa822f
            Log:
            [FIXED JENKINS-22001] Simpler fix of JENKINS-19446 that does not introduce asynchronous behavior.

            Compare: https://github.com/jenkinsci/jenkins/compare/334ce1be691c...00d27176f3a4

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: core/src/main/java/hudson/model/AbstractItem.java core/src/main/java/hudson/model/Job.java test/src/test/java/hudson/model/ListViewTest.java http://jenkins-ci.org/commit/jenkins/00d27176f3a452e38bd0caafebe78c7bc2fa822f Log: [FIXED JENKINS-22001] Simpler fix of JENKINS-19446 that does not introduce asynchronous behavior. Compare: https://github.com/jenkinsci/jenkins/compare/334ce1be691c...00d27176f3a4
            Hide
            dogfood dogfood added a comment -

            Integrated in jenkins_main_trunk #3204
            [FIXED JENKINS-22001] Simpler fix of JENKINS-19446 that does not introduce asynchronous behavior. (Revision 00d27176f3a452e38bd0caafebe78c7bc2fa822f)

            Result = SUCCESS
            Jesse Glick : 00d27176f3a452e38bd0caafebe78c7bc2fa822f
            Files :

            • test/src/test/java/hudson/model/ListViewTest.java
            • core/src/main/java/hudson/model/AbstractItem.java
            • core/src/main/java/hudson/model/Job.java
            Show
            dogfood dogfood added a comment - Integrated in jenkins_main_trunk #3204 [FIXED JENKINS-22001] Simpler fix of JENKINS-19446 that does not introduce asynchronous behavior. (Revision 00d27176f3a452e38bd0caafebe78c7bc2fa822f) Result = SUCCESS Jesse Glick : 00d27176f3a452e38bd0caafebe78c7bc2fa822f Files : test/src/test/java/hudson/model/ListViewTest.java core/src/main/java/hudson/model/AbstractItem.java core/src/main/java/hudson/model/Job.java
            Hide
            danielbeck Daniel Beck added a comment -

            @Jesse: Shouldn't this be closed?

            Show
            danielbeck Daniel Beck added a comment - @Jesse: Shouldn't this be closed?
            Hide
            jglick Jesse Glick added a comment -

            Yes, JIRA link daemon must have been down.

            Show
            jglick Jesse Glick added a comment - Yes, JIRA link daemon must have been down.

              People

              Assignee:
              jglick Jesse Glick
              Reporter:
              jglick Jesse Glick
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: