Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-22075

NPE in CustomToolInstallWrapper.decorateLauncher()

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Major Major
    • customtools-plugin
    • None
    • RHEL5, installed via rpm

      Started getting a stack trace on project using custom tool plugin

      FATAL: null
      java.lang.NullPointerException
      at com.cloudbees.jenkins.plugins.customtools.CustomToolInstallWrapper.decorateLauncher(CustomToolInstallWrapper.java:162)
      at hudson.model.AbstractBuild$AbstractBuildExecution.createLauncher(AbstractBuild.java:631)
      at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:543)
      at hudson.model.Run.execute(Run.java:1670)
      at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:46)
      at hudson.model.ResourceController.execute(ResourceController.java:88)
      at hudson.model.Executor.run(Executor.java:231)

          [JENKINS-22075] NPE in CustomToolInstallWrapper.decorateLauncher()

          Ben Mathews added a comment -

          This is with v 0.4.1 of the plugin and 1.552 of jenkins

          Ben Mathews added a comment - This is with v 0.4.1 of the plugin and 1.552 of jenkins

          Oleg Nenashev added a comment - - edited

          Could you provide some info about your job and tools configuration?
          The issue may appear if you rename a tool (see JENKINS-18814)

          Oleg Nenashev added a comment - - edited Could you provide some info about your job and tools configuration? The issue may appear if you rename a tool (see JENKINS-18814 )

          Oleg Nenashev added a comment -

          Oleg Nenashev added a comment - The issue should be solved by https://github.com/jenkinsci/customtools-plugin/pull/15

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          src/main/java/com/cloudbees/jenkins/plugins/customtools/CustomTool.java
          src/main/java/com/cloudbees/jenkins/plugins/customtools/CustomToolInstallWrapper.java
          src/main/java/com/synopsys/arc/jenkinsci/plugins/customtools/versions/ToolVersionConfig.java
          src/main/java/com/synopsys/arc/jenkinsci/plugins/customtools/versions/ToolVersionHelper.java
          src/main/java/com/synopsys/arc/jenkinsci/plugins/customtools/versions/ToolVersionParameterDefinition.java
          src/main/resources/com/synopsys/arc/jenkinsci/plugins/customtools/Messages.properties
          http://jenkins-ci.org/commit/customtools-plugin/3d1f96edfb3b488738b2409c99395cf15a3dbf18
          Log:
          JENKINS-22075 - Advanced null checks for missing tools (not finished)

          Added checks of non-existent tools to the most of handlers

          Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: src/main/java/com/cloudbees/jenkins/plugins/customtools/CustomTool.java src/main/java/com/cloudbees/jenkins/plugins/customtools/CustomToolInstallWrapper.java src/main/java/com/synopsys/arc/jenkinsci/plugins/customtools/versions/ToolVersionConfig.java src/main/java/com/synopsys/arc/jenkinsci/plugins/customtools/versions/ToolVersionHelper.java src/main/java/com/synopsys/arc/jenkinsci/plugins/customtools/versions/ToolVersionParameterDefinition.java src/main/resources/com/synopsys/arc/jenkinsci/plugins/customtools/Messages.properties http://jenkins-ci.org/commit/customtools-plugin/3d1f96edfb3b488738b2409c99395cf15a3dbf18 Log: JENKINS-22075 - Advanced null checks for missing tools (not finished) Added checks of non-existent tools to the most of handlers Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          src/main/java/com/cloudbees/jenkins/plugins/customtools/CustomToolInstallWrapper.java
          http://jenkins-ci.org/commit/customtools-plugin/593b16cb1798d888f90288f02b366c64bb82692d
          Log:
          JENKINS-22075 - Properly handle missing tools in CustomToolInstallWrapper

          Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: src/main/java/com/cloudbees/jenkins/plugins/customtools/CustomToolInstallWrapper.java http://jenkins-ci.org/commit/customtools-plugin/593b16cb1798d888f90288f02b366c64bb82692d Log: JENKINS-22075 - Properly handle missing tools in CustomToolInstallWrapper Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          src/main/java/com/cloudbees/jenkins/plugins/customtools/CustomTool.java
          src/main/java/com/cloudbees/jenkins/plugins/customtools/CustomToolInstallWrapper.java
          src/main/java/com/synopsys/arc/jenkinsci/plugins/customtools/CustomToolsLogger.java
          src/main/java/com/synopsys/arc/jenkinsci/plugins/customtools/EnvVariablesInjector.java
          src/main/java/com/synopsys/arc/jenkinsci/plugins/customtools/LabelSpecifics.java
          src/main/java/com/synopsys/arc/jenkinsci/plugins/customtools/PathsList.java
          src/main/java/com/synopsys/arc/jenkinsci/plugins/customtools/versions/ToolVersionConfig.java
          src/main/java/com/synopsys/arc/jenkinsci/plugins/customtools/versions/ToolVersionHelper.java
          src/main/java/com/synopsys/arc/jenkinsci/plugins/customtools/versions/ToolVersionParameterDefinition.java
          src/main/resources/com/cloudbees/jenkins/plugins/customtools/Messages.properties
          src/main/resources/com/synopsys/arc/jenkinsci/plugins/customtools/Messages.properties
          src/test/java/com/cloudbees/jenkins/plugins/customtools/CustomToolInstallWrapperTest.java
          src/test/java/com/synopsys/arc/jenkins/plugins/customtools/util/StubWrapper.java
          http://jenkins-ci.org/commit/customtools-plugin/f502329e1a5953834ea35cc76475f4709f345373
          Log:
          Merge pull request #15 from synopsys-arc-oss/master

          [JENKINS-18814,JENKINS-22075] - Handling of deleted tools

          Compare: https://github.com/jenkinsci/customtools-plugin/compare/c7217ae0f2f6...f502329e1a59

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: src/main/java/com/cloudbees/jenkins/plugins/customtools/CustomTool.java src/main/java/com/cloudbees/jenkins/plugins/customtools/CustomToolInstallWrapper.java src/main/java/com/synopsys/arc/jenkinsci/plugins/customtools/CustomToolsLogger.java src/main/java/com/synopsys/arc/jenkinsci/plugins/customtools/EnvVariablesInjector.java src/main/java/com/synopsys/arc/jenkinsci/plugins/customtools/LabelSpecifics.java src/main/java/com/synopsys/arc/jenkinsci/plugins/customtools/PathsList.java src/main/java/com/synopsys/arc/jenkinsci/plugins/customtools/versions/ToolVersionConfig.java src/main/java/com/synopsys/arc/jenkinsci/plugins/customtools/versions/ToolVersionHelper.java src/main/java/com/synopsys/arc/jenkinsci/plugins/customtools/versions/ToolVersionParameterDefinition.java src/main/resources/com/cloudbees/jenkins/plugins/customtools/Messages.properties src/main/resources/com/synopsys/arc/jenkinsci/plugins/customtools/Messages.properties src/test/java/com/cloudbees/jenkins/plugins/customtools/CustomToolInstallWrapperTest.java src/test/java/com/synopsys/arc/jenkins/plugins/customtools/util/StubWrapper.java http://jenkins-ci.org/commit/customtools-plugin/f502329e1a5953834ea35cc76475f4709f345373 Log: Merge pull request #15 from synopsys-arc-oss/master [JENKINS-18814,JENKINS-22075] - Handling of deleted tools Compare: https://github.com/jenkinsci/customtools-plugin/compare/c7217ae0f2f6...f502329e1a59

          Oleg Nenashev added a comment -

          Sorry, I've forgot to release the plugin...
          Hope to do it on the weekend

          Oleg Nenashev added a comment - Sorry, I've forgot to release the plugin... Hope to do it on the weekend

          Oleg Nenashev added a comment -

          The issue has been fixed in 0.4.1

          Oleg Nenashev added a comment - The issue has been fixed in 0.4.1

            oleg_nenashev Oleg Nenashev
            benm Ben Mathews
            Votes:
            1 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: