Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-22131

Extract generic features from AbstractProject/AbstractBuild

    XMLWordPrintable

    Details

    • Type: New Feature
    • Status: Resolved (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Component/s: core
    • Labels:
    • Similar Issues:

      Description

      Specialized job types such as are defined in async-job-plugin, branch-api-plugin, or external-monitor-job-plugin do not extend AbstractProject / AbstractBuild because these classes make very specific assumptions about build semantics: that you have a CI job (SCM), an assigned workspace, and so on. Yet without extending those classes you currently have a hard time picking up generic features like

      • parameter definitions
      • trigger definitions
      • manual or REST build causes
      • lazy-loading of runs

      Those features should be decoupled so that they are available à la carte for other Job / Run types.

        Attachments

          Issue Links

            Activity

            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            changelog.html
            core/src/main/java/hudson/model/ParameterValue.java
            core/src/main/java/hudson/model/Run.java
            core/src/main/java/jenkins/model/ParameterizedJobMixIn.java
            core/src/main/java/jenkins/model/lazy/LazyBuildMixIn.java
            http://jenkins-ci.org/commit/jenkins/17c4c1f50785313416203714579018f53f043858
            Log:
            [FIXED JENKINS-22131] Merged deconstructing-AbstractProject branch from #1146.

            Compare: https://github.com/jenkinsci/jenkins/compare/f04b0e011a94...17c4c1f50785

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: changelog.html core/src/main/java/hudson/model/ParameterValue.java core/src/main/java/hudson/model/Run.java core/src/main/java/jenkins/model/ParameterizedJobMixIn.java core/src/main/java/jenkins/model/lazy/LazyBuildMixIn.java http://jenkins-ci.org/commit/jenkins/17c4c1f50785313416203714579018f53f043858 Log: [FIXED JENKINS-22131] Merged deconstructing-AbstractProject branch from #1146. Compare: https://github.com/jenkinsci/jenkins/compare/f04b0e011a94...17c4c1f50785
            Hide
            dogfood dogfood added a comment -

            Integrated in jenkins_main_trunk #3233
            [FIXED JENKINS-22131] Merged deconstructing-AbstractProject branch from #1146. (Revision 17c4c1f50785313416203714579018f53f043858)

            Result = UNSTABLE
            Jesse Glick : 17c4c1f50785313416203714579018f53f043858
            Files :

            • core/src/main/java/jenkins/model/ParameterizedJobMixIn.java
            • core/src/main/java/hudson/model/Run.java
            • core/src/main/java/jenkins/model/lazy/LazyBuildMixIn.java
            • changelog.html
            • core/src/main/java/hudson/model/ParameterValue.java
            Show
            dogfood dogfood added a comment - Integrated in jenkins_main_trunk #3233 [FIXED JENKINS-22131] Merged deconstructing-AbstractProject branch from #1146. (Revision 17c4c1f50785313416203714579018f53f043858) Result = UNSTABLE Jesse Glick : 17c4c1f50785313416203714579018f53f043858 Files : core/src/main/java/jenkins/model/ParameterizedJobMixIn.java core/src/main/java/hudson/model/Run.java core/src/main/java/jenkins/model/lazy/LazyBuildMixIn.java changelog.html core/src/main/java/hudson/model/ParameterValue.java
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            core/src/main/java/jenkins/model/ParameterizedJobMixIn.java
            http://jenkins-ci.org/commit/jenkins/a1cd49b948abfae15d11d068fddb8095aa37fae4
            Log:
            JENKINS-22131 Forgot to use a job’s configured quiet period when not otherwise specified.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: core/src/main/java/jenkins/model/ParameterizedJobMixIn.java http://jenkins-ci.org/commit/jenkins/a1cd49b948abfae15d11d068fddb8095aa37fae4 Log: JENKINS-22131 Forgot to use a job’s configured quiet period when not otherwise specified.
            Hide
            dogfood dogfood added a comment -

            Integrated in jenkins_main_trunk #3295
            JENKINS-22131 Forgot to use a job’s configured quiet period when not otherwise specified. (Revision a1cd49b948abfae15d11d068fddb8095aa37fae4)

            Result = SUCCESS
            Jesse Glick : a1cd49b948abfae15d11d068fddb8095aa37fae4
            Files :

            • core/src/main/java/jenkins/model/ParameterizedJobMixIn.java
            Show
            dogfood dogfood added a comment - Integrated in jenkins_main_trunk #3295 JENKINS-22131 Forgot to use a job’s configured quiet period when not otherwise specified. (Revision a1cd49b948abfae15d11d068fddb8095aa37fae4) Result = SUCCESS Jesse Glick : a1cd49b948abfae15d11d068fddb8095aa37fae4 Files : core/src/main/java/jenkins/model/ParameterizedJobMixIn.java

              People

              Assignee:
              jglick Jesse Glick
              Reporter:
              jglick Jesse Glick
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: