copy-job checks CREATE on Jenkins root, when it only needs to do so on the actual target of the copy. Also it fails to check EXTENDED_READ on the source.

      create-job also checks CREATE needlessly on root.

          [JENKINS-22262] copy-job permission checks wrong

          Code changed in jenkins
          User: Jesse Glick
          Path:
          changelog.html
          core/src/main/java/hudson/cli/CopyJobCommand.java
          core/src/main/java/hudson/cli/CreateJobCommand.java
          core/src/main/java/hudson/model/ItemGroupMixIn.java
          test/src/test/java/hudson/cli/CopyJobCommandTest.java
          test/src/test/java/hudson/cli/CreateJobCommandTest.java
          http://jenkins-ci.org/commit/jenkins/8861563bd1e7fc28c5686f0dc9552529cfdfbf45
          Log:
          [FIXED JENKINS-22262] CopyJobCommand and CreateJobCommand were doing incorrect permission checks.

          Compare: https://github.com/jenkinsci/jenkins/compare/aaa50018eef1...8861563bd1e7

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: changelog.html core/src/main/java/hudson/cli/CopyJobCommand.java core/src/main/java/hudson/cli/CreateJobCommand.java core/src/main/java/hudson/model/ItemGroupMixIn.java test/src/test/java/hudson/cli/CopyJobCommandTest.java test/src/test/java/hudson/cli/CreateJobCommandTest.java http://jenkins-ci.org/commit/jenkins/8861563bd1e7fc28c5686f0dc9552529cfdfbf45 Log: [FIXED JENKINS-22262] CopyJobCommand and CreateJobCommand were doing incorrect permission checks. Compare: https://github.com/jenkinsci/jenkins/compare/aaa50018eef1...8861563bd1e7

          dogfood added a comment -

          Integrated in jenkins_main_trunk #3243
          [FIXED JENKINS-22262] CopyJobCommand and CreateJobCommand were doing incorrect permission checks. (Revision 8861563bd1e7fc28c5686f0dc9552529cfdfbf45)

          Result = SUCCESS
          Jesse Glick : 8861563bd1e7fc28c5686f0dc9552529cfdfbf45
          Files :

          • core/src/main/java/hudson/cli/CreateJobCommand.java
          • test/src/test/java/hudson/cli/CreateJobCommandTest.java
          • changelog.html
          • test/src/test/java/hudson/cli/CopyJobCommandTest.java
          • core/src/main/java/hudson/model/ItemGroupMixIn.java
          • core/src/main/java/hudson/cli/CopyJobCommand.java

          dogfood added a comment - Integrated in jenkins_main_trunk #3243 [FIXED JENKINS-22262] CopyJobCommand and CreateJobCommand were doing incorrect permission checks. (Revision 8861563bd1e7fc28c5686f0dc9552529cfdfbf45) Result = SUCCESS Jesse Glick : 8861563bd1e7fc28c5686f0dc9552529cfdfbf45 Files : core/src/main/java/hudson/cli/CreateJobCommand.java test/src/test/java/hudson/cli/CreateJobCommandTest.java changelog.html test/src/test/java/hudson/cli/CopyJobCommandTest.java core/src/main/java/hudson/model/ItemGroupMixIn.java core/src/main/java/hudson/cli/CopyJobCommand.java

            jglick Jesse Glick
            jglick Jesse Glick
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: