Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-22311

Large number of build parameters for pending jobs (e.g.gerrit triggered job) can cause unwieldy build history

      If Gerrit triggers create a queue in the Pending Jobs column in the project page, it will insert build parameters/metadata about the trigger: GERRIT_EVENT_TYPE, GERRIT_EVENT_HASH, etc.

      If this metadata is long, it will distort the project page to be visually unusable.

      Would like a way to either turn of or truncate this display of Gerrit metadata.

          [JENKINS-22311] Large number of build parameters for pending jobs (e.g.gerrit triggered job) can cause unwieldy build history

          Joshua Kugler added a comment -

          @Ian Norton:

          Where is that CSS patch applied?

          Joshua Kugler added a comment - @Ian Norton: Where is that CSS patch applied?

          Tom FENNELLY added a comment -

          I am working on something that should help resolve this issue: https://github.com/jenkinsci/jenkins/pull/1466

          CSS on it's own will not fix this in a cross browser way (word-wrap is not supported everywhere). For that reason, I ended up adding a bit of javascript that inserts breaks (zero-width spaces) in long non-whitespace char sequences. The history is still going to look nuts if there are crazy long build names (as in the screenshot on this ticket), but at least the history table should maintain it's structure.

          Tom FENNELLY added a comment - I am working on something that should help resolve this issue: https://github.com/jenkinsci/jenkins/pull/1466 CSS on it's own will not fix this in a cross browser way (word-wrap is not supported everywhere). For that reason, I ended up adding a bit of javascript that inserts breaks (zero-width spaces) in long non-whitespace char sequences. The history is still going to look nuts if there are crazy long build names (as in the screenshot on this ticket), but at least the history table should maintain it's structure.

          Tom FENNELLY added a comment -

          @Daniel I'm sure there'll be someone out there that "like" the params being always visible, but I think adding them as a tooltip makes sense for the vast majority of people.

          Tom FENNELLY added a comment - @Daniel I'm sure there'll be someone out there that "like" the params being always visible, but I think adding them as a tooltip makes sense for the vast majority of people.

          Vlad Aginsky added a comment -

          Hi all, this is quite disturbing,
          I see https://github.com/jenkinsci/jenkins/pull/1470 (actual pull request) is merged, is it released already?

          Vlad Aginsky added a comment - Hi all, this is quite disturbing, I see https://github.com/jenkinsci/jenkins/pull/1470 (actual pull request) is merged, is it released already?

          Daniel Beck added a comment -

          Released in 1.593.

          Daniel Beck added a comment - Released in 1.593.

          Code changed in jenkins
          User: Daniel Beck
          Path:
          core/src/main/resources/hudson/widgets/BuildHistoryWidget/entries.jelly
          http://jenkins-ci.org/commit/jenkins/44e6b5d76211bc40e1a608ae3aa93c083befaeba
          Log:
          [FIXED JENKINS-22311] Show queue item parameters in tool tip

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Daniel Beck Path: core/src/main/resources/hudson/widgets/BuildHistoryWidget/entries.jelly http://jenkins-ci.org/commit/jenkins/44e6b5d76211bc40e1a608ae3aa93c083befaeba Log: [FIXED JENKINS-22311] Show queue item parameters in tool tip

          Code changed in jenkins
          User: Jesse Glick
          Path:
          changelog.html
          core/src/main/resources/hudson/widgets/BuildHistoryWidget/entries.jelly
          http://jenkins-ci.org/commit/jenkins/7ef3d0bbf0f5250ac28797193eb105a06454d904
          Log:
          JENKINS-22311 Noting merge of #1492.

          Compare: https://github.com/jenkinsci/jenkins/compare/8e5199e377c7...7ef3d0bbf0f5

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: changelog.html core/src/main/resources/hudson/widgets/BuildHistoryWidget/entries.jelly http://jenkins-ci.org/commit/jenkins/7ef3d0bbf0f5250ac28797193eb105a06454d904 Log: JENKINS-22311 Noting merge of #1492. Compare: https://github.com/jenkinsci/jenkins/compare/8e5199e377c7...7ef3d0bbf0f5

          dogfood added a comment -

          Integrated in jenkins_main_trunk #3924
          [FIXED JENKINS-22311] Show queue item parameters in tool tip (Revision 44e6b5d76211bc40e1a608ae3aa93c083befaeba)

          Result = SUCCESS
          daniel-beck : 44e6b5d76211bc40e1a608ae3aa93c083befaeba
          Files :

          • core/src/main/resources/hudson/widgets/BuildHistoryWidget/entries.jelly

          dogfood added a comment - Integrated in jenkins_main_trunk #3924 [FIXED JENKINS-22311] Show queue item parameters in tool tip (Revision 44e6b5d76211bc40e1a608ae3aa93c083befaeba) Result = SUCCESS daniel-beck : 44e6b5d76211bc40e1a608ae3aa93c083befaeba Files : core/src/main/resources/hudson/widgets/BuildHistoryWidget/entries.jelly

          Code changed in jenkins
          User: Daniel Beck
          Path:
          core/src/main/resources/hudson/widgets/BuildHistoryWidget/entries.jelly
          http://jenkins-ci.org/commit/jenkins/56795ba1f30ea9f060c9bb1e302fcff9827dd947
          Log:
          [FIXED JENKINS-22311] Show queue item parameters in tool tip

          (cherry picked from commit 44e6b5d76211bc40e1a608ae3aa93c083befaeba)

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Daniel Beck Path: core/src/main/resources/hudson/widgets/BuildHistoryWidget/entries.jelly http://jenkins-ci.org/commit/jenkins/56795ba1f30ea9f060c9bb1e302fcff9827dd947 Log: [FIXED JENKINS-22311] Show queue item parameters in tool tip (cherry picked from commit 44e6b5d76211bc40e1a608ae3aa93c083befaeba)

          dogfood added a comment -

          Integrated in jenkins_main_trunk #4292
          [FIXED JENKINS-22311] Show queue item parameters in tool tip (Revision 56795ba1f30ea9f060c9bb1e302fcff9827dd947)

          Result = UNSTABLE
          ogondza : 56795ba1f30ea9f060c9bb1e302fcff9827dd947
          Files :

          • core/src/main/resources/hudson/widgets/BuildHistoryWidget/entries.jelly

          dogfood added a comment - Integrated in jenkins_main_trunk #4292 [FIXED JENKINS-22311] Show queue item parameters in tool tip (Revision 56795ba1f30ea9f060c9bb1e302fcff9827dd947) Result = UNSTABLE ogondza : 56795ba1f30ea9f060c9bb1e302fcff9827dd947 Files : core/src/main/resources/hudson/widgets/BuildHistoryWidget/entries.jelly

            danielbeck Daniel Beck
            eric_griswold Eric Griswold
            Votes:
            9 Vote for this issue
            Watchers:
            15 Start watching this issue

              Created:
              Updated:
              Resolved: