Details
-
Type:
Bug
-
Status: Resolved (View Workflow)
-
Priority:
Minor
-
Resolution: Fixed
-
Component/s: core
-
Similar Issues:
Description
In IE 9 on Windows 7 in regular mode, pressing the Enter key does not submit forms (such as the login form) as expected. It does work in compatibility mode.
Attachments
Activity
I think we should sort YUI out properly ala JENKINS-23405. Spike, KK, Jesse?
I parked trying to sort out JENKINS-23405 for now - issues replicating the same release structure as was used to create the 2.9.0 YUI resources (which Jenkins depends on).
Pull request: https://github.com/jenkinsci/jenkins/pull/1278
Code changed in jenkins
User: tfennelly
Path:
changelog.html
war/src/main/webapp/scripts/yui/button/button-debug.js
war/src/main/webapp/scripts/yui/button/button-min.js
http://jenkins-ci.org/commit/jenkins/aa8f5955cd478d4a473f49126dad1a0efecc0e2a
Log:
JENKINS-22373 Submit on Enter key bug on IE9
Integrated in 
jenkins_main_trunk #3465
JENKINS-22373 Submit on Enter key bug on IE9 (Revision aa8f5955cd478d4a473f49126dad1a0efecc0e2a)
Result = SUCCESS
tom.fennelly : aa8f5955cd478d4a473f49126dad1a0efecc0e2a
Files :
- changelog.html
- war/src/main/webapp/scripts/yui/button/button-min.js
- war/src/main/webapp/scripts/yui/button/button-debug.js
Talked to KK about this. He was not aware that changes were being made to the YUI code. 6 have been made in total since the update to v2.9 (not including this change). See JENKINS-23405.
Re minification... it's all obfuscated so changing by hand is a last resort imo. I tried an online YUI compressor. Output is formatted differently and the obfuscation is not exactly the same, but it seems to work (pushed to the same branch if you want to look). Might be dangerous though I think? Maybe we need to fork YUI2 as suggested by KK in JENKINS-23405.