Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-22430

XFrame Filter Plugin forgets settings upon Jenkins restart

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • xframe-filter-plugin
    • CentOS 6.5
      Latest Jenkins version from repo
      Latest X-Filter Plugin installed via the Jenkins update center

      I'm using the XFrame Filter Plugin to allow Jenkins to be embedded into an iFrame. To make this work I need to set the X-Frame-Options Options configuration parameter to ALLOW-FROM http://my-address.

      This works fine but when I restart Jenkins (e.g. due to maintenance on the machine) the plugin looses the configuration and restores the value of "X-Frame-Options Options" to SAMEORIGIN which is odd because I have to re-configure the plugin after evey restart of Jenkins.

          [JENKINS-22430] XFrame Filter Plugin forgets settings upon Jenkins restart

          Marvin Kruse added a comment -

          Fixed typo

          Marvin Kruse added a comment - Fixed typo

          For now...is there some place on disk we can set it to get reloaded on restart?

          Gavin Goodrich added a comment - For now...is there some place on disk we can set it to get reloaded on restart?

          Code changed in jenkins
          User: Jesse Glick
          Path:
          src/main/java/org/jenkins/ci/plugins/xframe_filter/XFrameFilterPageDecorator.java
          src/test/java/org/jenkins/ci/plugins/xframe_filter/XFrameFilterPageDecoratorTest.java
          src/test/resources/org/jenkins/ci/plugins/xframe_filter/XFrameFilterPageDecoratorTest/configuration.zip
          http://jenkins-ci.org/commit/xframe-filter-plugin/39ca4304d4ceceeb9080638821262dcff6aa7505
          Log:
          [FIXED JENKINS-22430] Settings not loaded properly after restart.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: src/main/java/org/jenkins/ci/plugins/xframe_filter/XFrameFilterPageDecorator.java src/test/java/org/jenkins/ci/plugins/xframe_filter/XFrameFilterPageDecoratorTest.java src/test/resources/org/jenkins/ci/plugins/xframe_filter/XFrameFilterPageDecoratorTest/configuration.zip http://jenkins-ci.org/commit/xframe-filter-plugin/39ca4304d4ceceeb9080638821262dcff6aa7505 Log: [FIXED JENKINS-22430] Settings not loaded properly after restart.

            jglick Jesse Glick
            skyvalley83 Marvin Kruse
            Votes:
            5 Vote for this issue
            Watchers:
            7 Start watching this issue

              Created:
              Updated:
              Resolved: