• Type: Bug
• Resolution: Fixed
• Priority: Minor
• Component/s: xframe-filter-plugin
• Labels:

  • configuration
• Environment:

  CentOS 6.5
  Latest Jenkins version from repo
  Latest X-Filter Plugin installed via the Jenkins update center

[JENKINS-22430] XFrame Filter Plugin forgets settings upon Jenkins restart

Marvin Kruse created issue - 2014-03-31 13:12

Collapse comment: Marvin Kruse added a comment - 2014-03-31 13:16

Marvin Kruse added a comment - 2014-03-31 13:16

Fixed typo

Expand comment: Marvin Kruse added a comment - 2014-03-31 13:16

Marvin Kruse added a comment - 2014-03-31 13:16 Fixed typo

Marvin Kruse made changes - 2014-03-31 13:16

Description

Original: I'm using the XFrame Filter Plugin to allow Jenkins to be embedded into an iFrame. To make this work I need to set the X-Frame-Options Options configuration parameter to ALLOW-FORM http://my-address. This works fine but when I restart Jenkins (e.g. due to maintenance on the machine) the plugin looses the configuration and restores the value of "X-Frame-Options Options" to SAMEORIGIN which is odd because I have to re-configure the plugin after evey restart of Jenkins.

New: I'm using the XFrame Filter Plugin to allow Jenkins to be embedded into an iFrame. To make this work I need to set the X-Frame-Options Options configuration parameter to ALLOW-FROM http://my-address. This works fine but when I restart Jenkins (e.g. due to maintenance on the machine) the plugin looses the configuration and restores the value of "X-Frame-Options Options" to SAMEORIGIN which is odd because I have to re-configure the plugin after evey restart of Jenkins.

jieryn made changes - 2014-03-31 15:31

Assignee

Original: jieryn [ jieryn ]

Timm Drevensek made changes - 2014-06-30 11:57

Link

New: This issue is related to JENKINS-21881 [ JENKINS-21881 ]

Collapse comment: Gavin Goodrich added a comment - 2014-06-30 15:07

Gavin Goodrich added a comment - 2014-06-30 15:07

For now...is there some place on disk we can set it to get reloaded on restart?

Expand comment: Gavin Goodrich added a comment - 2014-06-30 15:07

Gavin Goodrich added a comment - 2014-06-30 15:07 For now...is there some place on disk we can set it to get reloaded on restart?

Jesse Glick made changes - 2014-06-30 16:50

Labels

Original: xframe

New: configuration

Jesse Glick made changes - 2014-06-30 17:00

Assignee

New: Jesse Glick [ jglick ]

Jesse Glick made changes - 2014-06-30 17:00

Status

Original: Open [ 1 ]

New: In Progress [ 3 ]

Collapse comment: SCM/JIRA link daemon added a comment - 2014-06-30 18:03

SCM/JIRA link daemon added a comment - 2014-06-30 18:03

Code changed in jenkins
User: Jesse Glick
Path:
src/main/java/org/jenkins/ci/plugins/xframe_filter/XFrameFilterPageDecorator.java
src/test/java/org/jenkins/ci/plugins/xframe_filter/XFrameFilterPageDecoratorTest.java
src/test/resources/org/jenkins/ci/plugins/xframe_filter/XFrameFilterPageDecoratorTest/configuration.zip
http://jenkins-ci.org/commit/xframe-filter-plugin/39ca4304d4ceceeb9080638821262dcff6aa7505
Log:
[FIXED JENKINS-22430] Settings not loaded properly after restart.

Expand comment: SCM/JIRA link daemon added a comment - 2014-06-30 18:03

SCM/JIRA link daemon added a comment - 2014-06-30 18:03 Code changed in jenkins User: Jesse Glick Path: src/main/java/org/jenkins/ci/plugins/xframe_filter/XFrameFilterPageDecorator.java src/test/java/org/jenkins/ci/plugins/xframe_filter/XFrameFilterPageDecoratorTest.java src/test/resources/org/jenkins/ci/plugins/xframe_filter/XFrameFilterPageDecoratorTest/configuration.zip http://jenkins-ci.org/commit/xframe-filter-plugin/39ca4304d4ceceeb9080638821262dcff6aa7505 Log: [FIXED JENKINS-22430] Settings not loaded properly after restart.

Load more newer events