-
Bug
-
Resolution: Fixed
-
Blocker
-
None
It is possible to create a job which will never end by configuring a job like:
job {
name "Test"
configure { root ->
// Please note I forgot to start with "root"
(properties / 'hudson.plugins.disk__usage.DiskUsageProperty').@plugin="disk-usage@0.23"
}
}
I did obviously a mistake in the configuration block since I start with "properties" instead of "root". Neverless it would be good if in this case the job would just fail.
JobDSL Plugin Version 1.22
[JENKINS-22708] JobDSL Plugin can produce never ending jobs (resource leak)
Daniel Spilker
added a comment - The problem is that properties collects all properties of the job object, so all getter methods get called. Unfortunately, also getXml() is called which generates the config XML for the job. And there starts the recursion because to generated the XML, all configure block will be evaluated. And the configure block will try to generated the XML which calls the configure block and so on.
As a workaround I tried to make the "Process Job DSLs" step abortable by checking the thread's interrupted flag and throwing a InterruptedException. But that didn't work because the exception is caught somewhere and never aborts the build step.
Another solution would be to rename getXml() and getNode() to createXml() and createNode(). That would change the API, but will break the recursion since properties no longer causes the XML to be generated.
Daniel Spilker
added a comment - The problem is that properties collects all properties of the job object, so all getter methods get called. Unfortunately, also getXml() is called which generates the config XML for the job. And there starts the recursion because to generated the XML, all configure block will be evaluated. And the configure block will try to generated the XML which calls the configure block and so on.
As a workaround I tried to make the "Process Job DSLs" step abortable by checking the thread's interrupted flag and throwing a InterruptedException. But that didn't work because the exception is caught somewhere and never aborts the build step.
Another solution would be to rename getXml() and getNode() to createXml() and createNode() . That would change the API, but will break the recursion since properties no longer causes the XML to be generated. Daniel Spilker
added a comment - Will be fixed in 1.26. Code changed in jenkins
User: Daniel Spilker
Path:
docs/Home.md
http://jenkins-ci.org/commit/job-dsl-plugin/bc55db2f4737cd73ff64815bbd3f455d41ce71fa
Log:
mention fix for JENKINS-22708 in release notes
Just for clarification, the JobDSL Plugin job hangs forever