[JENKINS-22818] Jenkins on Linux can not restart after plugin update - Jenkins Jira

Details

Type: Bug
Status: Resolved (View Workflow)
Priority: Critical
Resolution: Fixed
Component/s: core
Labels:
Environment:
Linux

Similar Issues:

Show

Description

Jenkins can not restart after plugin update if jenkins' java is started with 'java' and without full path.

It doesn't rexec itself with the following logs:
Warnung: Failed to restart Jenkins
java.io.IOException: Failed to exec 'java' Datei oder Verzeichnis nicht gefunden
at hudson.lifecycle.UnixLifecycle.restart(UnixLifecycle.java:84)
at jenkins.model.Jenkins$24.run(Jenkins.java:3337)

It seems to be caused by this recent change:
https://github.com/jenkinsci/jenkins/commit/547d4ed8d35de6be4b2788e4816019bb8cc94902#diff-1df54b5ad5f99455e21579688db5be50

From a quick look I guess this could be fixed by using execvp instead of execv as below:

LIBC.execv(exe, new StringArray(args.toArray(new String[args.size()])));
+ LIBC.execvp(exe, new StringArray(args.toArray(new String[args.size()])));

I understand that for those calling java as /usr/bin/java the execv approach should work, but without the full path it should still work IMHO.

Thanks,
Simon

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

UnixLifecycle.patch
0.5 kB
2014-05-08 14:55

Activity

Ascending order - Click to sort in descending order

View 5 older comments

Oleg Nenashev added a comment - 2014-05-28 06:59

Increased the bug's priority.
The issue has been introduced in 1.561, hence the LTS backporting is not required

Oleg Nenashev added a comment - 2014-05-28 06:59 Increased the bug's priority. The issue has been introduced in 1.561, hence the LTS backporting is not required

SCM/JIRA link daemon added a comment - 2014-05-28 09:04

Code changed in jenkins
User: Yoann Dubreuil
Path:
core/src/main/java/hudson/lifecycle/UnixLifecycle.java
core/src/main/java/hudson/util/jna/GNUCLibrary.java
http://jenkins-ci.org/commit/jenkins/3ddd2b0c0876239316b5cfc6bca497821bd200b8
Log:
[FIX JENKINS-22818] fix jenkins restart on Linux after plugin update if the java executable running Jenkins is started without its full path

The patch uses 'execvp' instead of 'execv' to lookup the java executable filename in the PATH if the specified filename does not contain a slash character.
Regression introduced in 547d4ed8d35de6be4b2788e4816019bb8cc94902

SCM/JIRA link daemon added a comment - 2014-05-28 09:04 Code changed in jenkins User: Yoann Dubreuil Path: core/src/main/java/hudson/lifecycle/UnixLifecycle.java core/src/main/java/hudson/util/jna/GNUCLibrary.java http://jenkins-ci.org/commit/jenkins/3ddd2b0c0876239316b5cfc6bca497821bd200b8 Log: [FIX JENKINS-22818] fix jenkins restart on Linux after plugin update if the java executable running Jenkins is started without its full path The patch uses 'execvp' instead of 'execv' to lookup the java executable filename in the PATH if the specified filename does not contain a slash character. Regression introduced in 547d4ed8d35de6be4b2788e4816019bb8cc94902

vjuranek added a comment - 2014-05-28 09:06

Should be fixed by proposed patch (PR #1239)

vjuranek added a comment - 2014-05-28 09:06 Should be fixed by proposed patch (PR #1239)

dogfood added a comment - 2014-05-28 09:58

Integrated in jenkins_main_trunk #3413
[FIX JENKINS-22818] fix jenkins restart on Linux after plugin update if the java executable running Jenkins is started without its full path (Revision 3ddd2b0c0876239316b5cfc6bca497821bd200b8)

Result = SUCCESS
Vojtech Juranek : 3ddd2b0c0876239316b5cfc6bca497821bd200b8
Files :

core/src/main/java/hudson/lifecycle/UnixLifecycle.java
core/src/main/java/hudson/util/jna/GNUCLibrary.java

dogfood added a comment - 2014-05-28 09:58 Integrated in jenkins_main_trunk #3413 [FIX JENKINS-22818] fix jenkins restart on Linux after plugin update if the java executable running Jenkins is started without its full path (Revision 3ddd2b0c0876239316b5cfc6bca497821bd200b8) Result = SUCCESS Vojtech Juranek : 3ddd2b0c0876239316b5cfc6bca497821bd200b8 Files : core/src/main/java/hudson/lifecycle/UnixLifecycle.java core/src/main/java/hudson/util/jna/GNUCLibrary.java

SCM/JIRA link daemon added a comment - 2014-07-02 22:32

Code changed in jenkins
User: Yoann Dubreuil
Path:
core/src/main/java/hudson/lifecycle/UnixLifecycle.java
core/src/main/java/hudson/util/jna/GNUCLibrary.java
http://jenkins-ci.org/commit/jenkins/c3ddea2a71d61eeed39012155a15297b0059874a
Log:
[FIX JENKINS-22818] fix jenkins restart on Linux after plugin update if the java executable running Jenkins is started without its full path

The patch uses 'execvp' instead of 'execv' to lookup the java executable filename in the PATH if the specified filename does not contain a slash character.
Regression introduced in 547d4ed8d35de6be4b2788e4816019bb8cc94902

(cherry picked from commit 3ddd2b0c0876239316b5cfc6bca497821bd200b8)

SCM/JIRA link daemon added a comment - 2014-07-02 22:32 Code changed in jenkins User: Yoann Dubreuil Path: core/src/main/java/hudson/lifecycle/UnixLifecycle.java core/src/main/java/hudson/util/jna/GNUCLibrary.java http://jenkins-ci.org/commit/jenkins/c3ddea2a71d61eeed39012155a15297b0059874a Log: [FIX JENKINS-22818] fix jenkins restart on Linux after plugin update if the java executable running Jenkins is started without its full path The patch uses 'execvp' instead of 'execv' to lookup the java executable filename in the PATH if the specified filename does not contain a slash character. Regression introduced in 547d4ed8d35de6be4b2788e4816019bb8cc94902 (cherry picked from commit 3ddd2b0c0876239316b5cfc6bca497821bd200b8)

Jenkins

Jenkins on Linux can not restart after plugin update

Details

Description

Attachments

Attachments

Activity

People

Dates