Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-2317

Patch avoiding the need for a horizontal scrollbar in the browser

    XMLWordPrintable

    Details

    • Type: Patch
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Component/s: core
    • Labels:
      None
    • Environment:
      Platform: All, OS: All
    • Similar Issues:

      Description

      When for example on /hudson/configure the executables sh or cvs can't be located
      the error message might cause a horizontal scrollbar to appear in the browser if
      the PATH is rather long. This is rather annoying if you then open an elaborate
      help text which requires a lot of scrolling left and right.

      This patch makes use of the tokenized diretories to create a ', ' separate list
      to allow the browser to wrap the line easier.

      When I tested this patch I noticed that the QuotedStringTokenizer mangled my
      windows directory paths. C:\WINDOWS\system32 came out as C:WINDOWSsystem32.
      Which explained why it couldn't locate cvs even when it is on the path. I
      patched this also in the FormFieldValidator by replace \ with
      just before the
      PATH is tokenized. This does the trick. But the question remains if this
      problem occurs in other situations?

        Attachments

          Activity

          Hide
          jjasper jjasper added a comment -

          Created an attachment (id=368)
          Mentioned patch

          Show
          jjasper jjasper added a comment - Created an attachment (id=368) Mentioned patch
          Hide
          jjasper jjasper added a comment -

          Since I got the developer role might as well patch it.

          Show
          jjasper jjasper added a comment - Since I got the developer role might as well patch it.
          Hide
          jjasper jjasper added a comment -

          Note: Windows path bug filed separate as bug 2334.

          Show
          jjasper jjasper added a comment - Note: Windows path bug filed separate as bug 2334.
          Hide
          jjasper jjasper added a comment -

          Since I got the developer role might as well patch it. But now the correct item:
          'assigned to'.

          Show
          jjasper jjasper added a comment - Since I got the developer role might as well patch it. But now the correct item: 'assigned to'.
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in hudson
          User: : jjasper
          Path:
          trunk/hudson/main/core/src/main/java/hudson/util/FormFieldValidator.java
          trunk/www/changelog.html
          http://fisheye4.cenqua.com/changelog/hudson/?cs=12046
          Log:
          [FIXED JENKINS-2317] Suppress the need for a scroll-bar on the configure page when the PATH is very long

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in hudson User: : jjasper Path: trunk/hudson/main/core/src/main/java/hudson/util/FormFieldValidator.java trunk/www/changelog.html http://fisheye4.cenqua.com/changelog/hudson/?cs=12046 Log: [FIXED JENKINS-2317] Suppress the need for a scroll-bar on the configure page when the PATH is very long

            People

            Assignee:
            jjasper jjasper
            Reporter:
            jjasper jjasper
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: